Patch for 10.3.5
Added work in progress work addressing
- Proper creation of new revisions, thus fixing the reported issue
- Fixing multivalue fields
- Fixing string fields handling
- Avoid error on paragraph parent entities, that are not paragraphs - such as Library items from the paragraph library
- Some tidying up
todo:
- Multiple revisions are currently created for every change to a single entity, could be related to other modules/workflow moderation on my testing environment.
simeonkesmev → made their first commit to this issue’s fork.
simeonkesmev → made their first commit to this issue’s fork.
There are instances where the form ID can have uniquifying suffix, so here is a change to account for that.
The whole approach looks fragile to me as in theory there can be multiple blocks on the page.
Also I have problem with the facets as the parameter "exposed_form_display" does not get attached, as commented in #28. What is the use case for it?
The extra empty parameter check from #36 and added in #42 broke the handling of array parameters (such as facets) for me. I've fixed it by first cleaning the variable mixing and then deleting this check as It looks to me that is already handled in
if (!isset($form[$name]) && !empty($query[$name]) && ($value = $query[$name]) !== '') {
SimeonKesmev → made their first commit to this issue’s fork.
SimeonKesmev → made their first commit to this issue’s fork.
SimeonKesmev → created an issue.
Change to the patch avoiding hardcoded file names and fixing deprecated functiontion call
SimeonKesmev → created an issue.
The patch I've uploaded was based on the core repo, which is not usable.
The provided patches only handle cases where the provided argument is missing or has a default value. The exact same thing needs to happen where value is provided, but does not validate.
I will also create a test at some point, but for now just adding the correct patch.
SimeonKesmev → created an issue.
The issue is coming from the static caching in the language manager before the config overrider can provide new values. If the language negotiator changes the language (even if the default language is using prefix) the static cache is cleared.
SimeonKesmev → created an issue.
SimeonKesmev → created an issue.