- Issue created by @SimeonKesmev
- last update
over 1 year ago run-tests.sh fatal error - @simeonkesmev opened merge request.
- Status changed to RTBC
about 1 year ago 4:52pm 7 November 2023 - 🇺🇦Ukraine taraskorpach Lutsk 🇺🇦
+1 RTBC. I've encountered this problem with the region. Your solution is a good fit here
- Status changed to Needs work
about 1 year ago 8:20am 12 November 2023 - 🇮🇳India nitesh pawar
- Status changed to RTBC
about 1 year ago 9:52am 20 November 2023 - last update
about 1 year ago 2 fail - 🇺🇦Ukraine taraskorpach Lutsk 🇺🇦
LGTM. I applied the patch from issue #4 to enhance flexibility, as suggested by the author. Now, I can easily modify the token URL, region, and API URL to better suit my needs. Everything is functioning as expected.
The last submitted patch, 4: tmgmt_microsoft-support-region-3372842-#3.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- First commit to issue fork.
- 🇺🇸United States charginghawk
I updated the #4 patch so that the fields are optional and use the Global values if they aren't entered:
https://git.drupalcode.org/issue/tmgmt_microsoft-3372842/-/compare/8.x-1...
I can't make an MR of it, not sure why.
- Status changed to Needs review
11 months ago 7:53pm 4 March 2024 - First commit to issue fork.
- 🇺🇸United States torfj Seattle, WA
I used the changes from MR 2 and it worked for me by adding adding the region to the token url. For example for westus2 it would be https://westus2.api.cognitive.microsoft.com/sts/v1.0/issueToken/ .
Patch #4 also works but I believe the API URL will always be the same. This issue is about adding the option to change the token URL and not the API url.