Thanks again @klausi for all the help on this! I fixed the two coding standard issues you noticed.
I did do some more testing with a user that doesn't have edit term permissions and noticed that when clicking on terms in the tree it will cause an ajax error. I added some more logic to make sure that the ajax request is only send to the server if the user has the edit term permission. In addition, I noticed console errors when a user doesn't have the delete term permission, which I also fixed.
Good point! I was able to fix the redirect issue by overwriting the redirect in the save function of the TaxonomyManagerTermForm. Let me know if you have a better way of doing that.
Also, I removed an unused function (taxonomyTermSubmitHandler) from the TaxonomyManagerForm class.
I did some more testing with media library integration and it works well for me now. In addition I also checked that you can still use the 'Add another item' button (if you have a field with unlimited amount of values allowed) without it causing any AJAX errors.
This should mean that we don't need a setting to enable/disable AJAX.
Thank you, I addressed the comments. I think we need to discuss further how to handle having the tid in the URL.
torfj → changed the visibility of the branch 3507620-test to hidden.
Thank you @klausi for the feedback! Having someone like you help maintain this module would it greatly.
I cleaned up the code, addressed the concerned in the MR and checked for code quality warnings.
For me it works well now. The only thing missing is that before the term ID was added to the URL. I think this should be a follow up issue, but let me know.
Hi @vinayakmk47. Only maintainers can update the logo.
Thank you for making another logo, I like the new version better. But personally I think there is too much going on in the image.
I tried to make a really simple one. Let me know what you think.
I concur with @klausi’s assessment of the critical nature of this issue, as the AJAX functionality is central to the module’s purpose.
After investigating the problems with AJAX interactions in media libraries and the non-functional “Add another item” button (which appears when a field has unlimited cardinality), I found that initiating the AJAX call to render the term edit form directly in JavaScript resolves these issues.
I plan to conduct further testing and clean up the code next week when I have more time.
Currently, both the AJAX that renders the term edit form when clicking in the tree and the AJAX and styling within the term edit form are functioning well.
I am a MR with the changes that will convert NULL to an empty string before calling str_replace().
Thank @vinayakmk47! I think that a good start. Could you try to make one without the module name in it and make it look a bit cleaner.
Please make a MR with the changes. Thank you.
Fixed all issues and merged the changes to the dev branch.
torfj → changed the visibility of the branch project-update-bot-only to hidden.
torfj → changed the visibility of the branch 3431948-automated-drupal-11 to hidden.
Please provide steps to reproduce the error. Thank you!
Fixed
Thank you @rlhawk!
Removed the "Add Child" code and merged the changes to the dev branch.
Thanks everyone! I made a few improvements and merged the changes to the dev branch.
I made a MR with the latests patch and fixed some phpcs errors. The patch is working well for me. Thanks @gcalex5!
The latest changes are not applying anymore for me using composer. I am using Core 10.3.6
Updated the readme according to the template https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
I renamed the cache_debugger.menu.yml to cache_debugger.links.menu.yml to make it appear on the admin menu.
Added cache debugger configuration permissions and merged changes.
The code I contributed here was copied by @dburiak into this issue: AJAX error when editing term content 🐛 AJAX error when editing term content Postponed: needs info without any acknowledgment. Please close this issue and give me proper credit. Thank you.
The search functionality is also not working with these changes..
It also seems rather radical to completely render the form without Ajax, as this is not ideal from a user experience perspective. Do the maintainers have any plans to look into a solution where Ajax will still work on the form?
This issues causes the toolbar position to be next to the tree and only abote the term page. Before it was above both the tree and term page. See images.
I contacted the maintainer two weeks ago when this issus was created. But I haven't heard back yet.
I contacted the maintainer using the contact form when this issue was created. But I haven't heard back yet.
I fixed the phpcs issues.
I fixed the styleslint warnings. Please review.
Fixed a merge conflict. The AI content module routing file has been removed on 1.0.x.
I fixed all the eslint issues. Please review.
Fixed all phpcs and cspell warnings and merged the changes to the dev branch.
Added .gitlab-ci.yml file and verified that it works. Merged to the dev branch.
After making sites/default writeable (ddev exec chmod -R 777 web/sites/default/) it works for me.
If it is still not working try running: "ddev mutagen reset" and "ddev start".
See this Github issue for more info: https://github.com/ddev/ddev/issues/6726
I made some improvement to MR 11 and did some more testing. It seems to work well for me. Please review.
Made some additional edits to make sure it complies with the READ.md template → . And made a MR with those changes.
I made a MR with D11 compatibility fixes. Please review.
I update the incorrect maintainer name and remove the recommended modules section from table of contents since it was removed in an earlier commit. Please review.
I tested the patch and it works.
I used the changes from MR 2 and it worked for me by adding adding the region to the token url. For example for westus2 it would be https://westus2.api.cognitive.microsoft.com/sts/v1.0/issueToken/ .
Patch #4 also works but I believe the API URL will always be the same. This issue is about adding the option to change the token URL and not the API url.
torfj → changed the visibility of the branch 3372842-charginghawk-030424 to hidden.
I applied the first patch to the latests versions of the module. I tested on taxonomy terms and it seems to work well, but needs more testing for other entity types.
torfj → changed the visibility of the branch 3166002-az-filter-support-other-entities to hidden.
Updated the code to use the startDateIsDisplayed core function to check if the start date should be displayed.
I made a MR with a fix. Can someone pleaser review? Thanks you!