🇺🇸United States @torfj

I added some logic to preserve child terms when moving taxonomy terms across vocabularies since before that when moving a term to a new vocabulary children were deleted. But if you're just moving to a new parent within the same vocabulary the children are not deleted.

Okay, I will try to see if I can figure out what the problem is next week.

For moving term from site to site we use the Views Data Export → module to export terms to a CSV file and then we use the Feeds → module to import them. But I have never used it on translated terms.

torfj → made their first commit to this issue’s fork.

Closing this since this issue is not related to the taxonomy manager.

Fixed in https://www.drupal.org/project/taxonomy_manager/issues/3505219 🐛 Restore term clicking AJAX functionality Active

This is a duplicate of https://www.drupal.org/project/taxonomy_manager/issues/2799359 📌 Move terms to different vocabulary Needs work

I can confirm that the Enable translations is greyed out and not able to enable even though I ahve the content translations module enabled.

@anaconda777 where you able to figure out what the problem was?

@leeksoup Thanks for the input!
I’ve created an issue in the Pathauto module’s issue queue to see what they recommend regarding updating URL aliases when moving taxonomy terms.
Once I get feedback from the Pathauto maintainers, I’ll update this thread with their suggestions. Let me know if you have any thoughts in the meantime!

Issue: https://www.drupal.org/project/pathauto/issues/3513096 💬 Best approach for updating URL Alias when moving a taxonomy term Active

torfj → created an issue.

I can confirm what @devad mention that the term URL alias doesn't get updated when moving a term to a new vocabulary.
I tried do that on the D7 version of the taxonomy manager and the URL does automatically get updated there.

I think it would be beneficial to have the same behavior here. However, since the Pathauto module is a contrib module rather than part of Drupal core, it might not be strictly necessary.

I have added the following checks to the MoveTermsForm and TaxonomyManagerForm since there were no permissions checks before.

- Added a check to ensure the user has permission to create terms in the target vocabulary.
- Added a check to ensure the user has permission to delete terms in the source vocabulary if the keep_old_parents checkbox is not checked. If the user does not have the required permission, an error message is displayed.
- Added an access check to the move button to ensure it is only displayed if the user has permission to edit terms in the vocabulary.

I merged the working branch with the changes from the latests release and did some more testing. Moving terms seems to be working well.

One thing I noticed is that the move button should be disabled when no term is selected. I will be working on that.
Also, I think it would be good to show some warning message that moving a term to a different vocabulary could results in data loss if the two vocabulary doesn't have the same fields.

torfj → changed the visibility of the branch 2799359-36 to hidden.

Thanks @vibrasphere! I just added a stable release.

I committed the new logo. I decided to go with the simple version. We can change it later on if people don't like it. Thank you @vinayakmk47 for working with me on this!

I tried again today to test your original MR and now it is working without problems. Not sure what I did wrong yesterday. Sorry about that!

I also tested the latests changes in the merge request that is replacing the static calls in TaxonomyManagerTree and it is working well for me.

Thank you @klausi for fixing all of this!

Actually, I was able to get it to work by replacing `TaxonomyManagerTree:self::getFirstPath($term_to_expand, $list);` with `TaxonomyManagerTree::getFirstPath($term_to_expand, $list);`.

Now it still works and the phpstan warning is not showing.

torfj → changed the visibility of the branch 3510691-fix-broken-tree-2 to hidden.

After the changes in the TaxonomyManagerTree the edit term form is not rendering for me. See: https://www.drupal.org/project/taxonomy_manager/issues/3474919 🐛 Form element taxonomy_manager_tree broken Active .

I tried to create a fix for it but I can't get it to point to the correct target branch. Please help.

torfj → changed the visibility of the branch 3510691-fix-broken-tree to hidden.

torfj → made their first commit to this issue’s fork.

Thanks again @klausi for working with me on this! I added the missing title.

Please note the following issue can also be closed once the changes has been committed: #3491197 📌 Wrong Toolbar position after updating to 2.0.16 Active

I made a MR and fixed the issue. I will make a new release shortly with the changes.

@jannahka I tested with a user that only has permission to edit terms in a specific vocabulary.
I also tested with a user that has the administer taxonomy permission which allows a user to edit any taxonomy term.

Thanks again @klausi for all the help on this! I fixed the two coding standard issues you noticed.

I did do some more testing with a user that doesn't have edit term permissions and noticed that when clicking on terms in the tree it will cause an ajax error. I added some more logic to make sure that the ajax request is only send to the server if the user has the edit term permission. In addition, I noticed console errors when a user doesn't have the delete term permission, which I also fixed.

Good point! I was able to fix the redirect issue by overwriting the redirect in the save function of the TaxonomyManagerTermForm. Let me know if you have a better way of doing that.
Also, I removed an unused function (taxonomyTermSubmitHandler) from the TaxonomyManagerForm class.

I did some more testing with media library integration and it works well for me now. In addition I also checked that you can still use the 'Add another item' button (if you have a field with unlimited amount of values allowed) without it causing any AJAX errors.

This should mean that we don't need a setting to enable/disable AJAX.

Thank you, I addressed the comments. I think we need to discuss further how to handle having the tid in the URL.

torfj → changed the visibility of the branch 3507620-test to hidden.

torfj → created an issue.

torfj → created an issue.

Thank you @klausi for the feedback! Having someone like you help maintain this module would it greatly.

I cleaned up the code, addressed the concerned in the MR and checked for code quality warnings.
For me it works well now. The only thing missing is that before the term ID was added to the URL. I think this should be a follow up issue, but let me know.

Hi @vinayakmk47. Only maintainers can update the logo.

Thank you for making another logo, I like the new version better. But personally I think there is too much going on in the image.

I tried to make a really simple one. Let me know what you think.

I concur with @klausi’s assessment of the critical nature of this issue, as the AJAX functionality is central to the module’s purpose.

After investigating the problems with AJAX interactions in media libraries and the non-functional “Add another item” button (which appears when a field has unlimited cardinality), I found that initiating the AJAX call to render the term edit form directly in JavaScript resolves these issues.

I plan to conduct further testing and clean up the code next week when I have more time.

Currently, both the AJAX that renders the term edit form when clicking in the tree and the AJAX and styling within the term edit form are functioning well.

torfj → made their first commit to this issue’s fork.

I am a MR with the changes that will convert NULL to an empty string before calling str_replace().

torfj → created an issue.

Thank @vinayakmk47! I think that a good start. Could you try to make one without the module name in it and make it look a bit cleaner.

torfj → created an issue.

Please make a MR with the changes. Thank you.

Fixed all issues and merged the changes to the dev branch.

torfj → changed the visibility of the branch project-update-bot-only to hidden.

torfj → changed the visibility of the branch 3431948-automated-drupal-11 to hidden.

torfj → made their first commit to this issue’s fork.

Please provide steps to reproduce the error. Thank you!

Fixed

Thank you @rlhawk!

Removed the "Add Child" code and merged the changes to the dev branch.

torfj → created an issue.

torfj → created an issue.

torfj → created an issue.

Thanks everyone! I made a few improvements and merged the changes to the dev branch.

torfj → made their first commit to this issue’s fork.

I made a MR with the latests patch and fixed some phpcs errors. The patch is working well for me. Thanks @gcalex5!

torfj → made their first commit to this issue’s fork.

The latest changes are not applying anymore for me using composer. I am using Core 10.3.6

Updated the readme according to the template https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →

torfj → created an issue.

I renamed the cache_debugger.menu.yml to cache_debugger.links.menu.yml to make it appear on the admin menu.

torfj → created an issue.

Added cache debugger configuration permissions and merged changes.

The code I contributed here was copied by @dburiak into this issue: AJAX error when editing term content 🐛 AJAX error when editing term content Postponed: needs info without any acknowledgment. Please close this issue and give me proper credit. Thank you.

torfj → created an issue.

torfj → created an issue.

The search functionality is also not working with these changes..

It also seems rather radical to completely render the form without Ajax, as this is not ideal from a user experience perspective. Do the maintainers have any plans to look into a solution where Ajax will still work on the form?

This issues causes the toolbar position to be next to the tree and only abote the term page. Before it was above both the tree and term page. See images.

I contacted the maintainer two weeks ago when this issus was created. But I haven't heard back yet.

I contacted the maintainer using the contact form when this issue was created. But I haven't heard back yet.

I fixed the phpcs issues.

I fixed the styleslint warnings. Please review.

torfj → created an issue.

torfj → created an issue.

Fixed a merge conflict. The AI content module routing file has been removed on 1.0.x.

I fixed all the eslint issues. Please review.

torfj → created an issue.

Fixed all phpcs and cspell warnings and merged the changes to the dev branch.

torfj → created an issue.

Added .gitlab-ci.yml file and verified that it works. Merged to the dev branch.