- Issue created by @klausi
- First commit to issue fork.
- πΊπΈUnited States torfj Seattle, WA
After the changes in the TaxonomyManagerTree the edit term form is not rendering for me. See: https://www.drupal.org/project/taxonomy_manager/issues/3474919 π Form element taxonomy_manager_tree broken Active .
I tried to create a fix for it but I can't get it to point to the correct target branch. Please help.
- πΊπΈUnited States torfj Seattle, WA
Actually, I was able to get it to work by replacing `TaxonomyManagerTree:self::getFirstPath($term_to_expand, $list);` with `TaxonomyManagerTree::getFirstPath($term_to_expand, $list);`.
Now it still works and the phpstan warning is not showing.
- π¦πΉAustria klausi π¦πΉ Vienna
I don't fully understand what is exactly broken for you - can you post the error message?
The old issue was broken because the annotation "@FormElement" was changed by accident. That was not done here.
- π¦πΉAustria klausi π¦πΉ Vienna
I updated your merge request by replacing all the static calls in TaxonomyManagerTree. It is bad practice to repeat the class name all over the place, then any extending class cannot selectively override methods.
I also updated the core version requirement to 10.3.
Let me know if this works for you! I want to make a new release soon.
- πΊπΈUnited States torfj Seattle, WA
I tried again today to test your original MR and now it is working without problems. Not sure what I did wrong yesterday. Sorry about that!
I also tested the latests changes in the merge request that is replacing the static calls in TaxonomyManagerTree and it is working well for me.
Thank you @klausi for fixing all of this!
-
klausi β
committed 6660aef9 on 2.0.x authored by
torfj β
fix(tree): Bump Drupal core dependency to 10.3, use static keyword for...
-
klausi β
committed 6660aef9 on 2.0.x authored by
torfj β
Automatically closed - issue fixed for 2 weeks with no activity.