- 🇫🇮Finland sokru
Needs at least reroll. Also this would greatly benefit from tests. The validation doesn't seem to take into account that some vocabulary might be translatable and other not and moving translated term to non-translatable vocabulary probably causes errors.
- First commit to issue fork.
- 🇺🇸United States jsutta United States
I rebased the issue's merge request against the current 2.0.x branch and readded the changes from #27. A patch generated from the merge request applies cleanly against the latest release in my environment.
- 🇺🇸United States torfj Seattle, WA
Patch also applied cleanly for me and moving terms within a taxonomy seems to be working well. However, when I tried enable the option to 'Keep old parents and add new ones' I get this error:
Error: Call to undefined method Drupal\taxonomy\Entity\Vocabulary::setHierarchy() in Drupal\taxonomy_manager\Form\MoveTermsForm->submitForm() (line 188 of /opt/drupal/web/modules/contrib/taxonomy_manager/src/Form/MoveTermsForm.php). - 🇺🇸United States torfj Seattle, WA
Linted the code and added a validation check to ensure only one vocabulary is selected.
I think it might also be necessary to add an access check before moving terms across vocabularies to confirm that the user has both delete term permissions in source and create term permissions in destination.
- 🇺🇸United States jsutta United States
The latest commits apply cleanly and work on my end. Thank you @torfj!