@orakili I added 2 comments to your PR about DeprecationHelper class and code duplication.
Correct me if I'm wrong @sthomen but your changes make 3.x not compatible with < Drupal 10.2.
Isn't it better to use DeprecationHelper to support older versions as well?
if (!class_exists(DeprecationHelper::class)) {
$element['#upload_validators']['file_validate_extensions'][0] = implode(' ', $extensions);
}
else {
DeprecationHelper::backwardsCompatibleCall(
\Drupal::VERSION,
'10.2',
static function () use ($extensions, &$element) {
$element['#upload_validators']['FileExtension'][0] = implode(' ', $extensions);
},
static function () use ($extensions, &$element) {
$element['#upload_validators']['file_validate_extensions'][0] = implode(' ', $extensions);
}
);
}@smustgrave the summary is updated. Please review.
dburiak → changed the visibility of the branch 3419621-typeerror-inarray-argument to hidden.
@smustgrave The string in the original issue was calling from Geofield Map module (already fixed). The summary is updated with a proposed solution section.
This issue is not related to the ckeditor_html_embed and duplicates
https://www.drupal.org/project/drupal/issues/3364884
🐛
JavaScript operators in
Needs work
On the referenced issue there is a patch to fix this.
I think this one can to be closed.
Added MR to 11.x: https://git.drupalcode.org/issue/drupal-3419621/-/tree/3419621-typeerror...
Please review.
dburiak → changed the visibility of the branch 3419621-typeerror-inarray-argument-d11 to hidden.
dburiak → changed the visibility of the branch 3419621-typeerror-inarray-argument-d11 to active.
Updated test-only patch with fixed coding standards.
Here is the test-only patch showing the issue.
Without patching, the test will fail.
Added a patch based on the proposed solution.
Sure @smustgrave
Thank you for review.
The doTestHomePageLinks test method is updated to fix the subdirectory multisite case for the PHPUnit testing run.
Added a patch with the changes above to simplify using with composer.
+
The summary is updated. Also, the full patch is attached.
@larowlan the changes from the patch above cause another regression with front page links. I created a new issue: 🐛 [regression] Language switcher block returns links to node on the frontpage Fixed