Account created on 17 January 2013, almost 12 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡¦Ukraine dburiak

The MR !34 works for me without any issues - RTBC.

πŸ‡ΊπŸ‡¦Ukraine dburiak

The patch #8 is updated to apply to the latest 4.x

πŸ‡ΊπŸ‡¦Ukraine dburiak

Also, I don't think #26 changes the solution, just extending it.
The MR!8743 is updated to pass the code styles check. Please review.

πŸ‡ΊπŸ‡¦Ukraine dburiak

The PR is updated.
The updated patch can be found in the attachment.

πŸ‡ΊπŸ‡¦Ukraine dburiak

Attached is an updated patch with flashing as it's done on the Flush Single Image Style module.

πŸ‡ΊπŸ‡¦Ukraine dburiak

This should be reopened as it causes incompatibility with Drupal 10.2.7.
Please see the comment πŸ“Œ Change the 1.1.x branch to support Drupal <= 10.2 for a smoother update process and revert new changes Fixed on bootstrap_styles module.
The operator ( `<=10.2` ) limits anything higher than 10.2.0 on the 10.2.x range.

πŸ‡ΊπŸ‡¦Ukraine dburiak

This should be reopened as I also faced incompatibility with Drupal 10.2.7.
Agree with @vangelisp

πŸ‡ΊπŸ‡¦Ukraine dburiak

Combined the changes from MR!6125 and #26 to MR!8743.
The MR!6125 is hidden as redundant.

πŸ‡ΊπŸ‡¦Ukraine dburiak

dburiak β†’ changed the visibility of the branch 3041174-adjust-layout-builder to hidden.

πŸ‡ΊπŸ‡¦Ukraine dburiak

It looks like it's related to the Drupal core issue https://www.drupal.org/project/drupal/issues/2504115 β†’ .

The workaround is to render the form without Ajax and send a taxonomy term ID through the URL query parameter.
The patch is attached.

πŸ‡ΊπŸ‡¦Ukraine dburiak

The issue is still relevant for 2.0.x-dev.
I can confirm that the attached patch fixes the issue.

πŸ‡ΊπŸ‡¦Ukraine dburiak

The patch works for me on Drupal 11.

πŸ‡ΊπŸ‡¦Ukraine dburiak

Patch #15 has been updated to work on the latest codebase 3.1.x-dev.

πŸ‡ΊπŸ‡¦Ukraine dburiak

@orakili I added 2 comments to your PR about DeprecationHelper class and code duplication.

πŸ‡ΊπŸ‡¦Ukraine dburiak

dburiak β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡¦Ukraine dburiak

Correct me if I'm wrong @sthomen but your changes make 3.x not compatible with < Drupal 10.2.
Isn't it better to use DeprecationHelper to support older versions as well?

if (!class_exists(DeprecationHelper::class)) {
      $element['#upload_validators']['file_validate_extensions'][0] = implode(' ', $extensions);
    }
    else {
      DeprecationHelper::backwardsCompatibleCall(
        \Drupal::VERSION,
        '10.2',
        static function () use ($extensions, &$element) {
          $element['#upload_validators']['FileExtension'][0] = implode(' ', $extensions);
        },
        static function () use ($extensions, &$element) {
          $element['#upload_validators']['file_validate_extensions'][0] = implode(' ', $extensions);
        }
      );
    }
πŸ‡ΊπŸ‡¦Ukraine dburiak

dburiak β†’ changed the visibility of the branch 1.0.x to hidden.

πŸ‡ΊπŸ‡¦Ukraine dburiak

@smustgrave the summary is updated. Please review.

πŸ‡ΊπŸ‡¦Ukraine dburiak

dburiak β†’ changed the visibility of the branch 3419621-typeerror-inarray-argument to hidden.

πŸ‡ΊπŸ‡¦Ukraine dburiak

@smustgrave The string in the original issue was calling from Geofield Map module (already fixed). The summary is updated with a proposed solution section.

πŸ‡ΊπŸ‡¦Ukraine dburiak

This issue is not related to the ckeditor_html_embed and duplicates https://www.drupal.org/project/drupal/issues/3364884 πŸ› JavaScript operators in Needs work
On the referenced issue there is a patch to fix this.
I think this one can to be closed.

πŸ‡ΊπŸ‡¦Ukraine dburiak

dburiak β†’ changed the visibility of the branch 3419621-typeerror-inarray-argument-d11 to hidden.

πŸ‡ΊπŸ‡¦Ukraine dburiak

dburiak β†’ changed the visibility of the branch 3419621-typeerror-inarray-argument-d11 to active.

πŸ‡ΊπŸ‡¦Ukraine dburiak

Updated test-only patch with fixed coding standards.

πŸ‡ΊπŸ‡¦Ukraine dburiak

Here is the test-only patch showing the issue.
Without patching, the test will fail.

πŸ‡ΊπŸ‡¦Ukraine dburiak

Added a patch based on the proposed solution.

πŸ‡ΊπŸ‡¦Ukraine dburiak

The doTestHomePageLinks test method is updated to fix the subdirectory multisite case for the PHPUnit testing run.

πŸ‡ΊπŸ‡¦Ukraine dburiak

The summary is updated. Also, the full patch is attached.

πŸ‡ΊπŸ‡¦Ukraine dburiak

@larowlan the changes from the patch above cause another regression with front page links. I created a new issue: πŸ› [regression] Language switcher block returns links to node on the frontpage Fixed

Production build 0.71.5 2024