- Issue created by @Robert Ngo
- last update
over 1 year ago 28,497 pass - Status changed to Needs review
over 1 year ago 7:21pm 26 April 2023 - Status changed to Needs work
about 1 year ago 6:33pm 30 April 2023 - ๐บ๐ธUnited States smustgrave
Thanks for reporting.
As a bug it will need a test case showing the issue. Believe core has method for testing console errors.
- ๐ฉ๐ชGermany Anybody Porta Westfalica
Just ran into the same issue when uploading a file in a media within a modal. The result is a broken widget, which isn't usable anymore.
- ๐ฉ๐ชGermany Anybody Porta Westfalica
Increasing priority as of #7, but I'm wondering why we're the second ones experiencing this, might be caused by contrib.
Already removed all other patches to ensure it's not a patch braking this.If it helps: This seems to happen since the upgrade to Drupal 10.1.1 and before this issue I see ๐ ckeditor5.dialog.fix.js throws "Uncaught TypeError: event.target.classList is undefined" in Firefox in Drupal 10 with the editor in a modal Fixed in the console, which *might* be (un)related.
- ๐ฉ๐ชGermany Anybody Porta Westfalica
Interesting, just with disabling CSS / JS cache, clearing caches and coming back, the error in the console is gone, but I still see the
ui-widget-overlay ui-front
overlay above the modals, blocking all editing, once a second modal is opened. So maybe this is unrelated? Super strange things going on... - ๐ฉ๐ชGermany Anybody Porta Westfalica
Okay in the end it turned out, that it was this issue for us: ๐ Overlay blocking image upload modal in Drupal 10.1 Fixed still I dont know why this error in the console disappeared in #9. -.-
- ๐จ๐ฆCanada liquidcms
I am occasionally getting this on a D9.5.3 site. It was consistently working for many months but has recently been broken. Originally i thought it was only admin users using Firefox as it seemed to always work in Chrome or for non-admins. But just now i see the issue for a non-admin in Chrome.
This patch does not apply. Will try manual patch.
- ๐จ๐ฆCanada liquidcms
with a very small sample size of testing (since it wasn't consistently occurring); this seems to have fixed the issue.
- ๐ฎ๐ณIndia AditiVB
Aditi Saraf โ made their first commit to this issueโs fork.
- First commit to issue fork.
- last update
9 months ago 30,417 pass - ๐จ๐ฆCanada liquidcms
spoke too soon. With the fix from #2, i still see this issue.
- Merge request !5266Issue #3356667: Error: Cannot read properties of undefined (reading... โ (Open) created by vselivanov
- ๐บ๐ฆUkraine vselivanov Kyiv, Ukraine
I had this issue with undefined and also similar with null with Drupal 10.1.5.
Added null check to the patch #2 and created MR.
But we still need a tests. - ๐ง๐ชBelgium tim-diels Belgium ๐ง๐ช
I'm also experiencing this when using AJAX requests in modals on Drupal 10.1.6.
But looking at the solutions provided in #2 and the MR it only masks the problem and does not solves it.My use case:
- Have a custom or contrib StylePlugin extending the StylePluginBase from views. For example UI Patterns 2.x
- Have that plugin work with a subform state so it rebuilds on selecting an option
- Without the patches it throws the error
- With the patches it does not throw the error but does not resize the modal, only after manually resizing the browser window so it triggers the resize event
- ๐ฌ๐งUnited Kingdom 3li U.K. ๐ฌ๐ง
Same as tim-diels I found that #2 & MR are simply ignoring the error and not solving the problem.
The issue I was finding is that the error is caused by failing to pass data over to theresetSize
function.I found if I removed the
debounce
method the error went away and also for me the auto resizing of modal/dialog was happening upon load.I'm not totally sure how we can write tests for this though.
- last update
8 months ago Patch Failed to Apply - last update
6 months ago Patch Failed to Apply - Status changed to Needs review
4 months ago 10:33am 3 April 2024 - ๐ฎ๐ณIndia Jeya sundhar Coimbatore
I checked #19 patch. that patch not worked for me. few changes based on Stackoverflow answer.
- last update
4 months ago Patch Failed to Apply - Status changed to Needs work
4 months ago 11:30am 3 April 2024 The Needs Review Queue Bot โ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- Status changed to Needs review
4 months ago 1:04pm 3 April 2024 - Status changed to Needs work
4 months ago 2:09pm 4 April 2024 - First commit to issue fork.
- ๐ฌ๐งUnited Kingdom catch
Just had this reported on a site that's on 10.1. This is using the media widget on a media field (on a comment, not that this would matter) and only happens very intermittently.
Given the intermittent nature of the bug, I'm removing the 'needs tests' tag - we should double check we have test coverage for the media widget, but getting consistent steps to reproduce with core, that are then reproducible with functional javascript testing may not be possible here.
Rebased the MR so that it gets passed cspell, but it's now failing the tabbable shim nightwatch test which either indicates a bug or may need updating: https://git.drupalcode.org/project/drupal/-/jobs/1270916
Bumping back to major because this renders the media widget unusable with no workarounds and appears to be affecting other areas like layout builder too.
- ๐ช๐ธSpain Carlitus
I've tried with #28 with drupal 10.3 but doesnt work.
- ๐บ๐ธUnited States jesss
#27 works for me on 10.3 in terms of resolving the console error and allowing other processes to run, but now the dialog modal is aligned right instead of centered. If I resize the browser window, it snaps back to being centered.
(I was running into this issue using the Footnotes plugin with CKEditor 5. The Footnotes modal would open, but the Link button within the Footnotes modal's WYSIWYG would not launch its dialog without this patch.)
- First commit to issue fork.
- Merge request !8892Issue #3356667: Cannot read properties of undefined (reading 'settings')โจ with dialog.position.js โ (Open) created by scott_euser