My export breaks when upgrading to PHPSpreadsheet 2.3.2 but continues to work on version 2.3.0 (the insecure one).
This only appears to happen with larger exports -- this one in particular has 1200+ submissions. The export starts as expected, but mid-batch it crashes with the following error.
PhpOffice\PhpSpreadsheet\Reader\Exception: File "/tmp/classical_countdown_2024.xlsx" does not exist. in PhpOffice\PhpSpreadsheet\Shared\File::assertFile() (line 147 of /code/vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Shared/File.php).
When I downgraded to 2.3.0, the export completed without errors. (Currently on Webform XSLX Export 1.4 with the patch from 🐛 Typed property must not be accessed before initialisation Active applied.)
Updated the text to note that it may be necessary to set the priority for each subscriber, including a link to the documentation. @megachriz, maybe you can update the code examples to make it clearer how exactly one should do that?
@megachriz -- it's entirely possible that I am wrong! The example code provided does not include any information about setting the priority and even after reading documentation and tutorials for creating an EventSubscriber I couldn't figure out how to add it since the examples provided there were so different in format. Perhaps including that information would be a better documentation update than what I made?
Added a note explaining that AfterParseBase runs after EventSubscriberInterface since I had a use case that required both and it took me longer than it should have to figure out the order of events.
laura.gates → credited jesss → .
laura.gates → credited jesss → .
laura.gates → credited jesss → .
Created a merge request with the suggested fix.
jesss → created an issue.
#27 works for me on 10.3 in terms of resolving the console error and allowing other processes to run, but now the dialog modal is aligned right instead of centered. If I resize the browser window, it snaps back to being centered.
(I was running into this issue using the Footnotes plugin with CKEditor 5. The Footnotes modal would open, but the Link button within the Footnotes modal's WYSIWYG would not launch its dialog without this patch.)
Can confirm that I was seeing the same behavior (CKEditor would not load if CodeMirror plugin/Source Code button disabled). This patch resolves the issue.
This appears to be resolved in Mercury Editor 2.1.1. Can someone else confirm?
laura.gates → credited jesss → .
laura.gates → credited jesss → .
laura.gates → credited jesss → .
laura.gates → credited jesss → .
- Moved the point about how the issue should describe how the change will affect stakeholders from the review section to the list of items the issue should include when created.
- Tightened up the line about stakeholders with a vested interest. Their vested interest is in the change, not in the discussion about the change.
Commenting to note that bsnodgrass had asked me to review the Google Doc, which I did. I made a number of suggestions to add clarity and improve the document flow and organization.
Also:
joarferme
jdearie
bendygirl
alex-ua
jennaharrismosley
klanahan
ptkoroma
I am here with:
karen11
fogpuddle
nneka
laura.gates → credited jesss → .
I'm on 3.0.0-beta4. Did you clear cache after applying the patch?
Patch #86 is working for me!
THANK YOU!!! :-)
Looks great to me!
@fjgarlin, thanks for working on this! I'd be happy to review, but I don't know the password for the testing page.
I am still seeing this behavior in alpha14 on 10.2.3. Any chance of a fix?
From what I'm seeing on my site, there is no actual data loss. It's simply that when rendering the field, the text filter is stripping out tags that should be allowed. If you go to edit the content, all those "missing" tags are still there.
Coming here from 🐛 Several elements are missing from ckeditor5 Basic HTML Active .
My site's content is missing basic HTML tags after updating to 10.2.0 -- most noticeably bold and links. Turning off the Limit HTML Tags filter restored the missing tags but as others have noted, that is not a good long-term solution.
When I turned the Limit HTML Tags filter back on again, I was presented with the following error message:
The current CKEditor 5 build requires the following elements and attributes:
<br> <p> <h2> <h3> <h4> <h5> <h6> <* dir="ltr rtl" lang> <cite> <dl> <dt> <dd> <span> <figure> <figcaption> <iframe src height width allowfullscreen frameborder> <strong> <em> <code> <blockquote> <a href data-entity-type data-entity-uuid data-entity-substitution> <ul> <ol reversed start> <li> <img src alt height width data-entity-uuid data-entity-type data-caption data-align> <drupal-media data-entity-type data-entity-uuid alt data-caption data-align>
The following elements are missing:
<strong> <em> <code> <blockquote> <a href data-entity-type data-entity-uuid data-entity-substitution> <ul> <ol reversed start> <li> <img src alt height width data-entity-uuid data-entity-type data-caption data-align> <drupal-media data-entity-type data-entity-uuid alt data-caption data-align>
Of course, the field where I would add those elements back in is read-only...
With CKEditor 5 this is a read-only field. The allowed HTML tags and attributes are determined by the CKEditor 5 configuration. Manually removing tags would break enabled functionality, and any manually added tags would be removed by CKEditor 5 on render.
I do have source editing enabled (as well as the CodeMirror plugin), and everything worked without issue prior to updating core.
#6 (MR !23) resolves the warnings I've been seeing. Thank you!
No joy. This patch doesn't solve the problem -- it just moves it down a few lines.
There is a $configuration['id'] set with inline blocks. The issue is that it only has two components, not four. So the explode snippet itself needs to be reworked to account for use cases with fewer than four components.
My apologies for the confusion -- we're using the core Media Library widget, not Entity Browser.
Steps to reproduce:
- Add an autocomplete entity reference field to a media type using the Media Library widget on the form display.
- Create a paragraph type for that media type.
- Within Mercury Editor, add a paragraph of that type.
- After uploading your media, attempt to add an entity reference to that media item. See how the autocomplete dropdown is hidden by the modal.
laura.gates → credited jesss → .
laura.gates → credited jesss → .
laura.gates → credited jesss → .
I will note that Queue Order does do what it says on the tin, and allow you to give certain queue's more "weight" than others, and those annotations remain in the codebase for this module. However, there are other methods to control queue operations (such as Ultimate Cron) and Queue Order can cause conflicts. If Queue Order is the preferred method for a website, it can be installed separately, without the dependency.
laura.gates → credited jesss → .
laura.gates → credited jesss → .
laura.gates → credited jesss → .
laura.gates → credited jesss → .
laura.gates → credited jesss → .
laura.gates → credited jesss → .
I just tried to apply patch #202 and while the patch applied cleanly, it didn't seem to do anything -- I still don't have the option to display the selected entities as a table. I believe that's because the updated schema that has the new widget settings isn't imported if the module has already been enabled. I saw there was some discussion upthread about removing an update hook -- that probably needs to be revisited.