- Issue created by @jesss
- 🇬🇧United Kingdom joehuggans Harrogate, UK
Theres just a phpcs issue on line 122 of ManagedAdBlock.php, it's whitespace on the empty line. I'm not able to fix this myself on the branch, maybe this is by design.
In the ManagedAdBlock class the blockForm() function claims it is unchecking the Display title by default, but when adding a block, Display title is still checked by default.
public function blockForm($form, FormStateInterface $form_state) {
// Hide block title by default.
$form['label_display']['#default_value'] = FALSE;
That setting needs to be moved from the blockForm() function to the defaultConfiguration() function. This will properly set the default value to unchecked.
public function defaultConfiguration() {
return [
'label_display' => FALSE, // <--- ADD THIS INSTEAD
'ad_slot' => '',
'ad_format' => 'responsive',
'ad_width' => '',
'ad_height' => '',
'ad_shape' => 'auto',
'ad_layout_key' => '',
'ad_align' => 'center',
];
}
Active
Code
Theres just a phpcs issue on line 122 of ManagedAdBlock.php, it's whitespace on the empty line. I'm not able to fix this myself on the branch, maybe this is by design.