Inline text editor not working

Created on 25 May 2023, over 1 year ago
Updated 28 June 2024, 5 months ago

Problem/Motivation

The inline text editor is no longer working.

Steps to reproduce

  1. Add a new text paragraph via the mercury editor
  2. Add some text and save
  3. I cannot edit the text without editing the paragraph again
πŸ› Bug report
Status

RTBC

Version

2.1

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States Mirakolous

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Mirakolous
  • πŸ‡ΊπŸ‡ΈUnited States keiserjb

    I don't know if this is related but I get a lot of javascript errors in my console when editing content.

  • πŸ‡ͺπŸ‡ΈSpain Carlitus

    I have the same problem. A temporary solution is disable the mercury inline editor module.

  • πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

    The issue is most likely in Drupal 10.x, jQuery once support has been removed.
    @see https://www.drupal.org/node/3158256 β†’

    Since this module is still in alpha, it might be worth considering only supporting the latest version of Drupal 10.1.x. Once you move into beta, you can support older versions. I guess this decision depends on whether your clients can upgrade to Drupal 10.1.x

  • πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY

    Wow, I am very impressed by node.js setup/build, simply because it works as expected.

    Attached is a patch that converts the last remaining $.once('SELECTOR') call to $(once('SELECTOR')) in the mercury_editor_inline_editor.module.

  • Status changed to Needs review about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States jrockowitz Brooklyn, NY
  • First commit to issue fork.
  • @justin2pin opened merge request.
  • Status changed to RTBC about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States kurttrowbridge

    I set up Mercury Editor and the Inline Editor submodule on a test site and confirmed I initially could not edit a text Paragraph inline. Then I patched it with MR #17, and confirmed that inline editing was possible again. Thanks!

  • πŸ‡ͺπŸ‡ΈSpain Carlitus

    This may be a silly question, but how should this work?

    When I'm viewing a node built with Mercury editor I don't see any way to edit the text paragraphs.

    Does it have to be configured somehow?

  • πŸ‡ΊπŸ‡ΈUnited States keiserjb

    I think some of the confusion may be that the inline editor is still not working with ckeditor5.

  • πŸ‡ͺπŸ‡ΈSpain Carlitus

    Ahh, yes, I use ckeditor 5, that's it then.

    Thanks @keiserjb!

  • πŸ‡ΊπŸ‡ΈUnited States jesss

    This appears to be resolved in Mercury Editor 2.1.1. Can someone else confirm?

Production build 0.71.5 2024