As a Drupal 11 developer, i also face similar issue. And both suggested module do not supported. And don't want to deal with content blocks as some workarounds shows.
This is really fundumental basic thing when we think layout builder. But not sure why this not prioritized.. maybe whole layout builder get abandoned for sake of new experience builder thing..
After upgrading 2.0.10 (and could be related, installing ui_patterns_field and ui_patterns_ui), i no longer able to reproduce this issue.
Slot yml configs are now
search:
sources:
-
source_id: block
source:
plugin_id: search_form_block
search_form_block:
id: search_form_block
label: 'Search form'
label_display: '1'
provider: search
page_id: null
_weight: '0'
_remove:
dropdown_actions: { }
add_more_button: ''
prudloff, I want to directly pass my menu to SDC, I found https://git.drupalcode.org/project/bootstrap/-/blob/5.0.x/components/nav... and used similarly, but i'm seeing `Prop type not found by the compatibility checker.` error while placing SDC block.
I see there could be a limitations but Allowing only scalar types limits me and make me do tons more boilerplate work.
If i get menu as array, i could able to alter html of the same menu for mobile version. With slot, i can not.
Thank you davisa, Gist mentioned in #12 worked with `pnpm i @storybook/csf @storybook/global`
Workaround worked. Attaching patch for D11.2 (sorry to not creating merge request [dealing with core is time consuming to fetch pull etc])
Thank you, after merging it no longer see errors from domain module.
Ref: https://www.drupal.org/project/simple_sitemap/issues/3549246 🐛 Circular reference detected Active
Thank you Rajab, I was able to reproduce it in /core/install.php, core 11.2.4, ds 3.30.0 and fixed with commit e72d395ae0ef134a220b59eff70284e897851386
After uninstalling simple_sitemap_engine
Error changed:
Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "redirect.destination", path: "redirect.destination -> url_generator -> router.route_provider -> path_processor_manager -> domain_source.path_processor -> Drupal\Core\Logger\LoggerChannelFactoryInterface -> logger.raven". in Drupal\Component\DependencyInjection\Container->get() (line 147 of core/lib/Drupal/Component/DependencyInjection/Container.php).
Hi Mably,
Thank you for the patch, indeed event order change fixed the issue.
@mably thank you for the update.
Can i learn why service naming change always? https://git.drupalcode.org/project/domain/-/blob/3.0.0-alpha4/domain_con... vs https://git.drupalcode.org/project/domain/-/blob/3.0.0-alpha3/domain_con...
Asking because I have one dependent module, need to switch again and again
emircan erkul → created an issue.
/**
* Implements hook_form_FORM_ID_alter() for node forms.
*/
function gin_gutenberg_plus_form_node_form_alter(&$form, FormStateInterface $form_state) {
$node = $form_state->getFormObject()->getEntity();
// Leave early if Gutenberg is not enabled for this entity.
if ($node instanceof NodeInterface) {
return;
}
$nid = $node->id();
$form['actions']['revisions'] = [
'#type' => 'link',
'#title' => t('Revisions'),
'#url' => \Drupal\Core\Url::fromRoute('entity.node.version_history', ['node' => $nid]),
'#attributes' => [
'class' => ['action-link'],
],
'#weight' => -10,
];
}
emircan erkul → made their first commit to this issue’s fork.
https://git.drupalcode.org/project/domain/-/merge_requests/161 tested and works good, i had tons of generated tags in my view configs which also causing a lot performance issues.
yes we should
emircan erkul → made their first commit to this issue’s fork.
emircan erkul → created an issue.
What an annoying small bug was that.. I just simply want to change image style of first row and to accomplish that i was trying every combination of twig filters.. Finally end up here and custom module works.
This is the answer of what is bad about Drupal.. It is 8 years old issue.. really.
Confirm that #24 https://www.drupal.org/project/domain/issues/3232343#comment-16031559 📌 Domain Config loading is resource intensive Needs work works great. With this patch module page loading dropped ~3.5s to 1.2s
Thank you all & https://www.drupal.org/u/seyfettinkahveci →
emircan erkul → created an issue.
emircan erkul → created an issue.
@jurgenhaas feel free to review/modarate (close, discard etc.) or anyone could open this into gutenberg module.
But they might also say this is not gutenberg module issue and should be created in gin, right? But idk maybe we could create new module to do not cause World War 3 :)
Wow @jurgenhaas, you were quick :) I was working on it thats why i put into review. It was quick fix. Of course it is debatable where to put this styling. Yes best one would be in gutenberg module checking if active admin theme is gin and injecting spesific styles (or vice versa we could check if gutenberg active then injecting based on that to save 2 line of css ) but yea quickest way is like this.
emircan erkul → created an issue.
Tested: https://git.drupalcode.org/project/gin/-/merge_requests/504
Issue: Double Header (one is clickable other is not)
SS:
---
Tested: https://git.drupalcode.org/project/gin/-/merge_requests/512
Issue: Pointer events are disabled
SS:
---
Based on https://git.drupalcode.org/project/gin/-/merge_requests/512 fixed Pointer events issue and here is the PR(MR): https://git.drupalcode.org/project/gin/-/merge_requests/632
SS:
emircan erkul → made their first commit to this issue’s fork.
emircan erkul → created an issue.
Merge request contains 100% with to limit chart width and dependency fixes according to sample module within gutenberg module.
emircan erkul → made their first commit to this issue’s fork.
D11 compatibility fixes pushed, ready to review
emircan erkul → made their first commit to this issue’s fork.
emircan erkul → made their first commit to this issue’s fork.
emircan erkul → made their first commit to this issue’s fork.
@joristhedrupalist created one from yours but unfortunately it did not fix the conflict so, i pushed correct one.
emircan erkul → made their first commit to this issue’s fork.
Can't we get some from ConfigEntityStorage::MAX_ID_LENGTH and use for machine names? 32+16=48 would be sweet spot IMO and ConfigEntityStorage::MAX_ID_LENGTH become 166-16=150
emircan erkul → made their first commit to this issue’s fork.
emircan erkul → created an issue.
emircan erkul → created an issue.
#103 Fixing/suppressing
unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.PHPCS(DrupalPractice.FunctionCalls.InsecureUnserialize.InsecureUnserialize)
Notice: unserialize(): Error at offset 0 of 207 bytes in Drupal\metatag\Plugin\Field\FieldWidget\MetatagAsync->extractFormValues() (line 209 of modules/contrib/metatag/src/Plugin/Field/FieldWidget/MetatagAsync.php).
Drupal\metatag\Plugin\Field\FieldWidget\MetatagAsync->extractFormValues(Object, Array, Object) (Line: 237)
#19 for D9.5.11
Emircan Erkul → created an issue.
Sorry path was a bit wrong here is correct one
In my case, $.fn.once was not ready when script initialized which causes all headache.
Attached file solved my issue. Yes i should find the root cause but couldn't. Probably order of the loading those libraries causes but effected areas was huge to handle in my case. Anyway it's just temporary, we soon upgrade to D10.
Emircan Erkul → made their first commit to this issue’s fork.
Emircan Erkul → made their first commit to this issue’s fork.
Emircan Erkul → made their first commit to this issue’s fork.
Emircan Erkul → created an issue.
My PR includes secure attribute options for both. We can not make httpOnly true because eu_cookie_compliance uses those cookies via JS.
If the HttpOnly flag (optional) is included in the HTTP response header, the cookie cannot be accessed through client side script (https://owasp.org/www-community/HttpOnly)
Emircan Erkul → made their first commit to this issue’s fork.
@vasike included as MR from 2.0.x. I only included valueForm function's return type because this one only causing the problem.
Emircan Erkul → changed the visibility of the branch compatibility-fix--2.0.x to hidden.
Emircan Erkul → created an issue.
Emircan Erkul → created an issue.
Emircan Erkul → created an issue.
Emircan Erkul → created an issue.
Emircan Erkul → created an issue.
Emircan Erkul → created an issue.
Find out one of our custom modules causing this problem. Tracing that one was extremely difficult maybe impossible, found by checking and disabling things manually.
- $build['#cache']['contexts'][] = ['url', 'user'];
- $build['#cache']['tags'][] = ['user:' . $current_uid, 'group_content_list'];
+ $build['#cache']['contexts'] = array_merge($build['#cache']['contexts'], ['url', 'user']);
+ $build['#cache']['tags'] = array_merge($build['#cache']['tags'], ['user:' . $current_uid, 'group_content_list']);
In the MR, implemented a similar solution to the https://www.drupal.org/project/simple_sitemap/issues/3219894 → . Tested and ready for review.
Hi Rajab, Thanks for the review. Applied your suggestions and created MR.
emircanerkul → created an issue.
@jive01 no it will not due to jquery once. I'm attaching changes in PR as diff.
Looks like it will take some time. Until then here is the patch;
Attaching branch changes as a diff file.
#5 https://www.drupal.org/project/varbase_total_control/issues/3259139#comm... 🐛 Dashboard stopped working Active proposed solution solves the problem.
The patch works as expected.
Rajab Natshah → credited emircanerkul → .
Update: might not be related, after removing settings.local.php this error disappears. In my environment, there are problems with NullBackendFactory
emircanerkul → created an issue.
emircanerkul → created an issue.
emircanerkul → created an issue.
@eaajithe Shouldn't be there any entity update hook for existing entries?
I was trying to update entities and got an error
The SQL storage cannot change the schema for an existing field (logpath in events_logging entity) with data.
I just need that temporarily to be removed from our system flawlessly. But requiring that forces egulias/email-validator package to use 3.0.x instead of 4.0.x by
composer why egulias/email-validator
swiftmailer/swiftmailer v6.3.0 requires egulias/email-validator (^2.0|^3.1)
I'm using https://git.drupalcode.org/issue/swiftmailer-3359916/-/commits/3359916-d...
I think there is no easy way to enforce egulias/email-validator 4.0
@joey-santiago fixed within https://git.drupalcode.org/project/ckeditor_media_embed/-/merge_requests...
emircanerkul → made their first commit to this issue’s fork.