- Status changed to Needs work
11 months ago 12:39pm 21 July 2023 - 🇮🇳India roshni27
I have applied the above #7 patch. It has solved all errors except the 3 warnings indicated in the screenshot. I am working on resolving them and will upload a new patch once done.
- Status changed to Needs review
11 months ago 12:43pm 21 July 2023 - Issue was unassigned.
- First commit to issue fork.
- 🇹🇷Turkey emircanerkul Turkey
Reviewed popup_onload_statistics sub-module needs refactoring. For the main module, I did.
Here is drupal-check result.
16/16 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% ------ --------------------------------------------------------------------- Line modules/popup_onload_statistics/popup_onload_statistics.admin.inc ------ --------------------------------------------------------------------- 14 Function drupal_get_query_parameters not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 53 Function theme not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols ------ --------------------------------------------------------------------- ------ --------------------------------------------------------------------- Line modules/popup_onload_statistics/popup_onload_statistics.module ------ --------------------------------------------------------------------- 49 Function drupal_add_js not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 62 Constant MENU_CALLBACK not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 71 Constant MENU_NORMAL_ITEM not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 81 Function drupal_get_query_parameters not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 92 Function drupal_write_record not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 94 Function drupal_json_output not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols ------ --------------------------------------------------------------------- ------ --------------------------------------------------------------------- Line modules/popup_onload_statistics/popup_onload_statistics.theme.inc ------ --------------------------------------------------------------------- 35 Function l not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 42 Function theme not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols ------ --------------------------------------------------------------------- ------ --------------------------------------------------------------------------- Line popup_onload.module [FIXED] ------ --------------------------------------------------------------------------- 98 Access to constant ROUTE_OBJECT on an unknown class RouteObjectInterface. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols ------ --------------------------------------------------------------------------- ------ ------------------------------------------------------------------------------------------------------------ Line src/Form/PopupOnLoadForm.php [FIXED] ------ ------------------------------------------------------------------------------------------------------------ 76 Method Drupal\popup_onload\Form\PopupOnLoadForm::save() should return int but return statement is missing. ------ ------------------------------------------------------------------------------------------------------------ ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------- Line src/PopupOnLoadHtmlRouteProvider.php [FIXED] ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------- 46 Method Drupal\popup_onload\PopupOnLoadHtmlRouteProvider::getCollectionRoute() should return Symfony\Component\Routing\Route|null but return statement is missing. 71 Method Drupal\popup_onload\PopupOnLoadHtmlRouteProvider::getSettingsFormRoute() should return Symfony\Component\Routing\Route|null but return statement is missing. ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------- [ERROR] Found 14 errors
- Status changed to Needs work
3 months ago 9:57am 1 April 2024 - Assigned to shivam_tiwari
- Issue was unassigned.
- Status changed to Needs review
3 months ago 6:04pm 11 April 2024 - 🇮🇳India Sourav_Paul Kolkata
I've reviewed the code fixes of the module...
Now it is compatible with D10..
Attaching SS of upgrade status report for reference:
- Status changed to RTBC
10 days ago 9:09am 18 June 2024