Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 16 June 2022, almost 3 years ago
Updated 18 June 2024, 10 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

RTBC

Version

1.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇮🇳India roshni27

    I willl review it.

  • Status changed to Needs work almost 2 years ago
  • Comment almost 2 years ago →
    🇮🇳India roshni27

    I have applied the above #7 patch. It has solved all errors except the 3 warnings indicated in the screenshot. I am working on resolving them and will upload a new patch once done.

  • Status changed to Needs review almost 2 years ago
  • Issue was unassigned.
  • Comment almost 2 years ago →
    🇮🇳India roshni27

    Please review the patch.

  • Comment about 1 year ago →
    🇹🇷Turkey emircan erkul Turkey

    emircanerkul → made their first commit to this issue’s fork.

  • Comment about 1 year ago →
    🇹🇷Turkey emircan erkul Turkey

    Reviewed popup_onload_statistics sub-module needs refactoring. For the main module, I did.

    Here is drupal-check result.

    16/16 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------------------------- 
  Line   modules/popup_onload_statistics/popup_onload_statistics.admin.inc    
 ------ --------------------------------------------------------------------- 
  14     Function drupal_get_query_parameters not found.                      
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
  53     Function theme not found.                                            
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
 ------ --------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------- 
  Line   modules/popup_onload_statistics/popup_onload_statistics.module       
 ------ --------------------------------------------------------------------- 
  49     Function drupal_add_js not found.                                    
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
  62     Constant MENU_CALLBACK not found.                                    
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
  71     Constant MENU_NORMAL_ITEM not found.                                 
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
  81     Function drupal_get_query_parameters not found.                      
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
  92     Function drupal_write_record not found.                              
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
  94     Function drupal_json_output not found.                               
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
 ------ --------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------- 
  Line   modules/popup_onload_statistics/popup_onload_statistics.theme.inc    
 ------ --------------------------------------------------------------------- 
  35     Function l not found.                                                
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
  42     Function theme not found.                                            
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
 ------ --------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------- 
  Line   popup_onload.module      [FIXED]                                                  
 ------ --------------------------------------------------------------------------- 
  98     Access to constant ROUTE_OBJECT on an unknown class RouteObjectInterface.  
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols        
 ------ --------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------ 
  Line   src/Form/PopupOnLoadForm.php   [FIXED]                                                                                   
 ------ ------------------------------------------------------------------------------------------------------------ 
  76     Method Drupal\popup_onload\Form\PopupOnLoadForm::save() should return int but return statement is missing.  
 ------ ------------------------------------------------------------------------------------------------------------ 

 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/PopupOnLoadHtmlRouteProvider.php   [FIXED]                                                                                                                              
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  46     Method Drupal\popup_onload\PopupOnLoadHtmlRouteProvider::getCollectionRoute() should return Symfony\Component\Routing\Route|null but return statement is missing.    
  71     Method Drupal\popup_onload\PopupOnLoadHtmlRouteProvider::getSettingsFormRoute() should return Symfony\Component\Routing\Route|null but return statement is missing.  
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 [ERROR] Found 14 errors
  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇹🇷Turkey emircan erkul Turkey
  • Comment about 1 year ago →
    🇹🇷Turkey emircan erkul Turkey
  • Assigned to shivam_tiwari
  • Comment about 1 year ago →
    🇮🇳India shivam_tiwari
  • Merge request !2Resolve #3289115 "Drupal 10" → (Open) created by shivam_tiwari
  • Issue was unassigned.
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India shivam_tiwari
  • Comment 11 months ago →
    🇮🇳India sourav_paul Kolkata

    I've reviewed the code fixes of the module...

    Now it is compatible with D10..

    Attaching SS of upgrade status report for reference:

  • Status changed to RTBC 10 months ago
  • Comment 10 months ago →
    🇮🇳India sourav_paul Kolkata
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024