- Issue created by @emircan erkul
- Merge request !203OrderRefresh better unlocked order handling via lockBackend service → (Open) created by emircan erkul
- last update
11 months ago 783 pass, 4 fail - Issue was unassigned.
- Status changed to Needs review
11 months ago 1:05pm 13 December 2023 - Status changed to Closed: won't fix
11 months ago 3:07pm 13 December 2023 - 🇹🇷Turkey emircan erkul Turkey
At least, Why @jsacksick
I checked Pipelines, it says `few arguments to function Drupal\commerce_order\OrderRefresh::__construct(), 4 passed` But actually i already but the 5th one and its there. There should some cache etc in the pipeline isn't it?
- 🇮🇱Israel jsacksick
@emircanerkul: You're opening an issue without describing what issue you are trying to solve? How am I supposed to know what this is about?
- last update
11 months ago 784 pass, 2 fail - 🇹🇷Turkey emircan erkul Turkey
@jsacksick, sorry my bad. I thought the title would be enough to describe the problem. Details are updated.
- Status changed to Active
11 months ago 11:49am 18 December 2023 - 🇮🇱Israel jsacksick
Retitling for clarity...
I think if we do this we should rely on the order storage... As we shouldn't hardcode the lock ID in multiple places...So perhaps we need an
isLockedForSave()
method on the order storage but I'm a bit reluctant to commit this as this change will probably impact performance...
Also I believe we should negate the call?
Instead of$this->lockBackend->lockMayBeAvailable()
we probably need!$this->lockBackend->lockMayBeAvailable()
no? - last update
11 months ago 783 pass, 3 fail - 🇹🇷Turkey emircan erkul Turkey
I agree, it needs some refactoring to prevent hardcoding lock ID in multiple places.
Yes, it definitely affects performance but this is the Drupal way of locking. IDK maybe we need to switch commerce's locking system to that.
Regarding negating, yes you're right [done]. But the naming is weird, Instead of lockMayBeAvailable, I would prefer isLockable.
- 🇮🇱Israel jsacksick
But the naming is weird, Instead of lockMayBeAvailable, I would prefer isLockable.
This is a Drupal core melthod, not Commerce method...