- Issue created by @Rajab Natshah
- Merge request !10Issue #3393693: Add Drush 12 compatibility for custom CKEditor Media Embed Plugin commands โ (Merged) created by Rajab Natshah
- Merge request !11Issue #3393693: Add Drush 12 compatibility for custom CKEditor Media Embed Plugin commands โ (Merged) created by Rajab Natshah
- Status changed to Needs review
about 1 year ago 4:36pm 12 October 2023 - ๐ฏ๐ดJordan Rajab Natshah Jordan
Attached a static patch file for both diffs on both branches
- ๐บ๐ธUnited States amanire
Yes!! Thank you Rajab Natshah! The patch in #5 applied and resolved the error for me on 8.x-1.12 with Drush 12.4.0.0.
I can't confirm the 2.x branch so leaving this status as "Needs review".
- ๐บ๐ธUnited States mlncn Minneapolis, MN, USA
Unless i restored the `drush.services.yml` file, Drush was not seeing the commandsโ
> There are no commands defined in the "ckeditor_media_embed" namespace.
Using "Drush Commandline Tool 12.4.2.0"
Thought โจ CKEditor 5 support? Needs review was to blame at first but was this patch. This patch, mind you, is necessary for Drush to run at all, but essentially i needed to remove the part of the patch that removes the drush services file for the commands to show for me.
With the attached patch i was able to download `ckeditor5/plugins/media-embed` to my libraries folder. (We shall leave the rant about Drupal not having one single universal system for JavaScript dependencies implied.)
- ๐บ๐ธUnited States ElusiveMind Nashville, TN
Regarding Merge Request 10:
The drush.services.yml file should not be deleted. Removing it causes the drush commands to not be seen.
- Status changed to Needs work
about 1 year ago 8:51am 26 November 2023 -
ElusiveMind โ
committed 92a7bfa8 on 2.x authored by
mlncn โ
Issue #3393693 by mlncn: Add Drush 12 compatibility for custom CKEditor...
-
ElusiveMind โ
committed 92a7bfa8 on 2.x authored by
mlncn โ
-
ElusiveMind โ
committed 1c8921c6 on 2.x authored by
mlncn โ
Issue #3393693 by mlncn: Add Drush 12 compatibility for custom CKEditor...
-
ElusiveMind โ
committed 1c8921c6 on 2.x authored by
mlncn โ
- Status changed to RTBC
about 1 year ago 8:56am 26 November 2023 - ๐บ๐ธUnited States ElusiveMind Nashville, TN
Patch 10 seems to work - Merged to dev.
- ๐ซ๐ฎFinland joey-santiago
Using dev, but i'm still getting the same error:
You have requested a non-existent parameter "ckeditor_media_embed_install".
and i still have the file drush.services.yml, wasn't it supposed to be removed?
- ๐น๐ทTurkey emircan erkul Turkey
emircanerkul โ made their first commit to this issueโs fork.
- ๐น๐ทTurkey emircan erkul Turkey
@joey-santiago fixed within https://git.drupalcode.org/project/ckeditor_media_embed/-/merge_requests...
- ๐บ๐ฆUkraine i-trokhanenko Lutsk ๐บ๐ฆ
The MR#11 works well for me on 8.x-1.12. Thanks!
-
ElusiveMind โ
committed a39b2c86 on 8.x-1.x authored by
Rajab Natshah โ
Issue #3393693: Add Drush 12 compatibility for custom CKEditor Media...
-
ElusiveMind โ
committed a39b2c86 on 8.x-1.x authored by
Rajab Natshah โ
-
ElusiveMind โ
committed 13807401 on 2.x authored by
Rajab Natshah โ
Issue #3393693: Add Drush 12 compatibility for custom CKEditor Media...
-
ElusiveMind โ
committed 13807401 on 2.x authored by
Rajab Natshah โ
- ๐ฆ๐นAustria mvonfrie
Using 2.0.1 on Drupal 10.2.5 and Drush 12.5.1.0, MR !11 breaks the functionality as described in #11 and #16.
I don't re-open because this already gets fixed by ๐ There are no commands defined in the "ckeditor_media_embed" namespace. Needs review