Add Drush 12 compatibility for custom CKEditor Media Embed Plugin commands

Attached a static patch file for both diffs on both branches

Yes!! Thank you Rajab Natshah! The patch in #5 applied and resolved the error for me on 8.x-1.12 with Drush 12.4.0.0.

I can't confirm the 2.x branch so leaving this status as "Needs review".

Re-writing the #5patch for updated code.

Unless i restored the `drush.services.yml` file, Drush was not seeing the commands—

> There are no commands defined in the "ckeditor_media_embed" namespace.

Using "Drush Commandline Tool 12.4.2.0"

Thought ✨ CKEditor 5 support? Needs review was to blame at first but was this patch. This patch, mind you, is necessary for Drush to run at all, but essentially i needed to remove the part of the patch that removes the drush services file for the commands to show for me.

With the attached patch i was able to download `ckeditor5/plugins/media-embed` to my libraries folder. (We shall leave the rant about Drupal not having one single universal system for JavaScript dependencies implied.)

Regarding Merge Request 10:

The drush.services.yml file should not be deleted. Removing it causes the drush commands to not be seen.

Patch 10 seems to work - Merged to dev.

Using dev, but i'm still getting the same error:

  You have requested a non-existent parameter "ckeditor_media_embed_install".  

and i still have the file drush.services.yml, wasn't it supposed to be removed?

emircanerkul → made their first commit to this issue’s fork.

@joey-santiago fixed within https://git.drupalcode.org/project/ckeditor_media_embed/-/merge_requests...

The MR#11 works well for me on 8.x-1.12. Thanks!

Using 2.0.1 on Drupal 10.2.5 and Drush 12.5.1.0, MR !11 breaks the functionality as described in #11 and #16.

I don't re-open because this already gets fixed by 🐛 There are no commands defined in the "ckeditor_media_embed" namespace. Needs review

Automatically closed - issue fixed for 2 weeks with no activity.