🇫🇮Finland @joey-santiago

joey-santiago → created an issue.

Fixed!

joey-santiago → created an issue.

joey-santiago → created an issue.

joey-santiago → created an issue.

Branch removed. It was only a stale branch, that likely was created by default on gitlab?

https://git.drupalcode.org/project/pathauto/-/branches

anyhow, i removed it.

joey-santiago → created an issue.

vermario → credited joey-santiago → .

joey-santiago → created an issue.

oh thanks! and sorry i missed your comment.

Absolutely, you're right. I created the ticket for myself to remember doing something and i haven't explained correctly the issue.

I'll fix the description :)

Thank you! Fixed those issues and also did the jump to d11.

That service that has static methods in it is mostly used for batch processing and so on, so i don't think it would make sense splitting it.

joey-santiago → created an issue.

joey-santiago → created an issue.

joey-santiago → made their first commit to this issue’s fork.

joey-santiago → created an issue.

mhm. We're actually not doing anything, the allowed roles is a reference field that we're not touching at all, apart from creating it. We have nothing in code that would alter the order of the roles there.

joey-santiago → created an issue.

Thank you very much for your review.

https://git.drupalcode.org/issue/access_by_taxonomy-3469105

i had already created this fork for working on the security fixes, so i went on on that. We'll merge that to the main branch soon.

I tackled all your points. Indeed many of them recurred in many places, but luckily our codebase is not too big to go through.

joey-santiago → created an issue.

Fixed! Thank you Mario for helping out and for the good diff idea!

joey-santiago → created an issue.

Thank you very much! :) let's hope!

Thank you very much. Code updated.

I forgot to mention: if you go to our project code: https://git.drupalcode.org/project/access_by_taxonomy you'll see we have pipelines enabled, and everything is green.

joey-santiago → created an issue.

joey-santiago → created an issue.

joey-santiago → created an issue.

Working on this, we realized quite many things:

• "view own unpublished" permission needed some special grant
• "edit any CONTENT_TYPE content" permission needed some special grant

Doing this, we are writing a ton of tests.

joey-santiago → created an issue.

joey-santiago → created an issue.

joey-santiago → created an issue.

joey-santiago → created an issue.

joey-santiago → created an issue.

I tried following this, but i can't find a way to make it work. How should one add a field to an entity using the install hook?

function example_add_field_update_10003 () {
  $field_storage_definition = BaseFieldDefinition::create('entity_reference')
    ->setLabel(t('Allowed users'))
    ->setDescription(t('Users who are allowed to access content related to this taxonomy term.'))
    ->setSetting('target_type', 'user')
    ->setCardinality(BaseFieldDefinition::CARDINALITY_UNLIMITED)
    ->setSetting('handler', 'default')
    ->setSetting('handler_settings', [
      'target_bundles' => [],
      'sort' => [
        'field' => 'name',
        'direction' => 'asc',
      ],
      'auto_create' => FALSE,
      'include_anonymous' => TRUE,
    ])
    ->setTranslatable(FALSE)
    ->setName('field_allowed_users')
    ->setDisplayConfigurable('form', TRUE)
    ->setDisplayOptions('form', [
            'type' => 'entity_reference_autocomplete',
            'weight' => 10,
          ])
    ->setRevisionable(FALSE);

  \Drupal::entityDefinitionUpdateManager()
    ->installFieldStorageDefinition('field_allowed_users', 'taxonomy_term', 'example_add_field', $field_storage_definition);
  $entity_type = \Drupal::service('entity_type.manager')->getDefinition('taxonomy_term');
  \Drupal::entityDefinitionUpdateManager()->updateEntityType($entity_type);
}

This seem to add a couple tables to Drupal, but then i cannot find the field on the taxonomy term form, neither in the form display settings. I'm afraid this is missing something?

joey-santiago → created an issue.

joey-santiago → created an issue.

Using dev, but i'm still getting the same error:

  You have requested a non-existent parameter "ckeditor_media_embed_install".  

and i still have the file drush.services.yml, wasn't it supposed to be removed?

Had a look at this with @vermario.

We tried to understand how to do it and ended up with the idea that we should add a sorting function in the core/lib/Drupal/Core/Render/Element/Radios.php class.

Somehow the *template_preprocess_radios* function gets the options in $variables['children'], while we would have expected to have $variables['options'] there. We haven't fully understood how those children are built.

Confirm this is now working!

Hello,
i'd be very interested in this as well. Haven't actually understood what is needed in order to expose documentation to swagger. If i got it well, one can expose endpoints following what has been done in projects like openapi_rest (/src/Plugin/openapi/OpenApiGenerator/RestGenerator.php), but i have no idea how a view that has a rest export display could hook into that system...

The patch #21 seems to work fine for me. Also the --code parameter seems to work fine.

I also got here looking for the bug mentioned in #150: when an unpublished translation of a node is saved, the entry for that is removed from the taxonomy_index table.
In my case, the module Permissions by Term is using the taxonomy_index table to gather all the nodes a user is entitled to view. So suddenly nodes are removed from listings when unpublished translations are saved.

From what i have tested, the patch works well. I especially like the fact that the database is updated putting back in place all the entries from unpublished nodes. The patch applies #198 to 10.1 too.

Agree with #26...

In my case, the error is thrown in a view that is embedded in a webform. The view arguments are passed by ajax and come from an element that is on the same page of the view. So in some conditions the view gets NULL being passed as an argument. In this case, somehow NULL gets to the operator. Implemented the suggestion suggested in #26 and it seems to work fine.

joey-santiago → created an issue.

Here are some more tests. I really think @peter-majmesku some effort should be put into making the module reliable with multilanguage installs.
I had a bit of troubles understanding how the permission_mode should work, but i hope i got it right.

thanks

Reworked the patch and confirmed tests are now passing. I plan on adding a couple tests for the case that we noticed failing, it will come next week.

Coming back to this. We noticed that the patch works indeed for that case, but doesn't cover this:

• node with specific permissions set is created and published
• unpublished translation is created

in this case the patch only sets the default access, thus opening the node's permissions. Working on a fix.

This also has to do with this issue i created last year. Maybe we can work at this together?

https://www.drupal.org/project/permissions_by_term/issues/3308318 🐛 Access for node is removed when an unpublished translation is added Needs review

Whit the patch you find there something works better, but we just found out other things are still broken. For example if you add a restriction for a node, then you create an unpublished translation, then everything becomes accessible.

Maybe this issue here should be marked as duplicated and we should join forces?

Yes i think there have been some iterations of this module, to be honest i have a very bad memory so i'm not 100% sure where we landed, but i think the problem we faced deleting completely a user was with the revisions table. If i'm not mistaken, deleting a user that had entries in the revisions table was causing some troubles and in the end we thought that was meaningful information, so we decided to disable the old user instead of deleting it completely.

joey-santiago → created an issue.

Fixed an issue: if the search_on setting is used, then calls to the matcher cause 5xx errors. Now the code uses the search_on for users only.

Thank you so much for the patch @jmaerckaert!

i hope i managed to credit you for the commit. I created an issue fork and a Merge Request for it.

have a good day

joey-santiago → made their first commit to this issue’s fork.

joey-santiago → created an issue.

This was easy enough!

joey-santiago → created an issue.

quietone → credited joey-santiago → .