Port drush add-redirect command to D8

Created on 14 March 2019, almost 6 years ago
Updated 13 September 2024, 6 months ago
📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

🇺🇸United States charginghawk

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & SQLite 3.27
    last update almost 2 years ago
    63 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update almost 2 years ago
    62 pass, 2 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update almost 2 years ago
    63 pass
  • 🇲🇦Morocco Oussama OUDRHIRI

    Using this patch "drush_create_redirect-3040413-20.patch"

    this command : drush redirect-create '/test' 'test-redirected' --code=301
    =>returns this error message : "The "--code" option does not accept a value."
    the same command with no "--code" option: drush redirect-create '/test/1' 'test-redirected/1'
    =>set's the status_code to "NULL" in the database and when editing from the Back Office the changes are not persisted

    Issue: the options are not taken into consideration.
    Fix => I have updated the constructor to add the default spec.

    Note: also fixed some SonarLint warnings

  • 🇫🇮Finland joey-santiago

    The patch #21 seems to work fine for me. Also the --code parameter seems to work fine.

  • Status changed to RTBC over 1 year ago
  • Status changed to Needs review about 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    63 pass
  • 🇲🇦Morocco Oussama OUDRHIRI

    When creating redirects in large quantities, we frequently encounter situations where certain source paths are already being redirected. In Patch #21, an exception is raised specifically for this scenario. However, when the redirect is successfully saved, no information is displayed in the terminal.

    In Patch #24:

    • Replaced the usage of "$this->logger()->info()" with "$this->logger()->success()" for terminal output.
    • Introduced an update option with the "--update" flag for the "redirect-create" command, allowing the modification of the destination and code for an existing redirect.
    • Implemented a new command "redirect-update" exclusively designed for updating redirects, with filtering based on source path and language.
  • Status changed to Needs work 7 months ago
  • 🇨🇭Switzerland berdir Switzerland

    This needs to be a merge request now and .drush.inc shouldn't be touched, no need to add that anymore.

  • First commit to issue fork.
  • Pipeline finished with Success
    6 months ago
    Total: 214s
    #280747
  • Pipeline finished with Success
    6 months ago
    Total: 278s
    #280771
  • Pipeline finished with Success
    6 months ago
    Total: 185s
    #281820
  • Pipeline finished with Success
    6 months ago
    Total: 184s
    #281823
  • Status changed to Needs review 6 months ago
  • Pipeline finished with Canceled
    6 months ago
    Total: 266s
    #281830
  • Pipeline finished with Success
    6 months ago
    Total: 184s
    #281833
  • Pipeline finished with Success
    6 months ago
    #281839
Production build 0.71.5 2024