🇬🇧United Kingdom @malcomio

Having tested Country a little, it doesn't directly provide the filtering functionality - that comes from Select2 Boxes → , which doesn't have a stable release.

So for our use case, I think we will:

1. Use the Chosen module →
2. Apply it to the existing select field - this could be done in a form alter, but I'd started investigating integration with the phone_number module, so I started MR34 - that patch makes it work, although ideally the change would declare dependencies etc.

I think that there was some confusion around this issue.

The patch on #4 and #5 is actually for the Phone Number (field) module → .

The issue should have been raised for that module in the first place.

If we check that $query exists before trying to call getSearchId on it, we get the message "Cannot search on a disabled index." as expected.

See https://git.drupalcode.org/project/search_api/-/merge_requests/219

malcomio → created an issue.

malcomio → created an issue.

One example where we found that this patch was needed was when a user selected India, then entered "999" as the phone number, they did not see any error message.

The function in the library is documented at https://github.com/giggsey/libphonenumber-for-php/blob/master/src/PhoneN... - there aren't many examples in the tests there, but one is +33 6 76 83 51 85 for Germany

Need to test further, but seems to work, based on similar changes in other modules, e.g. https://git.drupalcode.org/project/menu_breadcrumb/-/merge_requests/27/d... for 🐛 Missing route cachability metadata. Active

malcomio → made their first commit to this issue’s fork.

The patch on 🐛 Compatibility with Flag 8.x-4.0-beta6 Active solved the problem for us.

The patch fixes the issue for us.

Thanks for sharing the patch - a merge request would be good - see https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

Also, if this needs to be reviewed by the maintainers, then the status should be "Needs Review" - see https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-... →

I found this issue after investigating 🐛 Ajax link flag does not work in view with ajax enabled. Closed: outdated - will test whether the patch solves our problem.

malcomio → made their first commit to this issue’s fork.

Looking at the difference between beta5 and beta6, one significant difference seems to be the changes in flag.routing.yml

Having updated from 8.x-4.0-beta5 to 8.x-4.0-beta6, we've started seeing this.

We do have a patch applied for ✨ Allow AjaxResponse to be altered RTBC - possibly related?

It may also be worth adding extra logging, similar to 📌 Introduce debug mode - do not pollute indexing output with Tika warnings Active .

For example, if debug mode is on, the extractor could:

1. log details of the file before it tries to do the extraction
2. report success or failure

Possibly related to the following issues on older branches:

#2474849: Ignore attachments based on uri, filesize or file extension →
🐛 Request Entity Too Large Closed: cannot reproduce

Perhaps the way forward would be to limit extraction by file size.

There is a config option in the schema, and this is configurable via the Search API processors form.

We saw the error with the following config:

  file_attachments:
    excluded_extensions: 'aif art avi bmp gif ico mov oga ogv png psd ra ram rgb flv'
    number_indexed: 0
    number_first_bytes: '1 MB'
    max_filesize: '0'
    excluded_private: 1
    excluded_mimes: 'audio/x-aiff image/x-jg video/x-msvideo image/x-ms-bmp image/gif image/vnd.microsoft.icon video/quicktime audio/ogg video/ogg image/png image/x-photoshop audio/x-realaudio audio/x-pn-realaudio image/x-rgb video/x-flv'
 

Perhaps we need to try changing these settings?

For anyone who is having this problem when trying to edit non-markdown formats, there is a workaround:

1. delete the markdown filter format: drush cdel filter.format.markdown
2, uninstall the markdown module: drush pmu markdown
3. clear cache: drush cr
4. re-enable markdown: drush en markdown
5. re-create the markdown format

Rather than uploading a zip with a set of instructions, ideally we would update the main instructions.

Also, see 🐛 Required PDF.js library is not installed when using composer RTBC for a suggested improvement to the installation process.

malcomio → created an issue.

malcomio → created an issue.

This will be covered in 📌 Drupal 11 Compatibility Fixes Active .

@aesuk - this module serves a different purpose to search_api_algolia, as far as I can see.

It may make sense to create a feature request on that module to include the interface, but I think it probably makes sense to keep them separate.

This will be handled in the 1.1.x branch - see 📌 Automated Drupal 10 compatibility fixes Needs review

malcomio → created an issue.

malcomio → created an issue.

Hello, has there been any update? I'm still interested in maintaining this module.

Thanks

Possibly related to 🐛 Parameter "arg_0" must match "[^/]++" Needs work and 💬 Views UI - Parameter "view" for route "entity.view.edit_form" must match "[^/]++ Closed: works as designed

Possibly related to #3176422: Parameter "x" for route "x" must match ".+" → and 💬 Views UI - Parameter "view" for route "entity.view.edit_form" must match "[^/]++ Closed: works as designed

malcomio → created an issue.

I had observed the same error when trying to add a second dependency:

1. Field 2 is required if field 1 has value X
2. Field 3 is visible if field 2 has value Y

This is not quite the same scenario as the original description, but very similar.

After applying the patch, I got the following error:

TypeError: Drupal\conditional_fields\ConditionalFieldsFormHelper::addStateToGroup(): Argument #1 ($new_states) must be of type array, null given, called in /var/www/html/docroot/modules/contrib/conditional_fields/src/ConditionalFieldsFormHelper.php on line 276 in Drupal\conditional_fields\ConditionalFieldsFormHelper->addStateToGroup() (line 478 of modules/contrib/conditional_fields/src/ConditionalFieldsFormHelper.php).
Drupal\conditional_fields\ConditionalFieldsFormHelper->processDependeeFields(Array, Array, Array, Array, '') (Line: 154)
Drupal\conditional_fields\ConditionalFieldsFormHelper->processDependentFields() (Line: 108)
Drupal\conditional_fields\ConditionalFieldsFormHelper->afterBuild(Array, Object) (Line: 184)
conditional_fields_form_after_build(Array, Object)
call_user_func_array('conditional_fields_form_after_build', Array) (Line: 1082)
Drupal\Core\Form\FormBuilder->doBuildForm('node_document_edit_form', Array, Object) (Line: 579)
Drupal\Core\Form\FormBuilder->processForm('node_document_edit_form', Array, Object) (Line: 326)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 591)
Drupal\conditional_fields\Form\ConditionalFieldEditForm->getDummyField('node', 'document', Array, Object, Array) (Line: 153)
Drupal\conditional_fields\Form\ConditionalFieldEditForm->buildForm(Array, Object, 'node', 'document', 'field_lawful_basis', 'ade41c73-6578-4e92-ad0a-514a0cbc7d6d')
call_user_func_array(Array, Array) (Line: 536)
Drupal\Core\Form\FormBuilder->retrieveForm('conditional_field_edit_form', Object) (Line: 284)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 741)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

malcomio → made their first commit to this issue’s fork.

malcomio → created an issue.

See 🐛 Nested field groups improperly display as "Disable" in the admin UI Active for details of an issue affecting the field_group module - the core patch seems to fix that for me.

@jsimonis - how are you applying the patch, and what are the failures that you see when trying to apply the patch?

https://vazcell.com/blog/how-apply-patch-drupal-9-and-drupal-10-composer is a good explanation of how to do this.

The patch from 🐛 TableDrag JS :first-of-type issues Needs work seems to work for me too.

https://www.drupal.org/files/issues/2023-12-26/3089151-51.patch →

@asghar rather than uploading patches, it's better to create merge requests.

See https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... → for more info.

Seems that this line was added in #2731283: Display configuration overrides in the settings form → , but it's never had any conditional logic around it.

malcomio → created an issue.

malcomio → created an issue.

It seems like the Search UI App documentation at https://www.searchstax.com/docs/searchstudio/searchstax-studio-searchjs-... may be incomplete or out of date - I wasn't able to get that code working.

However, from within the SearchStax interface, at https://searchstudio.searchstax.com/search-ui/app there's a Search Experience Template URL section, which links to a sample page.

Based on that JavaScript I've got something basic working.

malcomio → created an issue.

I've observed this in the following scenario:

On a site running Drupal core 10.4.1, our local build process imports a sanitised database backup, which does not contain any field_deleted_data tables.

After the import it runs the update hooks.
One of our update hooks calls \Drupal::service('module_installer')->uninstall() to uninstall a custom module.

That module's hook_uninstall implementation has an array of taxonomy vocabulary names, and deletes them in a loop:

foreach ($taxonomy as $vid) {
  $vocabulary = Vocabulary::load($vid);
  $vocabulary?->delete();
}

The exception is thrown as part of this.

The strange thing is that this doesn't seem to be happening on our test environments, which use MySQL 5.7.40-log, or on local development machines using Windows, where we also use MySQL 5.7.

The problem only seems to be reproducible on my M1 Mac, where I'm using mysql 8.0.38.

The difference is because there didn't seem to be an ARM compatible Docker image of 5.7 when I was setting up.

But this may be a clue to what is triggering the problem - is it only reproducible on MySQL 8?

The patch from #44 didn't seem to make any difference to my problem.

Have tried contacting asgorobets to offer to maintain https://www.drupal.org/project/watchdog_file → , but no reply so far.

@suryabhi I don't think that those exceptions relate to this module, and I don't see why we would need the change you're suggesting in merge request 21.

I think the appropriate status for this issue is probably "Fixed"

See https://git.drupalcode.org/project/ai/-/merge_requests/415

malcomio → created an issue.

Thanks - have fixed that: https://git.drupalcode.org/issue/editoria11y-3500148/-/pipelines/397446

malcomio → created an issue.

This change seems to cause problems with existing filters that have markdown enabled.

If an update hook in another module tries to make changes to permissions as part of the same deployment where search_api_exclude_entity is being upgraded, there's no way to ensure that the other hook runs after search_api_exclude_entity has updated the permissions.

That means that the permission change in the other module fails, because the outdated search_api_exclude_entity permissions are still assigned to some roles.

By using an update hook in search_api_exclude_entity, the custom module can declare a dependency on it.

malcomio → created an issue.

Odd - the test failures relate to PHP code sniffer issues in files that aren't being changed - this change is only a CSS change.

Have merged 2.x into this branch and pushed.

Setting to "needs review", given that there are patches attached.

Have created a merge request based on the combination of the patches, although I'm not entirely convinced by the return statements inside the catch blocks.

I haven't been able to reproduce this, but wanted to see if this would address 🐛 Error when saving text format - configuration property id doesn't exist Active .

malcomio → made their first commit to this issue’s fork.

Have created MR 39 based on patch #14

@jonathan_hunt I'm unable to reproduce the fatal error you mention, although in our installation we have patches applied for the following issues:

#3226069: Allow "incompatible" filters to be enabled (but validate that they appear after Markdown) →
🐛 After each cache clear, visiting a page filtered with markdown causes calls to pecl.php.net; it is not clear why we are doing this Active
✨ Add support for Commonmark v2 Active
🐛 Subformstate incorrect interface error Active
🐛 Error when saving text format - configuration property id doesn't exist Active
🐛 Unable to save text format without enabling Markdown filter Active

With the latest changes in the merge request, this seems to be working as expected.

I think that this may be a side effect of the patch that we're using for ✨ Add support for Commonmark v2 Active - the plugins that seem to be causing this problem are all related to CommonMark.

Ideally we'd address the problem that causes these plugins to be missing an id, rather than just deleting them altogether.

malcomio → made their first commit to this issue’s fork.

I think that this may be related to ✨ Add support for Commonmark v2 Active - see comment #14 there

malcomio → made their first commit to this issue’s fork.

Here's how it looks:

malcomio → made their first commit to this issue’s fork.

malcomio → created an issue.

Having applied this patch and the patch from 🐛 Deprecated FormElement Active , upgrade status reports the following:

drush us-a phone_number

================================================================================
Phone Number,  2.0.0-alpha7
Scanned on Mon, 9 Dec 2024 - 17:09

FILE:
modules/contrib/phone_number/modules/sms_phone_number/src/Element/SmsPhoneNumber
.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 103  The 'sms_phone_number/element' library is not defined       
                    because the defining extension is not installed. Cannot     
                    decide if it is deprecated or not.                          
--------------------------------------------------------------------------------

The patch applies cleanly, and addresses the issue.

Yes we're also seeing the same error - I don't think the issue should have been set to Needs Review.

Have marked the merge request as draft.

We've tested the change in merge request 81, and it seems to work as expected.

malcomio → created an issue.

See also https://github.com/advisories/GHSA-jw86-5cjf-mv79

HTML Purifier 4.2.0 allows remote attackers to obtain sensitive information via a direct request to a .php file

According to upgrade_status, there are the following issues to be addressed:

drush upgrade_status:analyze cache_browser
 [notice] Processing /var/www/app/docroot/modules/contrib/cache_browser.

================================================================================
Cache browser,  1.0.0
Scanned on Thu, 21 Nov 2024 - 17:23

FILE: modules/contrib/cache_browser/src/Controller/OverviewController.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 168  Call to deprecated function format_size(). Deprecated in    
                    drupal:10.2.0 and is removed from drupal:11.0.0. Use        
                    Drupal\Core\StringTranslation\ByteSizeMarkup::create($size, 
                    $langcode) instead.                                         
--------------------------------------------------------------------------------

FILE: modules/contrib/cache_browser/src/Services/CacheBinCollectionFactory.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 13   Class                                                       
                    Drupal\cache_browser\Services\CacheBinCollectionFactory     
                    implements deprecated interface                             
                    Symfony\Component\DependencyInjection\ContainerAwareInterfac
                    e: since Symfony 6.4, use dependency injection instead      
--------------------------------------------------------------------------------
Check manually 15   Usage of deprecated trait                                   
                    Symfony\Component\DependencyInjection\ContainerAwareTrait in
                    class                                                       
                    Drupal\cache_browser\Services\CacheBinCollectionFactory:    
                    since Symfony 6.4, use dependency injection instead         
--------------------------------------------------------------------------------

FILE: modules/contrib/cache_browser/cache_browser.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 4    Value of core_version_requirement: ^10 is not compatible    
                    with the next major version of Drupal core. See             
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

This change seems to fix the problem as far as I can see.

I've seen different approaches in some other modules though:

https://git.drupalcode.org/project/digital_signage_framework/-/commit/c4...
https://git.drupalcode.org/project/do_username/-/merge_requests/13/diffs

I guess that the good thing about this approach is that it is backwards compatible

Have created MR 35

There isn't a merge request or a patch, so the status shouldn't be Needs review.

The fork does have some change in it.

Should this have been closed as outdated?

There's still a spaceless tag in https://git.drupalcode.org/project/flag/-/blob/8.x-4.x/templates/flag.ht..., and a scan with Upgrade Status → reports incompatibility with Drupal 11 in themes that have templates based on it.

See also 💬 Spaceless Tag Issue Fixed

malcomio → created an issue.

I noticed that the commonmark-external-links plugin is marked as deprecated.

This annotation was committed for #3142418: Support multiple libraries per plugin → .

I tried deleting it, and clearing the cache, but got the same error for commonmark-heading-permalink (which isn't marked as deprecated.

See also 📌 Update to jQuery UI 1.14.0 Fixed for core.

malcomio → created an issue.

I appreciate that this is likely to be a major shift in the way that the module works, and it may be more appropriate to manage this use case in a different module.