The patch didn't apply for some reason, but I've taken the changes and added them to https://git.drupalcode.org/project/credential_mask/-/merge_requests/1
malcomio → made their first commit to this issue’s fork.
Seems like this might be a duplicate of 🐛 Avoid Translating Logged Messages in Cloudflare Module to Prevent Fatal Error Active
Having debugged further, the problem is that AddressFormatConstraintValidator does not always
In my case the administrativeArea and dependentLocality field have no labels, so the violation doesn't specify them properly.
This error comes from the address module's AddressFormatConstraint, so possibly that module is the source of the error?
In our case, I think that this is coming from the smart date module - I've created 🐛 InvalidArgumentException when min and max values contain special characters Active for it.
However, it probably makes sense to keep this open to address the uncaught exception in DateTimeIso8601::getDateTime - not sure what the steps to reproduce would be for that though.
We've seen this occasionally in production on Acquia Cloud Next, with no obviously related errors in the logs around the time that the problem started.
We did try adding $settings['file_assets_path'] = 'sites/default/files';, but we have observed the problem since then.
The caching issues should be addressed by the latest commit in the merge request: https://git.drupalcode.org/project/sitewide_alert/-/merge_requests/65/di...
joseph.olstad → credited malcomio → .
Patch 75 no longer applies for 10.5.x - I've re-rolled it in https://git.drupalcode.org/project/drupal/-/merge_requests/12956/diffs and attached an updated patch.
malcomio → made their first commit to this issue’s fork.
Setting to Needs Review, as the merge request for 💬 Create new revision - Default to on option Active addresses the problem.
If I manually edit the exported config to remove the content dependency, this error does not occur.
This seems to be specific to block config based on search components - the actual components are imported correctly.
Inside \Drupal\Component\Plugin\Discovery\DiscoveryTrait::doGetDefinition I can see that a definition has been registered as coveo_search_component, but the value of $plugin_id does not match - e.g. in my case it is coveo.search_component.content
The merge requests for 💬 412 Precondition Failed Active and ✨ Provide a standalone search box Active add documentation that explains how to set up search components.
malcomio → created an issue.
https://git.drupalcode.org/project/coveo/-/merge_requests/4/diffs includes an update to the theme suggestions and the README to enable you to create extra components with custom templates.
malcomio → created an issue.
Having created a Search Component at /admin/config/search/coveo/search_components, a block became available in the block layout page with the same name as the search component.
However, when viewing the block on the front end, I'm seeing a 403 error from /rest/search/v2?organizationId={orgID} and a 400 from /rest/v15/analytics/custom?visitor={visitorID}
malcomio → created an issue.
malcomio → created an issue.
This was happening because I hadn't configured the Source ID for the organization - after adding that, I was able to index content.
The documentation should be updated to explain about adding an organization in Drupal.
malcomio → created an issue.
When trying to request the URL, it responds with 401 UNAUTHORIZED: "Full authentication is required to access this resource"
The module should catch the exception and provide an appropriate error message.
malcomio → created an issue.
Possibly related to the changes made for #3261638: Remove SitewideAlertStorage class, the code is unused → ?
malcomio → created an issue.
Having looked at the code, this doesn't seem to be configurable - work in progress in https://git.drupalcode.org/project/sitewide_alert/-/merge_requests/75
malcomio → made their first commit to this issue’s fork.
malcomio → created an issue.
In our case, this does seem to be caused by views_cm_current_state - I've created 🐛 Error when sorting views by moderation state Active and will create a merge request with a proposed fix.
malcomio → created an issue.
See also 🐛 Save content in workspace stage environment make __construct() error Active , where the proposed change is the same
This is a duplicate of 🐛 Incompatible with workspaces module Active
I've pushed a change in the branch that handles this scenario, but I think that the real problem is that the module does not implement hook_user_cancel - see 📌 Implement hook_user_cancel Active
malcomio → created an issue.
One factor that may be relevant is that @suryabhi and I work on a project which previously used the 2.x branch of the module and has been updated to use the 3.x branch.
I've been able to reproduce this issue when trying to edit an old alert, but it doesn't seem to happen for newly created alerts.
The merge request does not address the problem, as the return value can still be null.
I also encountered this issue on a server where the site root was in a symlinked directory.
Even after following the steps above, the problem persisted until I changed settings.php to use the real (non-symlink) path.
Have made a start on this in https://git.drupalcode.org/project/ckeditor_datetime/-/merge_requests/2, but I think there's more to it than just changing the version dependency - need to make the plugin compatible with CKeditor 5
malcomio → made their first commit to this issue’s fork.
malcomio → created an issue.
malcomio → created an issue.
malcomio → created an issue.
Given that the sending form provides a text area where you can add any email address (whether or not it relates to a user), it isn't clear what the request is here.
As far as I can see, this still needs work - the merge request shows no changes, but the code still calls getUsername
This is effectively the same issue as 🐛 Call to undefined method getUsername RTBC
See also 🐛 Call to undefined method getUsername RTBC
This change doesn't explain what to do about unknown parsers, but it does:
1. fix the packagist API URL
2. only check enabled parsers
3. make the messaging a bit easier to read
\Drupal\markdown\Annotation\ComposerPackage::getAvailableVersions is using a deprecated URL to check for known packages.
See https://github.com/thephpleague/commonmark/discussions/1082#discussionco... for more info.
Regarding the unknown parsers issue, see 📌 Explain Unknown parsers more clearly Active
Strangely, https://repo.packagist.org/p/league/commonmark.json does not include 2.7.0, although it does display on https://packagist.org/packages/league/commonmark - possibly related?
See also 📌 Explain Unknown parsers more clearly Active
malcomio → created an issue.
As noted on 🐛 Unknown parser settings when saving CommonMark parser Active , we're seeing warnings about an unknown parser for commonmark 2.7.0, with the patch from #14.
Haven't seen the fatal error mentioned in #28, but we have quite a lot of patches applied to markdown, for these issues:
#3226069: Allow "incompatible" filters to be enabled (but validate that they appear after Markdown) →
🐛
After each cache clear, visiting a page filtered with markdown causes calls to pecl.php.net; it is not clear why we are doing this
Active
✨
Add support for Commonmark v2
Active
🐛
Subformstate incorrect interface error
Active
📌
Automated Drupal 11 compatibility fixes for markdown
Active
🐛
Fatal error with Drush 13 due to MarkdownCommands replacing logger
Active
Possibly related to ✨ Add support for Commonmark v2 Active ?
In our test environment, where we have the patch from that issue, and league/commonmark 2.7.0, but haven't changed any markdown settings, we are seeing "3 Unknown parsers", with CommonMark and CommonMark PECL as the unknown ones.
In another environment where we have league/commonmark:2.6.0, it isn't flagged as unknown.
This is a duplicate of 📌 Missing Readme.md file RTBC , which is already RTBC.
Thanks for the detailed response, and the suggestion of ddev-drupal-contrib - I hadn't seen that before.
I'll look at the various points you raised.
In terms of why I chose Matt Brailsford's CSS, it was just the most visually appealing to me, and technically simplest.
It did need some modification to work with Drupal, because it assumed particular markup.
It is itself a derivative of Slickmap, which uses The Unlicense.
So perhaps it would make sense to alter the styles so that they aren't based on Matt Brailsford's CSS.
In terms of an API for registering a different library, that feels like overkill to me - if a particular site wants to override styles, they can do it in the theme layer.
malcomio → created an issue.
Patch #19 doesn't apply cleanly because it was created from a site root.
I've taken the changes and applied them in https://git.drupalcode.org/project/adminimal_theme/-/merge_requests/17
It fixes the problem for me.
malcomio → made their first commit to this issue’s fork.
In our case, we disabled advagg, as the site's styling is relatively simple, and the benefits we were getting from advagg were fairly small.
@rahaf albawab what is "PSH"?
malcomio → created an issue.
@diarcastro Please could you create a merge request with the changes?
See https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... → for more details
malcomio → created an issue.
Possibly a duplicate of 🐛 Views full-text search not working Active
The change to the interface is in 📌 Add "title" attribute to YouTube, Vimeo, and Playlist embeds Needs review .
See https://git.drupalcode.org/project/video_embed_field/-/commit/6a987795ac...
As noted on 🐛 getName() must be compatible Closed: duplicate , the video_embed_field module has changed the signature of getName, so we will need to update this.
I've realised that getName comes from our patch for 📌 Implement a getName method in the VideoEmbedProvider Needs review , so we'll need to update that merge request.
malcomio → created an issue.
malcomio → created an issue.
malcomio → created an issue.
I've also observed this in some spammy webform submissions:
Incorrect string value: '\xED\xA0\xBD\xED\xB1\x89...' for column 'value' at row 6: INSERT INTO "webform_submission_data"
Inside the message was:
�� Click Here to Claim Your FREE Copy
Not sure what that was attempting to write.
With the patch applied, we're no longer seeing the original error on page load, but we are seeing this error in an alert after AJAX sorting:
An error occurred while attempting to process /views/ajax?search=&sort_by=changed&_wrapper_format=drupal_ajax: Failed to execute 'pushState' on 'History': A history state object with URL 'https://domain/search-content?sort_by=search_api_relevance' cannot be created in a document with origin 'https://domain' and URL 'https://username:password@domain/search-content?search=&sort_by=changed'.
This is a core issue - see 🐛 Drupal.urlIsLocal returns incorrect result if site URL contains authentication part Needs work
Having tested Country a little, it doesn't directly provide the filtering functionality - that comes from Select2 Boxes → , which doesn't have a stable release.
So for our use case, I think we will:
1. Use the
Chosen module →
2. Apply it to the existing select field - this could be done in a form alter, but I'd started investigating integration with the phone_number module, so I started MR34 - that patch makes it work, although ideally the change would declare dependencies etc.
I think that there was some confusion around this issue.
The patch on #4 and #5 is actually for the Phone Number (field) module → .
The issue should have been raised for that module in the first place.