- 🇪🇸Spain frouco
The fact is that the Acquia Cloud Site Review report gives a warning if in the code appear a potential modification of the memory_limit value.
@Dave Reid you are right is not a fixed value, but this will increase the memory_limit value if the module considers that it cant process the sitemap.
With this choice, the module increases the memory_limit on its own and considers that generating the XML is more important than continuing to serve pages. Also, this memory increase does not ensure that will finish in seconds, simply in less time to the detriment of other processes. In the end, the server memory is limited and increasing the memory limit only reduces the number of PHP processes that can be executed simultaneously.
Probably, the correct approach is to check if the current memory_limit value is enough to generate the XML sitemap and if not, launch a warning with the memory required/recommended in the report status, for example.
Here is a path with the described approach