Ready to be reviewed
The patch has been modified to simply ensure that the allow tag with the features required by YouTube is set in the iframe.
Allowed domains by feature should be managed by Drupal.
Ready for review
MR created and ready for review
Patch for 10.3.x versions
frouco → changed the visibility of the branch 3367077-D11-Linkfield-link-to-original-lang to hidden.
frouco → changed the visibility of the branch 11.x to hidden.
@mistermoper @EduardoMoralesAlberti
I think it will be better to move this feature to a submodule:
- Declare dependencies properly (colorbox)
- YT core code is simpler, containing only what is needed.
This solution is not really necessary.
The way to apply colours to elements inside the SVG with use is with CSS custom properties (variables).
.svg example
<svg>
<defs>
<symbol id="icon-id" viewBox="0 0 30 30" fill="none" xmlns="http://www.w3.org/2000/svg">
<circle style="fill: var(--icon-bg, none);" fill="none" cx="15" cy="15" r="15"/>
<path style="fill: var(--icon-ring, currentColor);" fill="currentColor" d="M15 2.5a12.5 12.5 0 1 1 0 25 12.5 12.5 0 0 1 0-25ZM15 0a15 15 0 1 0 0 30 15 15 0 0 0 0-30Z"/>
<path style="fill: var(--icon-figure, currentColor);" fill="currentColor" fill-rule="evenodd" clip-rule="evenodd" d="M20.29 8.88c-2.5-.17-8.08-.17-10.58 0-2.7.18-3.02 1.82-3.04 6.12.02 4.3.33 5.94 3.04 6.12 2.5.17 8.08.17 10.58 0 2.7-.18 3.02-1.82 3.04-6.12-.02-4.3-.33-5.94-3.04-6.12Zm-1.82 6.11-5.97-2.77v5.56l5.97-2.79Z" />
</symbol>
</defs>
</svg>
CSS code example
svg {
--icon-bg: currentcolor;
--icon-ring: red;
--icon-figure: #fff;
}
aggg, my mistake
I did not realise before that I had applied a patch ✨ Allow inline SVG instead of tag Active to the module in the website I was testing.
Sorry for the noise. I close the MR and this task. Module works correctly
Hi Wongjn
Yes, Im running 8.x-1.7?
The issue comes from how are generated the options of the widget, width and height are not set. So the the condition of the line 88 fo the template_preprocess_ex_icon() don't apply.
The issue can be solved there enforcing the detected size if boot values are empty but i feel that is better set the options of the icons selector correctly. Setting the width and height here and apply them here
Added credit to Alejandro Cabarcos for the support in the solutions and review
Added credit to Bryan Toapanta for the support in the QA
Added credit to Albefer for the support in the solutions
Released in version 2.1.1 →
Ready to review
Ready to review
Add the enable/disable option in the settings form
Ready to be tested
Ready to review by the community
Released in 2.0.0-alpha3 →
Corrections are done.
Ready to be reviewed.
Hi @lpeidro,
great work!!!
Only two corrections in the wording
- in /admin/reports/xray-audit/queries_data/queries_data_paragraphs-paragraphs_count_by_hierarchy change the link text from "Parents" to "See usage"
- in /en/admin/reports/xray-audit/queries_data/queries_data_paragraphs-paragraphs_use_place?parent=node&bundle=line_separator change the link text from "Link to node" to "Open page"
The fact is that the Acquia Cloud Site Review report gives a warning if in the code appear a potential modification of the memory_limit value.
@Dave Reid you are right is not a fixed value, but this will increase the memory_limit value if the module considers that it cant process the sitemap.
With this choice, the module increases the memory_limit on its own and considers that generating the XML is more important than continuing to serve pages. Also, this memory increase does not ensure that will finish in seconds, simply in less time to the detriment of other processes. In the end, the server memory is limited and increasing the memory limit only reduces the number of PHP processes that can be executed simultaneously.
Probably, the correct approach is to check if the current memory_limit value is enough to generate the XML sitemap and if not, launch a warning with the memory required/recommended in the report status, for example.
Here is a path with the described approach
Ready to review
Works fine.
The condition was added to the other paragraph listings.
@omarlopesino check the comment in the MR
@omarlopesino can you provide more info?
How the video is added (media, iframe in a WYSIWYG)? Is involved in another module or is it the default implementation?
Ready to review
This issue will have a fix in the parent task 📌 Refactor theming to provide a default styles Fixed
This issue will have a fix in the parent task 📌 Refactor theming to provide a default styles Fixed
Tested on various websites and work as expected.
Tested on various websites and work as expected.
Tested on various websites and work as expected.
Tested on various websites and work as expected.
Changes made and ready for review
Ready to review
Ready to review
frouco → created an issue.
Ready to review
Ready to review
Tested in different websites and work correctly
Changes done and ready to review
Changes done and ready to validate
Examples display was added to all the Entities Displays lists.
An example is displayed randomly each time the "See example" link is clicked
MR created and ready to review https://git.drupalcode.org/project/xray_audit/-/merge_requests/13