- 🇧🇪Belgium Dries
Added another related issue 📌 Remove trailing slashes on void elements Closed: duplicate .
- 🇳🇱Netherlands tinto Amsterdam
Briefly discussed this with @longwave and @laurii during Drupal Dev Days 2023 and decided to mark 📌 Remove trailing slashes on void elements Closed: duplicate as duplicate. I'm copying the work that I did there over to this issue.
It's probably still worth waiting for 🐛 Upgrade filter system to HTML5 Fixed to get in first.
- last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago 29,468 pass, 1 fail - Status changed to Needs review
over 1 year ago 4:28am 18 August 2023 - last update
over 1 year ago 30,043 pass, 1 fail - 🇮🇳India gauravvvv Delhi, India
I have attached patch for 11.x, please review
The last submitted patch, 106: 1388926-11.x-106.patch, failed testing. View results →
- last update
over 1 year ago 30,047 pass - 🇬🇧United Kingdom longwave UK
#105 onwards has lost all the work done in #86 and before. There are still plenty of instances of
<br />
and other void tags in core, perhaps we need to break this out into multiple issues. - 🇫🇷France andypost
Hope this issue will help to progress with related 🐛 Newline character in HtmlTag causes unwanted whitespace Needs work
- Status changed to Needs work
over 1 year ago 2:44pm 22 August 2023 - 🇺🇸United States smustgrave
#108 is already a very large patch to review. So think expanding on it would be even more difficult. So think breaking off into smaller tickets make sense. Maybe by tag?
Moving to NW for the follow ups to be created and issue summary to be updated with the new plan (if agreed upon). #108 is a good start so maybe after the follow ups we still merge this?
- 🇪🇸Spain eduardo morales alberti Spain, 🇪🇺
@smustgrave
#108 is already a very large patch to review. So think expanding on it would be even more difficult. So think breaking off into smaller tickets make sense. Maybe by tag?
Why not open a MR? it is easy to review without open new issues.
- 🇳🇿New Zealand quietone
Breaking this into smaller issues is not about whether it is a patch or an MR. It is about the scope and patch size. There is a limit to what a reviewer can effectively review and once past that limit, mistakes are made. And we can help avoid those mistakes by splitting this into smaller pieces. There is more information about scope and patch size → in the wiki.
I was looking at the patch in #86 and I do agree with smustgrave that doing this by tag is worth pursuing. However, this must be balanced if there are only a few instances of some tags that need changing. It could be sensible to combine some tags together while still keeping the change size small.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I think that thanks to 🐛 Upgrade filter system to HTML5 Fixed , this now became actually feasible to do!
- 🇫🇷France andypost
In that context would great to tackle 🐛 Newline character in HtmlTag causes unwanted whitespace Needs work