- 🇳🇱Netherlands tinto Amsterdam
This patch simply changes the closing tag for void elements from
/>
to>
on line 91 of core/lib/Drupal/Core/Render/Element/HtmlTag.php. - 🇳🇱Netherlands tinto Amsterdam
Some code refactoring in
core/lib/Drupal/Core/Render/Element/HtmlTag.php
and fixing automated test fails. - Status changed to Needs review
almost 2 years ago 8:46pm 9 March 2023 - 🇺🇸United States smustgrave
The idea makes sense but my concern with making such a change could cause issues for existing sites. Maybe both scenarios should be supported with a warning for the old way?
- Status changed to RTBC
almost 2 years ago 6:33pm 22 March 2023 The last submitted patch, 6: 3346188-6-10.1.x.patch, failed testing. View results →
- last update
almost 2 years ago 29,283 pass - last update
almost 2 years ago 29,300 pass - last update
over 1 year ago 29,302 pass - last update
over 1 year ago 29,300 pass - last update
over 1 year ago 29,361 pass - last update
over 1 year ago 29,366 pass - last update
over 1 year ago 29,367 pass - 🇬🇧United Kingdom catch
I think this is probably OK, it would likely only fail if a site specifies xhtml output which I doubt any are doing these days. However putting in front of the Front end framework managers for a look.
- 🇸🇰Slovakia poker10
There seems to be a related issue: 📌 Remove all references to "self-closing" void elements in core Needs work (with a broader scope probably).
- last update
over 1 year ago 29,374 pass - last update
over 1 year ago 29,378 pass - last update
over 1 year ago 29,379 pass - last update
over 1 year ago 29,380 pass - last update
over 1 year ago 29,383 pass - last update
over 1 year ago 29,388 pass - last update
over 1 year ago 29,388 pass - last update
over 1 year ago 29,388 pass - last update
over 1 year ago 29,388 pass 47:34 44:05 Running- last update
over 1 year ago 29,395 pass - last update
over 1 year ago 29,395 pass - last update
over 1 year ago 29,399 pass - last update
over 1 year ago 29,399 pass - last update
over 1 year ago 29,400 pass - last update
over 1 year ago 29,386 pass, 2 fail The last submitted patch, 6: 3346188-6-10.1.x.patch, failed testing. View results →
- last update
over 1 year ago 29,445 pass, 1 fail - Status changed to Closed: duplicate
over 1 year ago 10:37am 22 July 2023 - 🇳🇱Netherlands tinto Amsterdam
I was about to reroll #6, but after discussing briefly with @laurii and @longwave, I've decided to mark this issue as duplicate of 📌 Remove all references to "self-closing" void elements in core Needs work . The work done in that issue probably covers all void elements everywhere, including the code covered here.
Let's continue the work there!
- 🇪🇸Spain Juanjol Navarra
Uploaded patch in #6 with 10.2 compatibility for projects that rely on this patch, until related Issue is fixed, or a valid solution is found.
- 🇳🇱Netherlands tinto Amsterdam
Thanks for the patch, Juanjol. However, this issue was marked Closed (duplicate).
I suggest we continue to discuss/work in [1388926], starting with the discussion about how we can improve the issue by dividing the work needed into seperate issues with a smaller scope.