#Twig tag - Contrib.social

Comment 1 day ago →
🇬🇧United Kingdom scott_euser
Okay tests still failing, and I think its because maybe we still have a flaw here.

The commenting around the BC change in LibraryDiscoveryParser::setOverrideValue() is a bit unclear to me. It seems like it wants to check for the workaround like

libraries-override: contextual/drupal.contextual-links: css: component: /core/themes/stable/css/contextual/contextual.module.css: false
So to me that means it should be checking if the override like /core/themes/stable/css/contextual/contextual.module.css is from the base theme of the current theme (ie, direct parent theme, not grandparent), and if so, then throw the deprecation, but continue to work.

Is that the correct intention? If so I think its not working like that quite yet. Happy to dig a bit but wanted to check if that's the right direction first.

Thanks!
in Drupal core » Overriding already overridden libraries-override requires knowledge of previous libraries-overrides
@scott_euser opened merge request.
in Drupal core » Overriding already overridden libraries-override requires knowledge of previous libraries-overrides
Comment 1 day ago →
🇬🇧United Kingdom scott_euser

Started converting to MR

Updated some tests but more still fail, e.g. phpunit -c core/phpunit.xml core/tests/Drupal/KernelTests/Core/Asset/LibraryDiscoveryIntegrationTest.php --filter=testBaseThemeLibrariesOverrideInSubTheme

Updated issue summary to target D12 for removal of BC layer

in Drupal core » Overriding already overridden libraries-override requires knowledge of previous libraries-overrides
First commit to issue fork.
in Drupal core » Overriding already overridden libraries-override requires knowledge of previous libraries-overrides

#Twig

Issues

Overriding already overridden libraries-override requires knowledge of previous libraries-overridesNeeds workDrupal core 10.1 — theme system Created almost 9 years ago

[meta] Themes improperly check renderable arrays when determining visibilityNeeds workDrupal core 10.1 — theme system Created about 14 years ago

Update LinkWidget to accommodate the attribute.Needs workDrupal core 11.0 — link.module Created over 9 years ago

Twig debug output does not display all suggestions when an array of theme hooks is passed to #themeNeeds workDrupal core 11.0 — theme system Created about 11 years ago

Twig function Path() returns RouteNotFoundException if route does not existsActiveDrupal core 11.0 — theme system Created almost 6 years ago

Add a Production/Development Toggle To CoreNeeds workDrupal core 11.0 — base system Created over 12 years ago

Update default.services.yml file documentationFixedDrupal core 9.5 — entity system Created about 10 years ago

Multi level (multirow) header for table FAPI elementNeeds workDrupal core 10.1 — theme system Created about 14 years ago

Add theming template and prepare logic for rendering iconsActiveDrupal core 11.0 — theme system Created almost 12 years ago

How to access webform elements in webform.html.twigFixedWebform 5.0 Created over 7 years ago

Views doesn't parse twig when there are no tokens to replaceNeeds workDrupal core 9.5 — views.module Created over 7 years ago

Carousel template is throwing error Deprecated function: range(): Passing null to parameter #2 ($end) of type string|int|float is deprecatedActiveBootstrap UI Kit 1.0 Created 2 months ago

Fix the accordion title id property to match the aria-labelledby referenceActiveBootstrap UI Kit 1.0 Created about 2 months ago

Include theme print stylesheets in Book printer friendly exportPostponedDrupal core 9.5 — book.module Created about 13 years ago

Bootstrap Barrio theme gives errors under Windows/IISActiveDrupal core 10.3 — bootstrap system Created about 2 months ago

Consider updating Classy's search result markupNeeds reviewDrupal core 11.0 — search.module Created over 9 years ago

Inline css not supported at twig templateActiveDrupal core 10.2 — theme system Created about 2 months ago

Remove no-gutters class from templatesNeeds reviewBootstrap Layout Builder 2.0 Created over 2 years ago

Improve errors messages from the rendering systemPostponed: needs infoDrupal core 11.0 — render system Created over 9 years ago

Empty highlighted region returns whitespace which will always evaluate to TRUE when using twig IF Postponed: needs infoDrupal core 11.0 — theme system Created about 9 years ago

Ability to display block_content entities independently, also outside of BlocksPostponed: needs infoDrupal core 11.0 — block_content.module Created over 8 years ago

'base hook' key in hook_theme() is limited in what it inherits from the base hookClosed: outdatedDrupal core 11.0 — theme system Created over 9 years ago

Block Templates Missing Block Name SuggestionsRTBCContext 4.0 Created over 4 years ago

Remove all references to "self-closing" void elements in coreNeeds workDrupal core 11.0 — markup Created almost 13 years ago

Use Attribute::addClass() instead of CSS class concatenation in template_preprocess_views_view_table()Postponed: needs infoDrupal core 11.0 — views.module Created over 9 years ago

Remove classes from system templates c*.html.twigClosed: outdatedDrupal core 11.0 — theme system Created almost 10 years ago

block--system-menu-block.html.twig relies on id attribute which might not be setNeeds workDrupal core 11.0 — system.module Created almost 10 years ago

Allow to configure the h3 element for view style pluginsClosed: duplicateDrupal core 11.0 — views.module Created almost 12 years ago

Decide what to display for 'THEME HOOK' in Twig debug for special cases such as arrays of theme hooksActiveDrupal core 11.0 — theme system Created over 7 years ago

Add template for the iconClosed: outdatedExternal Links 1.0 Created almost 4 years ago

[meta] Consolidate similar twig templates and properly use theme suggestions in coreActiveDrupal core 11.0 — theme system Created about 12 years ago

In banner component- If there is no content the div should not be visible on the frontend.RTBCPower Portfolio 9.0 Created about 1 year ago

Print node field in twig individually with custom div structureNeeds workEntity Print 2.13 Created about 1 year ago

Cannot break down {{ content }} in template override book-node-export-html.html.twigClosed: outdatedBook 1.0 Created almost 5 years ago

Twig TemplateClosed: outdatedEntity Print 2.1 Created almost 6 years ago

Consolidate file-managed-file.html.twig and file-widget.html.twig since they are identicalClosed: outdatedDrupal core 11.0 — file.module Created over 11 years ago

Option to add attibutes in twig functionFixedIconify Field 1.0 Created 6 months ago

Facets range slider with linked input min and max Needs workFacets 3.0 Created 11 months ago

Views field template is ignored in CSV exportActiveViews data export 1.2 Created over 1 year ago

Convert "Active forum topics" block to a ViewNeeds workForum 2.0 Created over 11 years ago

one forum template fileActiveForum 2.0 Created almost 10 years ago

Remove classes from system templates p*.html.twigClosed: outdatedDrupal core 11.0 — theme system Created almost 10 years ago

Remove classes from system templates f*.html.twigClosed: outdatedDrupal core 11.0 — theme system Created almost 10 years ago

Remove ids from blocksClosed: won't fixDrupal core 11.0 — theme system Created over 9 years ago

Replace a class in forum-list.html.twig to mach naming conventionNeeds workForum 1.0 Created about 9 years ago

template_preprocess_forums generates too much HTMLActiveForum 1.0 Created almost 9 years ago

Twig SyntaxError: Unexpected "spaceless". Tag deprecated.Needs reviewPachu - NGO/Non Profit Drupal theme 1.0 Created 11 months ago

filter_autop should ignore twig.config debug html commentsFixedDrupal core 10.3 — filter.module Created 9 months ago

drupal_render() should check if it's rendering a 'render element' and if so call drupal_render_children() (inline) insteadClosed: duplicateDrupal core 8.1 — theme system Created almost 12 years ago

Make safe_join Twig filter return a Markup objectNeeds workDrupal core 11.0 — theme system Created about 9 years ago

link() function obscures getOption() resultsActiveDrupal core 11.0 — theme system Created almost 9 years ago

Replace template_preprocess() and possibly other things with Twig global variables/functionsActiveDrupal core 11.0 — theme system Created almost 9 years ago

Twig link function is tricky to useNeeds workDrupal core 11.0 — theme system Created 9 months ago

Convert theme engines into servicesNeeds workDrupal core 11.0 — theme system Created over 12 years ago

Video tag in the video templateActiveVideo.js (HTML5 Video Player) 3.0 Created 10 months ago

DFP blocks are not rendered if used inside one of the twig tweak functions.Needs reviewDoubleclick for Publishers (DFP) 1.0 Created about 6 years ago

Radix Badge template not foundClosed: works as designedradix 5.0 Created 10 months ago

Custom label logic with Twig or plugins (as replacement for 'Use PHP')ActiveAutomatic Entity Label 3.0 Created over 5 years ago

Copy simpletest templates to ClassyClosed: outdatedDrupal core 9.5 — theme system Created about 10 years ago

Create best practices about use of the l() function and the url() function in templatesClosed: won't fixCoding Standards Created about 12 years ago

Introduce proper Form API #types for 'option' and 'optgroup', and make #options consistent.Needs workDrupal core 11.0 — forms system Created almost 16 years ago

Responsive Image not working in rewritten Views field/area due to XSS filteringClosed: duplicateDrupal core 9.3 — views.module Created over 8 years ago

Move Attribute classes under Drupal\ComponentNeeds workDrupal core 11.0 — base system Created almost 9 years ago

Create Twig Templates for LinkblockPostponedWissKI 3.0 Created over 2 years ago

Automatically add theme hook suggestions for all entity typesClosed: duplicateDrupal core 11.0 — theme system Created over 10 years ago

Views path with menu tab does not validate and results in fatal errorNeeds workDrupal core 9.5 — views.module Created over 9 years ago

How do I include data from commerce_order entity in the order receipt email (twig)?FixedTwig Field Value 2.0 Created about 4 years ago

Long Twig cache directories can cause failures on some filesystemsFixedDrupal core 8.4 — theme system Created about 9 years ago

Use CSS for file icons in file fieldsFixedDrupal core 8.0 — field system Created over 10 years ago

Twig templates can call delete() on entities and other objectsFixedDrupal core 8.0 — render system Created over 9 years ago

Integrate Twig into core: Implementation issueFixedDrupal core 8.0 — theme system Created over 12 years ago

Is the <div> with class "views-element-container" around views pages needed?Needs workDrupal core 11.0 — views.module Created about 9 years ago

Create twig filters: |add_class and |set_attributeFixedDrupal core 10.1 — theme system Created over 2 years ago

Redirect subrequest via Basic site settings do not incoorporate correct theme rendering, suggestions and overrides for target path.Closed: outdatedDrupal core 11.0 — theme system Created about 7 years ago

Render multiple value fields in node templateNeeds workDrupal core 11.0 — theme system Created over 8 years ago

Name variables consistently across all templates (preprocess)Closed: outdatedDrupal core 8.0 — theme system Created about 12 years ago

Copy ckeditor templates to ClassyClosed: outdatedDrupal core 9.5 — theme system Created about 10 years ago

Deprecate drupal_find_theme_templates to Theme Registry serviceNeeds workDrupal core 10.1 — theme system Created about 9 years ago

Overriding already overridden libraries-override requires knowledge of previous libraries-overrides
Needs work
Drupal core 10.1 — theme system
Created almost 9 years ago

[meta] Themes improperly check renderable arrays when determining visibility
Needs work
Drupal core 10.1 — theme system
Created about 14 years ago

Update LinkWidget to accommodate the attribute.
Needs work
Drupal core 11.0 — link.module
Created over 9 years ago

Twig debug output does not display all suggestions when an array of theme hooks is passed to #theme
Needs work
Drupal core 11.0 — theme system
Created about 11 years ago

Twig function Path() returns RouteNotFoundException if route does not exists
Active
Drupal core 11.0 — theme system
Created almost 6 years ago

Add a Production/Development Toggle To Core
Needs work
Drupal core 11.0 — base system
Created over 12 years ago

Update default.services.yml file documentation
Fixed
Drupal core 9.5 — entity system
Created about 10 years ago

Multi level (multirow) header for table FAPI element
Needs work
Drupal core 10.1 — theme system
Created about 14 years ago

Add theming template and prepare logic for rendering icons
Active
Drupal core 11.0 — theme system
Created almost 12 years ago

How to access webform elements in webform.html.twig
Fixed
Webform 5.0
Created over 7 years ago

Views doesn't parse twig when there are no tokens to replace
Needs work
Drupal core 9.5 — views.module
Created over 7 years ago

Carousel template is throwing error Deprecated function: range(): Passing null to parameter #2 ($end) of type string|int|float is deprecated
Active
Bootstrap UI Kit 1.0
Created 2 months ago

Fix the accordion title id property to match the aria-labelledby reference
Active
Bootstrap UI Kit 1.0
Created about 2 months ago

Include theme print stylesheets in Book printer friendly export
Postponed
Drupal core 9.5 — book.module
Created about 13 years ago

Bootstrap Barrio theme gives errors under Windows/IIS
Active
Drupal core 10.3 — bootstrap system
Created about 2 months ago

Consider updating Classy's search result markup
Needs review
Drupal core 11.0 — search.module
Created over 9 years ago

Inline css not supported at twig template
Active
Drupal core 10.2 — theme system
Created about 2 months ago

Remove no-gutters class from templates
Needs review
Bootstrap Layout Builder 2.0
Created over 2 years ago

Improve errors messages from the rendering system
Postponed: needs info
Drupal core 11.0 — render system
Created over 9 years ago

Empty highlighted region returns whitespace which will always evaluate to TRUE when using twig IF
Postponed: needs info
Drupal core 11.0 — theme system
Created about 9 years ago

Ability to display block_content entities independently, also outside of Blocks
Postponed: needs info
Drupal core 11.0 — block_content.module
Created over 8 years ago

'base hook' key in hook_theme() is limited in what it inherits from the base hook
Closed: outdated
Drupal core 11.0 — theme system
Created over 9 years ago

Block Templates Missing Block Name Suggestions
RTBC
Context 4.0
Created over 4 years ago

Remove all references to "self-closing" void elements in core
Needs work
Drupal core 11.0 — markup
Created almost 13 years ago

Use Attribute::addClass() instead of CSS class concatenation in template_preprocess_views_view_table()
Postponed: needs info
Drupal core 11.0 — views.module
Created over 9 years ago

Remove classes from system templates c*.html.twig
Closed: outdated
Drupal core 11.0 — theme system
Created almost 10 years ago

block--system-menu-block.html.twig relies on id attribute which might not be set
Needs work
Drupal core 11.0 — system.module
Created almost 10 years ago

Allow to configure the h3 element for view style plugins
Closed: duplicate
Drupal core 11.0 — views.module
Created almost 12 years ago

Decide what to display for 'THEME HOOK' in Twig debug for special cases such as arrays of theme hooks
Active
Drupal core 11.0 — theme system
Created over 7 years ago

Add template for the icon
Closed: outdated
External Links 1.0
Created almost 4 years ago

[meta] Consolidate similar twig templates and properly use theme suggestions in core
Active
Drupal core 11.0 — theme system
Created about 12 years ago

In banner component- If there is no content the div should not be visible on the frontend.
RTBC
Power Portfolio 9.0
Created about 1 year ago

Print node field in twig individually with custom div structure
Needs work
Entity Print 2.13
Created about 1 year ago

Cannot break down {{ content }} in template override book-node-export-html.html.twig
Closed: outdated
Book 1.0
Created almost 5 years ago

Twig Template
Closed: outdated
Entity Print 2.1
Created almost 6 years ago

Consolidate file-managed-file.html.twig and file-widget.html.twig since they are identical
Closed: outdated
Drupal core 11.0 — file.module
Created over 11 years ago

Option to add attibutes in twig function
Fixed
Iconify Field 1.0
Created 6 months ago

Facets range slider with linked input min and max
Needs work
Facets 3.0
Created 11 months ago

Views field template is ignored in CSV export
Active
Views data export 1.2
Created over 1 year ago

Convert "Active forum topics" block to a View
Needs work
Forum 2.0
Created over 11 years ago

one forum template file
Active
Forum 2.0
Created almost 10 years ago

Remove classes from system templates p*.html.twig
Closed: outdated
Drupal core 11.0 — theme system
Created almost 10 years ago

Remove classes from system templates f*.html.twig
Closed: outdated
Drupal core 11.0 — theme system
Created almost 10 years ago

Remove ids from blocks
Closed: won't fix
Drupal core 11.0 — theme system
Created over 9 years ago

Replace a class in forum-list.html.twig to mach naming convention
Needs work
Forum 1.0
Created about 9 years ago

template_preprocess_forums generates too much HTML
Active
Forum 1.0
Created almost 9 years ago

Twig SyntaxError: Unexpected "spaceless". Tag deprecated.
Needs review
Pachu - NGO/Non Profit Drupal theme 1.0
Created 11 months ago

filter_autop should ignore twig.config debug html comments
Fixed
Drupal core 10.3 — filter.module
Created 9 months ago

drupal_render() should check if it's rendering a 'render element' and if so call drupal_render_children() (inline) instead
Closed: duplicate
Drupal core 8.1 — theme system
Created almost 12 years ago

Make safe_join Twig filter return a Markup object
Needs work
Drupal core 11.0 — theme system
Created about 9 years ago

link() function obscures getOption() results
Active
Drupal core 11.0 — theme system
Created almost 9 years ago

Replace template_preprocess() and possibly other things with Twig global variables/functions
Active
Drupal core 11.0 — theme system
Created almost 9 years ago

Twig link function is tricky to use
Needs work
Drupal core 11.0 — theme system
Created 9 months ago

Convert theme engines into services
Needs work
Drupal core 11.0 — theme system
Created over 12 years ago

Video tag in the video template
Active
Video.js (HTML5 Video Player) 3.0
Created 10 months ago

DFP blocks are not rendered if used inside one of the twig tweak functions.
Needs review
Doubleclick for Publishers (DFP) 1.0
Created about 6 years ago

Radix Badge template not found
Closed: works as designed
radix 5.0
Created 10 months ago

Custom label logic with Twig or plugins (as replacement for 'Use PHP')
Active
Automatic Entity Label 3.0
Created over 5 years ago

Copy simpletest templates to Classy
Closed: outdated
Drupal core 9.5 — theme system
Created about 10 years ago

Create best practices about use of the l() function and the url() function in templates
Closed: won't fix
Coding Standards
Created about 12 years ago

Introduce proper Form API #types for 'option' and 'optgroup', and make #options consistent.
Needs work
Drupal core 11.0 — forms system
Created almost 16 years ago

Responsive Image not working in rewritten Views field/area due to XSS filtering
Closed: duplicate
Drupal core 9.3 — views.module
Created over 8 years ago

Move Attribute classes under Drupal\Component
Needs work
Drupal core 11.0 — base system
Created almost 9 years ago

Create Twig Templates for Linkblock
Postponed
WissKI 3.0
Created over 2 years ago

Automatically add theme hook suggestions for all entity types
Closed: duplicate
Drupal core 11.0 — theme system
Created over 10 years ago

Views path with menu tab does not validate and results in fatal error
Needs work
Drupal core 9.5 — views.module
Created over 9 years ago

How do I include data from commerce_order entity in the order receipt email (twig)?
Fixed
Twig Field Value 2.0
Created about 4 years ago

Long Twig cache directories can cause failures on some filesystems
Fixed
Drupal core 8.4 — theme system
Created about 9 years ago

Use CSS for file icons in file fields
Fixed
Drupal core 8.0 — field system
Created over 10 years ago

Twig templates can call delete() on entities and other objects
Fixed
Drupal core 8.0 — render system
Created over 9 years ago

Integrate Twig into core: Implementation issue
Fixed
Drupal core 8.0 — theme system
Created over 12 years ago

Is the <div> with class "views-element-container" around views pages needed?
Needs work
Drupal core 11.0 — views.module
Created about 9 years ago

Create twig filters: |add_class and |set_attribute
Fixed
Drupal core 10.1 — theme system
Created over 2 years ago

Redirect subrequest via Basic site settings do not incoorporate correct theme rendering, suggestions and overrides for target path.
Closed: outdated
Drupal core 11.0 — theme system
Created about 7 years ago

Render multiple value fields in node template
Needs work
Drupal core 11.0 — theme system
Created over 8 years ago

Name variables consistently across all templates (preprocess)
Closed: outdated
Drupal core 8.0 — theme system
Created about 12 years ago

Copy ckeditor templates to Classy
Closed: outdated
Drupal core 9.5 — theme system
Created about 10 years ago

Deprecate drupal_find_theme_templates to Theme Registry service
Needs work
Drupal core 10.1 — theme system
Created about 9 years ago

Twig Loader Error
Closed: works as designed
radix 4.10
Created about 4 years ago

file - allow change link options in preprocess / twig for target blank etc
Closed: works as designed
Drupal core 9.5 — file system
Created almost 7 years ago