Contrib.social

Refactor theme_escape_and_render() and TwigExtension::escapeFilter() to share reused code

Open on Drupal.org →
Created on 25 September 2015, almost 10 years ago
Updated 10 June 2025, about 2 months ago

Follow-up to #2572929: Document lack of auto-escape in theme functions and add a theme autoescape helper function →

Problem/Motivation

#2572929: Document lack of auto-escape in theme functions and add a theme autoescape helper function → is adding a theme_escape_and_render() helper function as a BC layer to help theme functions do autoescaping. To avoid coupling the Drupal theme system to Twig, this function is separate from TwigExtension::escapeFilter(). However, since it performs most of the same functionality, it shares a lot of code.

Proposed resolution

Refactor the overlapped parts so these two functions can reuse the same code and keep them in sync.

Remaining tasks

TBD.

User interface changes

None.

API changes

Should be none; internal refactoring with a possible internal-ish API addition.

Data model changes

None.

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

theme system

Created by

🇺🇸United States xjm

Live updates comments and jobs are added and updated live.
  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 months ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

  • Comment about 2 months ago →
    🇺🇸United States xjm

    Amending attribution.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024