Include theme print stylesheets in Book printer friendly export

Open on Drupal.org →

Created on 11 November 2011, about 13 years ago

Updated 23 July 2023, over 1 year ago

Problem/Motivation

Book module renders export pages with custom page template that should contain "print.css" but this broken because asset hardcoded relatively to current page.
Also there's no way to alter assets attached to the page because response is returned from controller without processing assets (to prevent unneeded styling)

Steps to reproduce:
1) enable book module and create new book node
2) visit "Printer-friendly version" like /book/export/html/1
3) make sure print.css loaded

currently it's broken because path should be core/misc/print.css

Proposed resolution

Make new library core/drupal.print with print.css
Allow theme libraries to override/extend drupal.print library
Add tests and commit

Remaining tasks

find a way to render attached libraries in custom responses that should skip page template from active theme

User interface changes

libraries attached in book export pages should be rendered

API changes

no

Original report by [@pianomansam]

The book module should really have the capability to pull in the print stylesheets from the active theme. Right now it is hardcoded in book-export-html.tpl.php to only pull in misc/print.css and getting it to do more requires copying the template file into the theme directory and manually pulling in a print stylesheet. This is very hackish and uncharacteristic of the Drupal Way.

🐛 Bug report

Status

Postponed

Version

9.5

Component

Last updated 5 days ago

Maintained by
🇺🇸United States @pwolanin

Created by

🇺🇸United States pianomansam

Live updates comments and jobs are added and updated live.

Needs backport to D7
After being applied to the 8.x branch, it should be considered for backport to the 7.x branch. Note: This tag should generally remain even after the backport has been written, approved, and committed.

CSS
It involves the content or handling of Cascading Style Sheets.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Twig

print.css

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇳🇿New Zealand quietone
This extension is being deprecated, see 🌱 [Meta] Tasks to deprecate Book module Active . It will be removed from core and moved to a contrib project, 📌 [11.x] [Meta] Tasks to remove Book Active .

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project → and the Extensions approved for removal → policies.

This issue may be re-opened if it can be considered critical → , If unsure, re-open the issue and ask in a comment.
Issue was unassigned.
Comment over 1 year ago →
🇳🇿New Zealand quietone
Un-assigning per Assigning ownership of a Drupal core issue → .
Status changed to Needs work 7 months ago10:28pm 1 May 2024
Comment 7 months ago →
🇺🇸United States smustgrave
Comment about 2 months ago →
🇺🇸United States smustgrave
Comment about 2 months ago →
🇺🇸United States smustgrave
Now that book is out of core wonder if this is still needed?
Comment about 1 month ago →
🇺🇸United States smustgrave
If still needed please reopen

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024