block--system-menu-block.html.twig relies on id attribute which might not be set

Created on 12 January 2015, almost 10 years ago
Updated 9 August 2024, 4 months ago

Problem/Motivation

To prevent a dependency on block entities in block templates/preprocessing, we made the id optional. However, it looks like the mentioned template file is still relying on, resulting in invalid and duplicate ID's in case you are using a menu block in a context where no ID is provided (e.g. with page_manager).

Proposed resolution

Not sure how to fix this, can we use the derivative plugin ID there somehwere? Might not be unique, though.

I once discussed with @timplunkett about being able to rely on a unique ID for blocks and make whoever is using block plugins responsible for setting one. i thought I opened an issue, but I had no luck at all at finding that again.

Remaining tasks

User interface changes

API changes

๐Ÿ› Bug report
Status

Needs work

Version

11.0 ๐Ÿ”ฅ

Component
Systemย  โ†’

Last updated about 8 hours ago

No maintainer
Created by

๐Ÿ‡จ๐Ÿ‡ญSwitzerland berdir Switzerland

Live updates comments and jobs are added and updated live.
  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024