- First commit to issue fork.
- Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
11 months ago Not currently mergeable. - Open on Drupal.org →Environment: PHP 8.2 & MySQL 8
22:55 22:55 Queueing - First commit to issue fork.
- last update
11 months ago Custom Commands Failed - last update
11 months ago Custom Commands Failed - Assigned to JohnAlbin
- 🇹🇼Taiwan JohnAlbin Taipei, Taiwan
It looks like all the new code handling for 🐛 Improve documentation of hook_theme_suggestions_HOOK_alter() Fixed has been reverted during a rebase and force push to the GitLab branch.
I'll work on properly porting this to the main (11.x) branch.
- Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
10 months ago Not currently mergeable. - @johnalbin opened merge request.
- Merge request !4622Issue #2118743: Twig debug output does not display all suggestions when an array of theme hooks is passed to #theme → (Open) created by JohnAlbin
- last update
10 months ago Custom Commands Failed - last update
10 months ago Custom Commands Failed - last update
10 months ago Custom Commands Failed - last update
10 months ago 30,082 pass, 1 fail - 🇹🇼Taiwan JohnAlbin Taipei, Taiwan
Still working on this. The solutions in 🐛 Improve documentation of hook_theme_suggestions_HOOK_alter() Fixed and 📌 Refactor out theme hook suggestion building from ThemeManager::render() into a separate function. Fixed need to be refactored so they can work with this issue.
- First commit to issue fork.
- Merge request !6308Issue #2118743: Twig debug output does not display all suggestions when an... → (Open) created by alexismmd
- 🇪🇸Spain alexismmd
alexismmd → changed the visibility of the branch 2118743-twig-debug-output-updated-11-x to hidden.
- 🇮🇹Italy Giuseppe87
@JohnAlbin about #225: I tried to rebase the MR according the documentation → , I'm sorry if I messed something up.
I needed to reroll the 10.x patch again, this time against 10.2.x, as it doesn't work anymore for that version.
In order to avoid to mess again, I'm attaching as .patch file, if it is good, should I rebase\or push on the MR request?
- First commit to issue fork.
- First commit to issue fork.
- Issue was unassigned.
- Status changed to Needs review
4 months ago 7:07pm 20 February 2024 - 🇷🇴Romania vasike Ramnicu Valcea
Some updates on MR to make it "green"
- "Refactor" for related refactor https://www.drupal.org/project/drupal/issues/2953921 📌 Refactor out theme hook suggestion building from ThemeManager::render() into a separate function. Fixed (i think also tried on #234 patch)
- Updates for the related refactor "regression" https://www.drupal.org/project/drupal/issues/3409982 🐛 [D10.2 regression] Theme suggestions cannot alter variables anymore Active
- Some updates for "invalid suggestions"
- Updates (forced sometimes) for tests to passIn conclusion ...the MR got dirty (in its "moments") ... commits and merges
And, i think, it needs more than review ... maybe a "resume" ... and make it happen!!!For now "Needs review" ... but it's "Needs work" (imho) ,,, still
- Status changed to RTBC
4 months ago 3:50am 21 February 2024 - 🇨🇦Canada joseph.olstad
This is a 10 year old issue that will improve DX / TX by a large margin. I'm favoring a community RTBC on this as we'll need theming system manager review on this and from there lets try to get this to the finish line and into the end zone ( a release ) while we have some momentum here.
- 🇮🇳India Bhanu951
Bhanu951 → changed the visibility of the branch 2118743-twig-debug-output-d10 to hidden.
- 🇮🇳India Bhanu951
Bhanu951 → changed the visibility of the branch 11.x to hidden.
- Status changed to Needs work
4 months ago 1:08pm 1 March 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Needs to merge 11.x and fix conflicts due to ✨ Make it more obvious that a Twig template is overridden Fixed
- First commit to issue fork.
- Status changed to Needs review
4 months ago 11:57am 2 March 2024 - 🇷🇴Romania vasike Ramnicu Valcea
MR green again
Most of errors were from https://www.drupal.org/project/drupal/issues/3420709 ✨ Make it more obvious that a Twig template is overridden Fixed update .. mentioned in #241.
So updated the MR - put back things and fix testsThere also others changes missed in latest merges and rebases. I hope I covered them all.
Let's review again
- Status changed to RTBC
4 months ago 4:42pm 3 March 2024 - 🇨🇦Canada joseph.olstad
- Has new and adjusted test coverage
- Passes all tests
- Conflicts are resolved.
- Code Quality hasn't changed.
- 11 years and counting, it's time
- Status changed to Needs work
3 months ago 5:01pm 13 March 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to RTBC
3 months ago 6:27pm 13 March 2024 - 🇷🇴Romania vasike Ramnicu Valcea
MR updated - solved conflicts
so RTBC ... once more - Status changed to Needs work
3 months ago 12:07pm 26 March 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
I think we need a separate CR detailing the new variables that are going to be available ie.
+ // Add two read-only variables that help the template engine understand + // how the template was chosen from among all suggestions. + $variables['template_suggestions'] = $template_suggestions; + $variables['template_suggestion'] = $hook;
And specifically how they related to any existing variables, ie. theme_hook_original.
Also this is adding an
info
variable everywhere - this feels very generic and likely to be used elsewhere - is this necessary? - 🇩🇪Germany metalbote Aachen
metalbote → changed the visibility of the branch 2118743-twig-debug-output-d10 to active.
- 🇺🇸United States mrweiner
Re-rolled #234 for latest 10.2.6.
There was one conflict:
CONFLICT (modify/delete): core/modules/system/tests/src/Functional/Theme/TwigDebugMarkupTest.php deleted in 51703edde0 (Applying patch 231 from issue 2118743) and modified in HEAD. Version HEAD of core/modules/system/tests/src/Functional/Theme/TwigDebugMarkupTest.php left in tree
But, just left the file in per HEAD.