- ๐ฌ๐งUnited Kingdom welly
I've tested the patch at #107 on Drupal 10.4.5 and confirm this works. It fixed an issue I was having that was exactly as described. This was after an upgrade of group_content_menu from 3.0.1 to 3.0.5 and Drupal 10.2.12 to 10.4.5.
- ๐ซ๐ทFrance pdureau Paris
Also, it may be the opportunity to challenge the various additions Drupal made to Twig last 10 years.
Today, in my very personal and humble opinion, I see only 5 additions which will stay relevant if we move to SDC, decoupling between UI logic and business logic, and design system philosophy:
- the
PrintNode
visitor to send all printed variable to the renderer service. That's the core of Drupal Twig rendering, it works very well and must be kept. -
Attribute
object and the relatedcreate_attribute()
function, but I hope this issue will allow us to get rid of it one of those days: โจ HTML attributes as Twig mappings instead of PHP obejcts Active add_class()
&set_attribute()
filters, they make sense used with the SDC slots.- the new
icon()
function for the Icon API. It follows Twig philosophy of using functions to generate printable data - the translations helpers (
t
function,trans
tag). Important feature for a CMS. Why not proposing this to upstream Twig?
So, other Drupal additions (
clean_id()
,attach_library()
,link()
,|add_suggestion()
...) seems OK to be deprecated to me, once we have "cleaned" the Render API. I would happy to discuss this. - the