πŸ‡§πŸ‡ͺBelgium @aspilicious

Account created on 10 August 2007, over 17 years ago
#

Merge Requests

Recent comments

πŸ‡§πŸ‡ͺBelgium aspilicious

I created a dev release

πŸ‡§πŸ‡ͺBelgium aspilicious

This merge request, together with https://www.drupal.org/project/ai_provider_openai/issues/3519302 ✨ Abstract token usage support Active
Allowed me to create this module: https://www.drupal.org/project/ai_usage_limits β†’

πŸ‡§πŸ‡ͺBelgium aspilicious

Thanks for the information. This should be better.

πŸ‡§πŸ‡ͺBelgium aspilicious

But it's my first time creating a fork so maybe I need to do something else.

πŸ‡§πŸ‡ͺBelgium aspilicious

aspilicious β†’ changed the visibility of the branch 3519302-abstract-token-usage to active.

πŸ‡§πŸ‡ͺBelgium aspilicious

aspilicious β†’ changed the visibility of the branch 3519302-abstract-token-usage to hidden.

πŸ‡§πŸ‡ͺBelgium aspilicious

I learned a lot about contributing 2.0.

The token functions are only available on chat level at this moment.
If it's needed on other output classes we probably should move these to a trait.

πŸ‡§πŸ‡ͺBelgium aspilicious

Here is a starting point, allows us to discuss if this is the direction you want.

πŸ‡§πŸ‡ͺBelgium aspilicious

I'm investigating this at this moment.
Did you start coding?

πŸ‡§πŸ‡ͺBelgium aspilicious

@berdir is it possible to roll a new release?

πŸ‡§πŸ‡ͺBelgium aspilicious

@marcus thank you, this answer is really helpfull. As we probably can't fix this for all providers, we probably will create a seperate module.

How would you block the requests when the limits are reached?

πŸ‡§πŸ‡ͺBelgium aspilicious

Hey,

This adds drupal 11 support but it's very unusual to have a complete instal (including .ddev) folder inside a module.
Try to restructure your module to remove any dependencies that are not needed.

The updated composer file in the patch is a start in the right direction.

πŸ‡§πŸ‡ͺBelgium aspilicious

@alexandergull could you tag a release? Drupal 11 is released.

πŸ‡§πŸ‡ͺBelgium aspilicious

Is there a reason we limit drupal 10 versions?

core_version_requirement: ^8.8 || ^9 || ~10.0.0 || ~10.1.0 || ~10.2.0

Why don't you add

core_version_requirement: ^8.8 || ^9 || ~10

πŸ‡§πŸ‡ͺBelgium aspilicious

"The big thing though is retaining AJAX autocomplete for scalability."
This is very important for a lot of projects.
I know that select2 implementations of a normal select can go wrong with +1000 elements.

πŸ‡§πŸ‡ͺBelgium aspilicious

So something like this, strike through can be colors

My node title | article | published | fr es

πŸ‡§πŸ‡ͺBelgium aspilicious

in Drupal 7 this is usually solved with one row for each entity and sometimes an extra column with all the language codes and the translated ones look different thas the others.

The current state is too confusing for most clients.

πŸ‡§πŸ‡ͺBelgium aspilicious

I'm a JS noob, so I can't say anything useful, but I think when it's done we need to manual test this with 1000+ tags to see if it has any effect. Just to be sure. I'm always ready for doing that when needed.

It will gain me lots of credits with the UX designers at work ;)

πŸ‡§πŸ‡ͺBelgium aspilicious

We have a site with more than 6000 tags and counting (since september 2014). We can't use select fields for those in combination with select2 because it's nearly impossible to render.
Making tags a select field would introduce severe performance issues.

As I do see the advantage for 95% of the use cases I would like to have a fallback to the current behaviour. But that would be hard because one widget is a textfield and the other a select widget :s

Damn...

Can't we fund a JS genius to make a drupalSelect fork of select2? XD

πŸ‡§πŸ‡ͺBelgium aspilicious

Tag autocompletion still has issues. I made two tags:

"Some tag", "a new tag"

When editing the node you get 1 merged tag: "some tag, a new tag". The tag list in the backend looks ok, so it's a js thingie.

πŸ‡§πŸ‡ͺBelgium aspilicious

I WANT this patch so I tested it but found some problems.


- tags with spaces don't get recognised


- When editing the same node nothing gets recognised


- Why is timezone a select 2 field and country not?


- Can there be multiple authors? That's confusing. After the first author the autocomplete doesn't work anyway.

Production build 0.71.5 2024