Nullable types must be explicit

liam morland → made their first commit to this issue’s fork.

Reviewed and spotted one last nullable type. For the rest looks good.

Note this does not change the function signature see my note about this on https://github.com/commerceguys/addressing/pull/221#issuecomment-2582855457 so shouldn't require more than a patch release.

.gitlab-ci.yml changes apart from temporarily enabling PHP_MAX are out of scope. Those performance optimizations are very much on purpose. the phpunit jobs took 30min+ here.

As commented in the other issue, the job output is full of entity_browser and search_api (and maybe other) nullable types errors, which makes it hard to verify that ther's nothing left in paragraphs.

While not a hard blocker, it would be helpful to make sure issues in those projects exist and are referenced.

I have restored the testing customization and referred to the related issues in entity_browser and search_api.

Looks good, thanks!

Attaching a stable patch file for composer patches.

Merged. field_group and search_api still cause some fails, removed max testing for now.

@berdir is it possible to roll a new release?

Automatically closed - issue fixed for 2 weeks with no activity.

Exported MR into patch to use in composer.