Victoria, BC (T'So-uke lands)
Account created on 16 November 2014, about 10 years ago
#

Merge Requests

More

Recent comments

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

Out of the box, no. But there is an issue for it: https://www.drupal.org/project/drupal/issues/3463868#comment-15902579 🐛 Two #config_targets error when used on a text_format form element Active

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde made their first commit to this issue’s fork.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

MR 10182, resolves the issue, and seems like the least noisy solution and most future safe.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

I have dealt with other people choices to run Drupal on Windows Servers - including Drupal 10.
Strongly in favour of dropping official support.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

messages sent to current maintainers

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

For other folks, the other change mentioned is https://github.com/commerceguys/addressing/pull/221.
It does impact pretty much the same functionality unfortunately (looking up countries and divisions) but might be somewhat cached in Drupal - I haven't confirmed one way or the other.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

That's unfortunate :(
The post update hook is a one off so whatever.
The two views plugins are (potentially) used every time the address form is rendered depending on what fields are exposed (either administrative areas or countries or both) - so quite likely very noisy. It is only a deprecation so production sites *shouldn't* have that being reported and can wait until PHP 9 but I don't like it heh. But yeah if for other maintenance reasons you need to wait, it is what it is.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde created an issue.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde created an issue.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)
🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde created an issue.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde created an issue.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde created an issue.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde created an issue.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde created an issue.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

ready for review

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

working for me, thanks

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

Code review looks fine, but I think it needs tests - will try to do some manual testing sometime soon too.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

Not strictly speaking security so I wouldn't suggest this blocking approval but a few concerns:
- Caching: unless there is some need, I'd strongly suggest caching based on user context, and not setting max-age to 0. That will disable full page cache on any page with that block. Caching based on user will let anonymous pages still be cached at least.
- *.module file is not required if it is empty.
- weak dependency on font-awesome (fa-* classes) with no mention of font-awesome requirements

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

Webform 6.3 now has an alpha release for Drupal 11 support.
Additionally due to https://www.drupal.org/node/3404140 updated form in new branch/MR

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde made their first commit to this issue’s fork.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

Thanks bot and thanks folks for testing.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde made their first commit to this issue’s fork.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

Fantastic improvements, merging.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde made their first commit to this issue’s fork.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde made their first commit to this issue’s fork.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde made their first commit to this issue’s fork.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

Thanks for the readme improvements.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde made their first commit to this issue’s fork.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

v outdated. drupalci no longer exists.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

The phpstan issues remain:
- Deprecation should be fixed later with a new major that is 10.3+ only.
- Drush code parts will be fixed by #3273784: Replace Drush 8 integration with Drush 11 .
- DI should be fixed not immediately before release so that it can have adequate testing

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde created an issue.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

Strongly agree important to just get a release - even if marking it as alpha or beta - is important.
That said, @tjtj use this https://www.drupal.org/project/webform/releases/6.3.x-dev for now rather than the custom branch. It should work, but chance that the dependences on webform_views won't allow it. If it doesn't allow it you could try 'as 6.3.0' or similar.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

Without knowing the JavaScript in use, can't make any real guesses on that. Likely the JS isn't triggering properly on AJAX but without seeing it not sure.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

Hit an immediate hard failure - opened PR https://github.com/php-tuf/composer-integration/pull/126
With applying that, get:

https://packagist-signed.drupalcode.org could not be fully loaded (Maximum allowed download size reached. Downloaded 1165080 of allowed 1165080 bytes), package information was loaded from the local cache and may be out of date

(this continues after many runs)

Packages: 81
TUF metadata: 5.4mb

Failing with "The 'bin_d9c-d9f' contents does not match hash 'sha256' specified in the 'snapshot' metadata." - for a while.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)
🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde created an issue.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

Thanks botty bot

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde made their first commit to this issue’s fork.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

Testing that worked on old Drupal CI, and locally failed on gitlab exposing a bug. Why I love tests!

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde created an issue.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

@damienmckenna you got any current plans here? if not, I'm planning on releasing a new version with probably just D11 support this week.
Thanks

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

current description is "Roles with this access permission would not be checked for spammer"

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

Closing this as outdated. Current 8.x-1.x-dev is phpcs passing now. If further improvement in strings is desired by anyone, please open a new ticket

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

note: sometimes the two phpunit tests running work, sometimes one fails. will create another issue for that.
This resolves the validation issues.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde created an issue.

🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)
🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

nickdickinsonwilde created an issue.

Production build 0.71.5 2024