🇨🇦Canada @nickdickinsonwilde

📌 Add composer.libraries.json Active Asset packagist is no longer the top install recommendation.
Additionally in that, adjusted wording in Asset Packagist mentions to hopefully clarify.

nickdickinsonwilde → created an issue.

Nice, thanks... lets merge this a year later.

Closing, working fine on D11 and no comments in 1/2 year

Very much in favour of this - would need readme updates as well but the plan written out seems good to me

Fantastic, thanks.
Merged (test failure was not related to this change but in the main repo)

nickdickinsonwilde → made their first commit to this issue’s fork.

The readme is close to template as is. Additionally the changes in this MR are negative:

For example the installation section starts with:
"""
Installation

Make this module a base that could be used by any color picker.
include COLOR PICKER

include ColorPicker (v. 1.0) and Colors

include Farbtastic Color Picker
"""

Those are entirely unrelated to installation, and are in stated that those are *not* supported.

nickdickinsonwilde → created an issue.

That's a very fancy edge case. Merged, thanks

nickdickinsonwilde → made their first commit to this issue’s fork.

PHP 7.4 was end of life in 2022 and Drupal 10 didn't support it. closing this as outdated. Should've limited so that people running outdated versions couldn't make mistakes but at this that window has closed (especially because cannot edit past releases to add that limitation)

Should be using ✨ Support Layout Builder live preview Needs work and still needs tests - or at least manual testing instructions

Setting back to fixed.
At time of release PHP 7.4 was past end of life.
definitely would have been better to include that in the dependencies but should be moot point by now.

At this point considering this issue dead. PHP 7.4 was EOL before this issue was opened and no version of Drupal 10 has supported (officially) under PHP 8.1.
Might've been a sensible thing to do at the time due to some people running PHP 7.4 past end of life.

Drupal 7 is unsupported, I have zero Drupal 7 sites left personal or work so unfortunately I'm not able to dedicate any time to D7. Closing.

Drupal 7 is unsupported, I have zero Drupal 7 sites left personal or work so unfortunately I'm not able to dedicate any time to D7. Closing.

Drupal 7 is unsupported, I have zero Drupal 7 sites left personal or work so unfortunately I'm not able to dedicate any time to D7. Closing.

Drupal 7 is unsupported, I have zero Drupal 7 sites left personal or work so unfortunately I'm not able to dedicate any time to D7. Closing.

Drupal 7 is unsupported, I have zero Drupal 7 sites left personal or work so unfortunately I'm not able to dedicate any time to D7. Closing.

1.1.0 resolved this

hestenet → credited nickdickinsonwilde → .

hestenet → credited nickdickinsonwilde → .

nickdickinsonwilde → created an issue.

Error message for searching:
In Drupal.php line 169:
\Drupal::$container is not initialized yet. \Drupal::setContainer() must be called with a real container.

nickdickinsonwilde → created an issue.

thanks

nickdickinsonwilde → made their first commit to this issue’s fork.

Works correctly for me with a minor caveat and a concern.

* no hook_update_N(): Probably not safe to randomly update but if the php branch is using the prior standard URL might be safe to update, otherwise should have readme or just include notes to update in release?

* hook_install is using URL at install time/field requires an absolute URL. That could lead to problems between environments if databases get copied around. Probably a small risk but figured I'd bring it up

nickdickinsonwilde → created an issue.

Out of the box, no. But there is an issue for it: https://www.drupal.org/project/drupal/issues/3463868#comment-15902579 🐛 Two #config_targets error when used on a text_format form element Active

Thanks

nickdickinsonwilde → made their first commit to this issue’s fork.

MR 10182, resolves the issue, and seems like the least noisy solution and most future safe.

I have dealt with other people choices to run Drupal on Windows Servers - including Drupal 10.
Strongly in favour of dropping official support.

nickdickinsonwilde → created an issue.

nickdickinsonwilde → created an issue.

messages sent to current maintainers

nickdickinsonwilde → created an issue.

For other folks, the other change mentioned is https://github.com/commerceguys/addressing/pull/221.
It does impact pretty much the same functionality unfortunately (looking up countries and divisions) but might be somewhat cached in Drupal - I haven't confirmed one way or the other.

That's unfortunate :(
The post update hook is a one off so whatever.
The two views plugins are (potentially) used every time the address form is rendered depending on what fields are exposed (either administrative areas or countries or both) - so quite likely very noisy. It is only a deprecation so production sites *shouldn't* have that being reported and can wait until PHP 9 but I don't like it heh. But yeah if for other maintenance reasons you need to wait, it is what it is.

nickdickinsonwilde → created an issue. See original summary → .

nickdickinsonwilde → created an issue.

nickdickinsonwilde → created an issue. See original summary → .

nickdickinsonwilde → created an issue.

nickdickinsonwilde → created an issue.

nickdickinsonwilde → created an issue.

nickdickinsonwilde → created an issue.

nickdickinsonwilde → created an issue.

nickdickinsonwilde → created an issue.

nickdickinsonwilde → created an issue.

nickdickinsonwilde → created an issue.

nickdickinsonwilde → created an issue.

nickdickinsonwilde → created an issue.

nickdickinsonwilde → created an issue.

ready for review

nickdickinsonwilde → created an issue.

working for me, thanks

nickdickinsonwilde → created an issue.

nickdickinsonwilde → created an issue.

Code review looks fine, but I think it needs tests - will try to do some manual testing sometime soon too.

Not strictly speaking security so I wouldn't suggest this blocking approval but a few concerns:
- Caching: unless there is some need, I'd strongly suggest caching based on user context, and not setting max-age to 0. That will disable full page cache on any page with that block. Caching based on user will let anonymous pages still be cached at least.
- *.module file is not required if it is empty.
- weak dependency on font-awesome (fa-* classes) with no mention of font-awesome requirements

Webform 6.3 now has an alpha release for Drupal 11 support.
Additionally due to https://www.drupal.org/node/3404140 → updated form in new branch/MR

nickdickinsonwilde → made their first commit to this issue’s fork.

Thanks bot and thanks folks for testing.

nickdickinsonwilde → made their first commit to this issue’s fork.

thejimbirch → credited nickdickinsonwilde → .

needs some tests

Fantastic improvements, merging.

nickdickinsonwilde → made their first commit to this issue’s fork.

nickdickinsonwilde → created an issue.

nickdickinsonwilde → created an issue.

nickdickinsonwilde → made their first commit to this issue’s fork.

nickdickinsonwilde → created an issue.

Thanks botty bot

nickdickinsonwilde → made their first commit to this issue’s fork.

Thanks for the readme improvements.