- Issue created by @nickdickinsonwilde
- 🇪🇸Spain fjgarlin
I'm not sure if I even have a local copy of that file anywhere that we could have used as a fallback. Yeah some of the suggestions on that other issue could be implemented, but obviously it'll take way longer than downloading a file with everything we needed...
As starters, it'd be great to see if we can get that file and put it in the repo as fallback, even if it will get obsolete.
- 🇪🇸Spain fjgarlin
It seems like this page could have all we need: https://www.php.net/manual/en/indexes.functions.php
We'd need to parse it though.Found the link here: https://github.com/geany/geany/issues/584#issuecomment-128271692
- 🇪🇸Spain fjgarlin
I also created an issue on that other project https://github.com/geany/geany/issues/4076, since they will have the same problem.
- 🇪🇸Spain fjgarlin
Found a version from 2024: https://web.archive.org/web/20240625000039/https://doc.php.net/downloads...
I might add this as a fallback.
- 🇪🇸Spain fjgarlin
Suggested MR. This is not ideal as it's a static snapshot from June 2024 but for now this is the best we have. It won't be full PHP support but it will still be best that no support.
I still need to test it manually.
- 🇨🇦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)
Works correctly for me with a minor caveat and a concern.
* no hook_update_N(): Probably not safe to randomly update but if the php branch is using the prior standard URL might be safe to update, otherwise should have readme or just include notes to update in release?
* hook_install is using URL at install time/field requires an absolute URL. That could lead to problems between environments if databases get copied around. Probably a small risk but figured I'd bring it up
- 🇪🇸Spain fjgarlin
Those are really valid points.
I'm sure that we can also change the code to not requiring an absolute URL. If "http" is found we can use guzzle, otherwise try "file_get_contents" or something like that.
Setting back to "needs work".