- Issue created by @nickdickinsonwilde
- Merge request !1933492380 fix nullable types to be explicit β (Merged) created by nickdickinsonwilde
- π¦πΉAustria drunken monkey Vienna, Austria
Thanks a lot for creating this issue and already providing a great merge request!
I donβt think weβll have any problems with backwards compatibility here since making the nullability explicit makes no difference to PHP (except for the deprecation warning in PHP 8.4+). To test, just run the following locally (or run it on 3v4l.org):
class A { function foo(array $a = NULL) {} } class B extends A { function foo(?array $a = NULL) {} } class C extends B { function foo(array $a = NULL) {} }
No warnings at all for PHP 8.3 and lower, just the expected deprecation warnings for 8.4.
No idea what went wrong with your pipeline there, but just re-running it worked fine. So, merged.
Thanks again! -
drunken monkey β
committed 17bf61a7 on 8.x-1.x authored by
nickdickinsonwilde β
Issue #3492380 by nickdickinsonwilde, drunken monkey: Fixed implicit...
-
drunken monkey β
committed 17bf61a7 on 8.x-1.x authored by
nickdickinsonwilde β
Automatically closed - issue fixed for 2 weeks with no activity.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
It would be very helpful to get a release with this change. Modules that depend on this module also display messages about this on PHP 8.4.
PHP does not see this as a change in the function signature, so a major version update is not needed.