🇨🇦Canada @sylus

I made releases for wxt_bootstrap and wxt_library as well as making the needed markup changes so we weren't getting the duplicate parliament banner in the footer. :)

Thanks for the help in tracking all of this down!

I saw that this was merged upstream :)

Thanks for the catch, I sadly thought it was ok to jump to the next version.

I took your suggestions and maybe on the next release can then bump groups up.

I'll make sure to add this to the notes. :)

Thanks again!

I got to this when I updated Drupal Core but thanks so much :)

Committed and attributed!

Thanks so much!

Committed and attributed!

Thanks so much!

The related issue under WxT Library was contributed and attributed :)

Committed and attributed!

Thanks so much for this!

It would be awesome to get this to work again as was broken when drush removed some functionality we relied on.

With the patch I still get errors so think still needs a bit of work but thanks so much for looking into it!

 [error]  Error: Call to a member function export() on null in Drupal\wxt_ext_config\Commands\Wxtcex->wxtConfigExport() (line 54 of /var/www/html/profiles/wxt/modules/custom/wxt_ext/wxt_ext_config/src/Commands/Wxtcex.php) #0 [internal function]: Drupal\wxt_ext_config\Commands\Wxtcex->wxtConfigExport(Array)
#1 /var/www/vendor/consolidation/annotated-command/src/CommandProcessor.php(276): call_user_func_array(Array, Array)
#2 /var/www/vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback(Array, Object(Consolidation\AnnotatedCommand\CommandData))
#3 /var/www/vendor/consolidation/annotated-command/src/CommandProcessor.php(175): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter(Array, Array, Object(Consolidation\AnnotatedCommand\CommandData))
#4 /var/www/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(387): Consolidation\AnnotatedCommand\CommandProcessor->process(Object(Symfony\Component\Console\Output\ConsoleOutput), Array, Array, Object(Consolidation\AnnotatedCommand\CommandData))
#5 /var/www/vendor/symfony/console/Command/Command.php(326): Consolidation\AnnotatedCommand\AnnotatedCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#6 /var/www/vendor/symfony/console/Application.php(1096): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#7 /var/www/vendor/symfony/console/Application.php(324): Symfony\Component\Console\Application->doRunCommand(Object(Consolidation\AnnotatedCommand\AnnotatedCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#8 /var/www/vendor/symfony/console/Application.php(175): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#9 /var/www/vendor/drush/drush/src/Runtime/Runtime.php(110): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#10 /var/www/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun(Array, Object(Symfony\Component\Console\Output\ConsoleOutput))
#11 /var/www/vendor/drush/drush/drush.php(139): Drush\Runtime\Runtime->run(Array)
#12 /var/www/vendor/drush/drush/drush(4): require('/var/www/vendor...')
#13 {main}. 
Error: Call to a member function export() on null in /var/www/html/profiles/wxt/modules/custom/wxt_ext/wxt_ext_config/src/Commands/Wxtcex.php on line 54 #0 [internal function]: Drupal\wxt_ext_config\Commands\Wxtcex->wxtConfigExport(Array)
#1 /var/www/vendor/consolidation/annotated-command/src/CommandProcessor.php(276): call_user_func_array(Array, Array)
#2 /var/www/vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback(Array, Object(Consolidation\AnnotatedCommand\CommandData))
#3 /var/www/vendor/consolidation/annotated-command/src/CommandProcessor.php(175): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter(Array, Array, Object(Consolidation\AnnotatedCommand\CommandData))
#4 /var/www/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(387): Consolidation\AnnotatedCommand\CommandProcessor->process(Object(Symfony\Component\Console\Output\ConsoleOutput), Array, Array, Object(Consolidation\AnnotatedCommand\CommandData))
#5 /var/www/vendor/symfony/console/Command/Command.php(326): Consolidation\AnnotatedCommand\AnnotatedCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#6 /var/www/vendor/symfony/console/Application.php(1096): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#7 /var/www/vendor/symfony/console/Application.php(324): Symfony\Component\Console\Application->doRunCommand(Object(Consolidation\AnnotatedCommand\AnnotatedCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#8 /var/www/vendor/symfony/console/Application.php(175): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#9 /var/www/vendor/drush/drush/src/Runtime/Runtime.php(110): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#10 /var/www/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun(Array, Object(Symfony\Component\Console\Output\ConsoleOutput))
#11 /var/www/vendor/drush/drush/drush.php(139): Drush\Runtime\Runtime->run(Array)
#12 /var/www/vendor/drush/drush/drush(4): require('/var/www/vendor...')
#13 {main}
Error: Call to a member function export() on null in Drupal\wxt_ext_config\Commands\Wxtcex->wxtConfigExport() (line 54 of /var/www/html/profiles/wxt/modules/custom/wxt_ext/wxt_ext_config/src/Commands/Wxtcex.php).
 [warning] Drush command terminated abnormally.

Committed and attributed!

sylus → created an issue.

Ah so these fixes do solve the problem but this usually means some of the markup must have slightly changed since the gcweb updates.

If we can find the markup changes that occurred in this region and match it again, then we shouldn't need to fix this with CSS.

I'll try to take a further look but it might not be for a couple of days but for now the css fix works for those want to try it out. :)

Thanks so much!

With the upgrade to the latest assets does that mean this issue can be closed since it looks like resolves some of the older errors?

wxt_library assets are pulled in from wet-boew assets and are not under Drupal's control which is why they can't fall under Drupal's minification process because the assets are hosted externally and have their own minification process.

So I took a look at this and if you did a fresh install of WxT 5.2.1 all of these blocks show up correctly without needing any patch.

If I had to make a guess I wonder if your block name is different and with the block handling logic in preprocess something is behaving a bit wonky.

I'm pretty sure your problem lies somewhere in this block preprocess code and to me one of your block names must be different then what it expects.

I bet if you compare against a fresh install of 5.2.1 where this works out of the box you might be able to spot the difference.


// Determine which webform to display in footer.
$block_exists_1 = $this->checkBlockExistence('didyoufindwhatyouwerelookingfor');
$block_exists_2 = $this->checkBlockExistence('reportproblemblock');

if ($block_exists_1 && $block_exists_2) {
$did_you_find_webform = $this->activateDidYouFindWebform();
$variables['display'] = TRUE;

if ($did_you_find_webform) {
if ($variables['plugin_id'] == 'share_widget_block') {
$variables['attributes']['class'] = [
'col-sm-3',
'col-sm-offset-2',
'col-lg-offset-3',
];
}

if ($variables['plugin_id'] == 'report_problem_block') {
$variables['display'] = FALSE;
$variables['content'] = [];
}
}
else {
if ($variables['plugin_id'] == 'find_what_you_looking_for') {
$variables['display'] = FALSE;
$variables['content'] = [];
}
}
}

I have upgraded wet-boew to v4.0.74 and theme-gcweb to v14.5.0 and all seems to still look good and function correctly.

Committed and attributed!

Thanks so much!

Thank you so much for this!

Committed and attributed!

Done and with proper attribution!

Thanks so much!

I think your right @joseph.olstad and should only be on PHP 5.

I removed the patch!

Yeah I think this can be removed now, especially since we also don't bundle with the icon module anymore.

Thanks @joseph.olstad this all looks great to me!

Committed and attributed!

Committed and attributed!

Thank you so much!

Committed and attributed :)

Thanks so much!

This looks awesome!

Thanks @Liam for the improvement!

Committed and attributed!

Will add this functionality to the docsite.

Thanks @SKAUGHT and I took a look at the other patch and it seems its also resolved and mentioned in this comment here:

https://www.drupal.org/project/group/issues/2864721#comment-13928947 →

Using Drupal 9.1 with Groups, no longer requires this patch (#2864721). It is resolved in Drupal 9.1 (and likely with patch https://www.drupal.org/project/drupal/issues/2972308 → for previous Drupal versions).

The next comment references functionality we might lose but seems like an edge case.

I pushed an update to group ^2.2 with the patches removed and just want to test an upgrade.

Thanks for this everyone!

Committed and attributed the patch to core!

Releases have been made against both branches :)

Hope this is all resolved now!

Ok I released a 5.2.0 its not perfect but I want to get the ball rolling and as we find bugs I can try to make sure I'm as quick as possible to release.

I pushed up an update to it :)

Let me know if this looks better!

https://github.com/drupalwxt/drupalwxt.github.io/commit/8e345b27ab01c67e...

I forgot to attribute for the 5.1.x line but did for the 5.2.x.

My apologies but thanks for this :)

I pushed a 5.2.x branch that is passing in CI and did a few tests and seems to look good on a cursory glance.

A good first step. :)

Missed a file

Patch for Drupal 10.2.x but doesn't use the Config Target API that was recently changed.

Patch for Drupal 10.2.x but doesn't use the Config Target API that was recently changed.

Ooops wrong patch.

Re-roll from #29 against D10.2.x.

Re-roll from #29 against D10.2.x as the interdiffs it seemed I had but didn't have time to look further.

Just a re-roll against Drupal 10.2.x

Committed and attributed :)

Thanks so much!

Committed and attributed :)

Thanks so much!

Committed the fix :)

Yeah since they say group 1.6 isn't supported in D10 prolly something we have to do.

Sadly I do notice that there are no corresponding patches for the 2.x.x line so I'm hoping the problem is just fixed that those patches were attempting to address.

            "drupal/group": {
                "Enter drupal/group patch #2817109 description here":
                "https://www.drupal.org/files/issues/2817109-by-rachel_norfolk-ericras-How-to-redir.patch",
                "Enter drupal/group patch #2864721 description here":
                "https://www.drupal.org/files/issues/2020-07-30/group-translate_content_permission-2864721-20.patch",
                "Enter drupal/group patch #2895988 description here":
                "https://www.drupal.org/files/issues/2022-07-31/2895988-29.patch"
            },

Becomes

            "drupal/group": {
                "Enter drupal/group patch #2817109 description here":
                "https://www.drupal.org/files/issues/2022-11-02/2817109-2.0.x-how-to-redirect-30.patch"
            },

Committed and attributed :)

Thanks so much!

Nice find :)

I don't see a patch attached though? Maybe was missed?

Thanks for finding this though!

Committed and attributed :)

Thanks so much!

Committed and attributed :)

Thanks so much!

Committed and attributed :)

Thanks for the detailed explanation. :)

This guard seems reasonable to me so committed and attributed. :)

Really appreciate it!

Committed and attributed :)

Thanks @smulvih2

Committed and attributed :)

Committed and attributed :)

Committed and attributed thanks for the fix everyone :D

Fixed thank you!

Committed and attributed!

Thanks so much for fixing this!

Committed and attributed!

Committed and attributed!

Committed and attributed!

Committed and attributed!

Hi @joseph.olstad I just wanted to say thank you so much for all of this.

I'll eventually be adding this issue as a link in our CHANGELOG.md notes as well as was thinking about making a page for it with (attribution of course) to https://drupalwxt.github.io

I want to do a new release over the weekend and will coincide this with then. :)

Thank you so much @SKAUGHT and @OPTASY for all of the amazing work.

I'm very appreciative of this you have no idea. :)

As well thank you to everyone for all of the reviews and +1's.

Teamwork makes the dream work.

Committed and attributed!

Thank you so much for this fix!

Committed and attributed :)

I think this problem is no longer under our purview and the match for views_data_export which we don't bundle by default does have a patch which seems to correct the issue.

I did just update group to v1.6 until we can find time to jump to the v3 version of it.

Just closing this so work can be focused on the related issue which talks about the same problem.

https://www.drupal.org/project/wxt/issues/3346753 →

Is this still an issue on latest WxT and / or with CKEditor5?

Thank you for this :)

Also agree with just removing this since I believe it came out when we needed to port logic from Lighting so dependency could be removed when it was announced they were discontinuing their work on it. (Though later it seems they still somewhat supporting some of the sub modules).

I removed this code since it indeed is no longer needed and because the backend theme is Claro

Just a bit of background that I have more information in this regard in relation to Azure. :)

The problem is with the difference btw Single Server and Flexible Server.

Single Server

Single Server is on a retirement path w/Azure and all future installs are asked to use Flexible Server for both MySQL and PostgreSQL.

This is where most of the performance issues arise due to the fact that Single Server is on a Shared pool of backend windows node behind a gateway. Performance can be slightly improved by using redirection which reduces network latency between client applications and MySQL servers by allowing applications to connect directly to backend server nodes. Please note no functionality like this was added for the PostgreSQL Single Server.

https://learn.microsoft.com/en-us/azure/mysql/single-server/how-to-redir...

Flexible Server

With Flexible Server you get pretty much a managed virtual machine of which you get complete control over the IOPS and it is actually running under Linux rather then Windows. With this setup I have found performance to be acceptable. I would say with all the proper configuration you can probably in most cases get similar to 75-80% of the performance you would get with local containerized db that would obviously have less latency then a remote db even if in the same availability zone.

https://github.com/canada-ca-terraform-modules/terraform-azurerm-flex-mysql

@smulvih2 can you take a look at this as well?

I think we should also add this to our overview page linking to this issue under wxt_ext_webform so people don't miss additional features being added like this.

https://drupalwxt.github.io/docs/general/overview/

Anyways first impression is this is amazing work as I have in the past heard this request a fair bit.

It also aligns with us trying to be a reference implementation to show solutions to some common patterns in the GoC and elsewhere.

Thank you for tracking this down and fixing!

Committed and attributed!

This looks great!

Committed and attributed!

Committed and attributed but I did make both filters and editors for both CKEditor 4/5.

This looks great and I think the logic makes sense to me.

Committed and attributed!

Committed and attributed!

Committed and attributed!

Committed and attributed!

I think we will have to do the same thing that we did for rich_text.

editor.editor.rich_text_ckeditor5.yml
editor.editor.rich_text.yml
filter.format.rich_text_ckeditor5.yml
filter.format.rich_text.yml
<code>

So we will need to add

<code>
editor.editor.full_html_ckeditor5.yml
editor.editor.full_html.yml
filter.format.full_html_ckeditor5.yml
filter.format.full_html.yml

And still have CKEditor 4 the default till we can confidently remove it.

Hmm it gave it to Patrick Norris?

https://git.drupalcode.org/project/wxt_library/-/commit/529f6e918916d11b...

I have asked @smulvih2 to take a closer look at this and maybe see what core does and / or recommends.

Our initial thouht was with full html there should be no content filtering enabled etc. :)

Can we add this new functionality in the overview section of our doc pages?

Just want to make sure users know of this feature :)

Hi @smulvih2 would you mind also adding this to our overview page in docs similar to other improvements?

Thanks for the great work!

Lets do this!

I know you spent a lot of time getting this working, and I read over a bit of the issue you attached and the approach seems reasonable.

Also the fact that we really need to support this as more and more people switch to CKEditor 5 and eventually I do want to remove CKEditor 4.

Committed and attributed!

I think this got fixed by @smulvih2 when we did everything to upgrade for Drupal 10. :)

Thanks for this @Optasy!

Committed and attributed!

This all looks great to me and appreciated everyone helping to improve the accessibility!

I noticed we dropped the roles still as mentioned by Optasy

https://www.drupal.org/project/wxt/issues/3385626#comment-15265800 →

Was this intentional, I was pretty sure the wet-boew JS reacts on some of these elements.

I'll admit to not fully understanding this one but I think the change makes sense?

FilterInterface::TYPE_TRANSFORM_IRREVERSIBLE — Irreversible transformation filters. The filter performs a transform for which a WYSIWYG plugin does not exist to perform the transformation client-side (especially, the reverse of it); instead, the WYSIWYG editor displays the unfiltered text. For example, Token Filter.

Thanks for testing this one and will just take your word on it :)