- Issue created by @joseph.olstad
- π¨π¦Canada joseph.olstad
Suggested commit command which provides author credit on commit:
git commit -m 'Issue #3457046: Code comments in wxt_ext_layout say to remove these' --author="Joseph Olstad <20895-joseph.olstad@users.noreply.drupalcode.org>"
- π¨π¦Canada joseph.olstad
straight from
wxt_ext_layout.module
:@todo Remove when we require Panels 4.5 or later, since it implements and tests this functionality itself
- Issue was unassigned.
- π¨π¦Canada sylus
Commit and attributed :)
I'm still curious why this doesn't display anymore on the credit and committing section. :(
- Status changed to Fixed
6 months ago 11:56pm 1 July 2024 -
sylus β
committed f21ec0b3 on 5.2.x authored by
joseph.olstad β
Issue #3457046: Code comments in wxt_ext_layout say to remove these
-
sylus β
committed f21ec0b3 on 5.2.x authored by
joseph.olstad β
- π¨π¦Canada joseph.olstad
I mentioned to Drumm and someone else about this on Slack in the d.o infra channel, they weren't happy with the way I brought it up. Maybe find the channel on slack and nudge them a bit more on this. Could probably get them to restore this functionality. I have no idea why they turned it off, still don't understand their response.
- πͺπΈSpain fjgarlin
Even setting the author, credit wouldnβt be given. Credit is only given/assigned via the checkboxes table at the bottom.
The author of the commit is just the creator of the MR.
As of right now, none of you have βcreditsβ.
Note that the credit system stipped parsing commit messages years ago. It only looks at the table to assign credits.
- π¨π¦Canada joseph.olstad
yes but git keeps author information, there's issue credit for d.o and commit author, two different things. They are related but NOT the same.
- Status changed to Active
6 months ago 12:39pm 2 July 2024 - Status changed to Fixed
6 months ago 12:40pm 2 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.