LB inline blocks are no longer translatable.

Created on 24 June 2024, 10 months ago
Updated 30 July 2024, 9 months ago

Problem/Motivation

As detailed here: 🐛 Contextual links for translation are removed by core Active , Drupal 10.2 introduced code to "clean" up LB contextual links on blocks. As a downside to this it removes the contextual link added by the Layout Builder Symmetric Translations module which WxT uses to allow translation of blocks placed in LB.

The following patch adds the patch to WxT's composer.json.

I am providing the patch as i don't appear to have commit access to the WxT repository. If there is some other mechanism that I am given commit credit for this that is fine.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

5.2

Component

Code

Created by

🇨🇦Canada liquidcms

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @liquidcms
  • 🇨🇦Canada liquidcms

    Patch attached.

  • Status changed to Needs review 10 months ago
  • 🇨🇦Canada joseph.olstad

    To ensure proper author credit is given to @liquidcms with this commit , the commit command should be as follows:

    git commit -m 'Issue #3456872 by liquidcms: LB inline blocks are no longer translatable' --author="Peter Lindstrom <24279-liquidcms@users.noreply.drupalcode.org>"

    uid 24279 is Liquidcms uid on drupalcode.org

  • 🇨🇦Canada joseph.olstad

    As a maintainer of another project, I was just reminded to check the checkboxes for issue credit.

    This should be done also in wxt:

    Only a maintainer has access to check these boxes and make the checkmark persist.

    See screenshot:

    There should be a checkbox put beside @liquidcms in this case

  • 🇨🇦Canada sylus

    Ah thanks @joselph.olstad and @liquidcms, especially for the note that they removed the attribution options?

    Was there explanation why Drupal.org removed the --author attribution in the iisue commit screen?

    Was it because they are preferring Merge Requests over the patch workflow?

    Either way every commit should ALWAYS reflect the owner who author/contributed who contributed their time and effort so if ever I missed a authorship on a commit or anything let me know!

    I can also add both of you to commit access on the latest branch if helps but is nice to have an issue with patch attached though I know I need to do that myself better.

  • Status changed to Fixed 10 months ago
  • 🇨🇦Canada sylus

    Committed and attributed!

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Fixed 10 months ago
  • 🇨🇦Canada joseph.olstad

    Checked "By LiquidCMS" checkbox for credit

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024