- Issue created by @kevin.bruner
- Status changed to Needs review
5 months ago 7:37pm 14 June 2024 - 🇨🇦Canada joseph.olstad
@kevin.brunner, until this is integrated into wxt, you can get around this problem by correctly adding a patches ignore entry to the
patches-ignore section of the composer.json
it is drupalwxt:
followed by drupal/ctools with the exact string to the broken patchthen add the newly rerolled patch → to replace it in the patches section.
- Assigned to joseph.olstad
- Status changed to Active
5 months ago 8:04pm 14 June 2024 - Issue was unassigned.
- Status changed to Needs review
5 months ago 8:37pm 14 June 2024 - Status changed to Active
5 months ago 9:31pm 14 June 2024 - 🇨🇦Canada joseph.olstad
Ooops, wow, wxt is using ctools 3.x, oops, I'll roll a new patch for 3.x
- Status changed to Needs review
5 months ago 9:35pm 14 June 2024 - 🇨🇦Canada joseph.olstad
ok, same patch for ctools latest tagged releases for both 8.x-3.x and 4.1.x
I checked, the new patch rolls cleanly for both branches
- 🇨🇦Canada hilalsafiFDO
We are experiencing the same issue, but with the Drupal panels. The error message reads:
- Applying patches for drupal/ctools
https://www.drupal.org/files/issues/ctools-option_to_expose-2667652-3.patch → (Enter drupal/ctools patch #2667652 description here)
https://www.drupal.org/files/issues/ctools-entity_field_rendered_twice-2... → (Enter drupal/ctools patch #2924356 description here)
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/ctools-entity_field_rendered_twice-2... →In Patches.php line 331:
Cannot apply patch Enter drupal/ctools patch #2924356 description here ( https://www.drupal.org/files/issues/ctools-entity_field_rendered_twice-2... → )!
- 🇨🇦Canada kevin.bruner
Thank you, Joseph! I can confirm that your patch + patch-ignore combo worked, however, we are now getting the same issue with panels as the latest commentor has also mentioned.
- 🇨🇦Canada smulvih2 Canada 🍁
Here is an excerpt from my composer.json file needed to upgrade all of my dependencies on WxT 5.2.2:
"patches": { "drupal/ctools": { "2924356": "https://www.drupal.org/files/issues/2024-06-14/ctools-entity_field_rendered_twice-2924356-12.patch" } }, "patches-ignore": { "drupalwxt/wxt": { "drupal/ctools": { "2924356": "https://www.drupal.org/files/issues/ctools-entity_field_rendered_twice-2924356-2.patch" }, "drupal/panels": { "2849867": "https://www.drupal.org/files/issues/2023-01-11/panels_custom_attributes_in_panels_blocks-2849867-92_0.patch", "2667755": "https://www.drupal.org/files/issues/bandaid.patch" } } }
So the new patch for drupal/ctools as Jospeh pointed out, but also two patches for drupal/panels need to be removed. The first one #2849867 has been rolled into the latest version, and #2667755 (can't actually find the d.org ticket for this one) adds the id() method that already exists, and you get a WSOD with error about duplicate id().
-
sylus →
committed 7589685a on 5.2.x authored by
joseph.olstad →
Issue #3454675 by joseph.olstad, smulvih2: Patches failing to apply
-
sylus →
committed 7589685a on 5.2.x authored by
joseph.olstad →
- Status changed to Fixed
5 months ago 12:00am 2 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.