- 🇺🇸United States smustgrave
Started at #29 as #30 and #32 removed the tests.
Also undid the changes from https://git.drupalcode.org/project/drupal/-/commit/ca8a550c056875254ff00...
Am getting this weird phpstan error not sure why
Running PHPStan on changed files. ------ --------------------------------------------------- Line modules/layout_builder/layout_builder.module ------ --------------------------------------------------- 40 Function t invoked with 2 parameters, 1 required. 52 Function t invoked with 2 parameters, 1 required. 53 Function t invoked with 2 parameters, 1 required. 57 Function t invoked with 2 parameters, 1 required. 61 Function t invoked with 2 parameters, 1 required. ------ ---------------------------------------------------
Found 1 bug though, moving the block makes it disappear. Refreshing the page I see the block again and it moved so something weird is going on.
- last update
over 1 year ago 30,138 pass, 1 fail - 🇺🇸United States smustgrave
Fixing test failure and adding fix for moving block failure I mentioned in #35
But imagine tests will need to be updated based on the fix.
- 🇺🇸United States tim.plunkett Philadelphia
I think this should be postponed on 🐛 Page title should contextualize the local navigation Needs work
- Merge request !4735Issue #2938129: PageTitle block is non-functional when not handled directly by \Drupal\block\Plugin\DisplayVariant\BlockPageVariant → (Open) created by smustgrave
- last update
over 1 year ago 30,150 pass, 2 fail - last update
over 1 year ago 30,150 pass, 2 fail - Status changed to Postponed
over 1 year ago 12:07am 9 September 2023 - 🇺🇸United States smustgrave
@tim.plunkett sounds good! If you get time mind reviewing though? Had to put a number of checks for layout builder, moving of blocks, and just regular titles.
Added some additional tests.
- 🇨🇦Canada sylus
Re-roll from #29 against D10.2.x as the interdiffs it seemed I had but didn't have time to look further.
- 🇨🇦Canada joseph.olstad
Ok, there's a deprecation on str_contains when using PHP 8.1/PHP 8.2+, in some case came out null, so this is an interdiff and new patch making sure that it's an empty string that is used instead of a null.
- last update
about 1 year ago 25,810 pass, 1,809 fail - last update
about 1 year ago 26,087 pass, 1,794 fail - last update
about 1 year ago Build Successful - 🇨🇦Canada joseph.olstad
haha yes "postponed" status threw us off. We still need this with our D11.1.1 upgrade
- 🇨🇦Canada smulvih2 Canada 🍁
The MR branch was pretty old, so I rebased it on 11.x and added patch #43 on top. Fixed linting and default tests. The non-default tests are failing for unrelated reasons, so think we can ignore those.