- 🇺🇸United States smustgrave
Appears to need a rebase
Can the CR be updated though it doesn't really seem to line up with the MR or explain the change to me
If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇬🇧United Kingdom catch
Looks good, I wondered if we should add @throws to the method but it's not really an API method anyway and there's a @todo to remove it in one of the multiple follow-ups. Committed/pushed to 11.x, thanks!
- 🇮🇳India anjaliprasannan
@joshua1234511 The test is failing in the pipeline. I tried it in the local by following the test steps where I could not find a message as in the test case. Is the test written as per requirement? Should the test be rewrorked on?