Layout builder overrides on a single content item not allowed in a workspace

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Fixed failed commands on #22
Attached patch against Drupal 10.1.x
Attached interdiff

I'm not sure if I'm doing this right, but I found that layout builder would crash and throw duplicate primary key errors on entity clone. This would also create orphaned inline_block_usage rows, with empty layout_entity_id.

The cloned entity would also no longer save, due to the orphaned references.

I added a check in InlineBlockEntityOperations->saveInlineBlockComponent(), for entity id. Line 233.

The entity is always set, but in some cases the entity id would be empty, causing addUsage() to fail. This seems to work fine and nodes save layout builder properly.

This is against 9.5, however I think its relevant to this issue? Its exactly the same as the 10.1 patch, with an addition if statement- so should be fine for 10.1 as well. If the check is in the proper spot, thats an entirely different question. At my experience level... I believe so, but not positive.

Fixed failed commands on #25
Attached patch against Drupal 10.1.x

Try To Fix The #26 Custom Commands Failed Patch.

Try To Fix The #27 CMF.

Updated #28 with the event from https://www.drupal.org/project/drupal/issues/3208390#comment-15200955 📌 Add an API for allowing modules to mark their forms as workspace-safe Needs work

Converted the latest patch to a MR, changed the approach for marking LB forms as workspace-safe by using a trait and marking individual forms, so this issue doesn't depend on 📌 Add an API for allowing modules to mark their forms as workspace-safe Needs work anymore.

Tests were added in #22, I just moved them to the Workspaces module, so removing the tag.

Still probably needs @tim.plunkett sign off, but with the schema change I imagine we would need an upgrade path right?

Replied in the MR why I don't think an upgrade path is needed.

RTBC - looks great to me and makes sense!

Would like to commit this one, but I don't understand the answer about the upgrade path entirely, so asked on the MR. Back to needs review again for that. I agree we don't need a content upgrade path, but would like to know why we don't need a config upgrade path to match the new schema.

Replied in the MR :)

OK that's a very confusing situation, but it's not a situation that was introduced here, and the explanation is spot on, so... Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks! Really nice to get this one in!

Automatically closed - issue fixed for 2 weeks with no activity.