Applied and reviewed tha MR, the code which resolve the issue.
It does provide an "Enable View" or "Disable View" option into the edit view dropdown menu.
Attached Before and After screenshot.
Working on this issue, will review it.
One approach to resolve this could be to add a condition before saving the configuration to check if any `block_class` settings are present. If not, we could skip the save operation to prevent unnecessary dependencies.
pooja saraah → made their first commit to this issue’s fork.
pooja saraah → made their first commit to this issue’s fork.
added some improvement and attached patch with updated version.
The modified patch checks if the $node object is not null and if it's an instance of the expected class (ObjectClass).
The check for translatability is simplified to directly use the $node object. If it's not null and is translatable, it returns the internal URI; otherwise, it returns the original URI.
Added Condition for Active Language Check:
The elseif condition checks if there is no translation object for the switched language used by the language field in the entity ($this->activeLangcode) and if the requested language ($langcode) is different.
If this condition is met, it initializes the translation using the default active translation.
Attached modified patch.
Working on issue
Replaced the deprecated function call locale_system_set_config_langcodes() with the suggested replacement \Drupal\locale\LocaleConfigManager::updateDefaultConfigLangcodes()
These changes should ensure compatibility with Drupal 11.0.0 while addressing the deprecation warnings.
Attached patch against Drupal 11 and interdiff file.
Issue Summary:
Problem/Motivation:
The current option summary for 'Link display' in the DisplayPluginBase class is unclear and can lead to confusion. This issue aims to improve clarity by updating the option summary text to 'Destination.'
Steps to Reproduce:
* Navigate to a Views configuration page.
* Observe the 'Link display' option in the pager category.
Proposed Solution:
Update the title of the 'link_display' option from:
'title' => $this->t('Link display'),
to:
'title' => $this->t('Destination'),
This change provides a more descriptive and understandable label for the option.
Test Plan:
* Before applying the patch:
* Verify that the option summary for 'Link display' is present on a Views configuration page.
* Confirm that the text is currently set to 'Link display.'
* Apply the Patch:
* Apply the provided patch to update the 'Link display' text to 'Destination.'
* Confirm that the patch applies cleanly without conflicts.
* After applying the patch:
* Navigate to a Views configuration page.
* Verify that the 'Link display' text in the option summary is now replaced with 'Destination.'
pooja saraah → made their first commit to this issue’s fork.
In the original service definition, the second argument is specified as @?workspaces.association. The ? indicates that this argument is optional, meaning that the WorkspaceSubscriber class can accept either the workspaces.association service or no service at all.
In the modified service definition, the optional operator ? has been removed from the second argument. This means that the WorkspaceSubscriber class now explicitly expects the @workspaces.association service as a required argument.
Purpose of the Change:
The modification aligns the service definition with the actual constructor requirements of the WorkspaceSubscriber class. By removing the optional operator, the service definition accurately reflects that the WorkspaceSubscriber class expects the @workspaces.association service to be provided during instantiation.
pooja saraah → made their first commit to this issue’s fork.
This patch addressed the test fail
Attached interdiff against Comment 28
pooja saraah → made their first commit to this issue’s fork.
pooja saraah → made their first commit to this issue’s fork.
I have attached a patch with some modifications for it prepares the account for cancellation, and regardless of confirmation, it ensures proper session handling after cancellation.
Hi @sibiru i couldn’t replicate this issue, help us providing steps to reproduce to evaluate and review the issue.
Hello @leo liao, could you kindly provide detailed steps to reproduce the issue? This information will significantly assist us in reviewing the problem thoroughly and working towards a resolution. Thank you for your cooperation!
pooja saraah → created an issue.
Reviewed and applied the MR on local. Header is looking good on Mobile view admin panel is not overlapping now. It is working as expected. Here are the before and after screenshots for the same.
moving to RTBC ++
I've reviewed the issue locally and couldn't replicate it. The placement of the menu hamburger appears fine in the mobile view. I've attached screenshots for your reference.
Reviewed and applied the patch on local. Theme structure is showing properly now. It is working as expected. Here are the before and after screenshots for the same.
Moving to RTBC++
Hey @alok_singh
why do we need better styling for pager? It looks good without additional changes.
This is not replicated on Drupal 10.
Can you please provide any more details how this gets replicated?
Adding Screenshots for reference.
Reviewed and applied the MR on local. There is no Extra space below footer section. It is working as expected. Here are the before and after screenshots for the same.
We can move it to RTBC ++.
Reviewed and applied the MR on local. The alignment of search button on mobile view is good. It is working as expected. Here are the before and after screenshots for the same.
We can move it to RTBC ++.
Reviewed and applied the patch on local. Image are not breaking down it looks good on all mobile devices. It is working as expected. Here are the before and after screenshots for the same.
We can move it to RTBC ++.
Reviewed and applied the MR on local. In the list of menu items we have a parent link and provide two options: Edit and "Add child". It is working as expected. Here are the before and after screenshots for the same.
Reviewed and applied the MR on local. The pagination styling is now looking good, it is working as expected. Here are the before and after screenshots for the same.
We can move it to RTBC ++.
Reviewed and applied the MR on local. The Read More option is now looking good, it is working as expected. Here are the before and after screenshots for the same.
We can move it to RTBC ++.
Reviewed and applied the MR on local. The submitted date does not have black background and its looking good, it is working as expected. Here are the before and after screenshots for the same.
RTBC+1..
Reviewed and applied the MR on local and now the Alignment of mail icon and mailing address are looking good, it is working as expected. Here are the before and after screenshots for the same.
RTBC+1..
Reviewed and applied the MR on local and Pagination is now looking good, it is working as expected. Here are the before and after screenshots for the same
RTBC+1..
tim.plunkett → credited pooja saraah → .
Addressed #39
Reroll patch against Drupal 10.1.x
Attached patch against Drupal 10.1.x
Fixed failed commands on #21
Attached patch against Drupal 10.1.x
Fixed failed commands on #19
Attached patch against Drupal 10.1.x
Fixed failed commands on #28
Attached patch against Drupal 10.1.x
Attached reroll patch
Fixed failed commands on #5
Attached patch against Drupal 10.1.x
Fixed failed commands on #114
Attached patch against Drupal 10.1.x
Fixed failed commands on #52
Attached patch against Drupal 10.1.x
Addressed the Comment #55
Attached patch against Drupal 10.1.x
Fixed failed commands on #258
Attached patch against Drupal 10.1.x
keeping it in needs work for other failed commands need to be fixed.
Addressed the comment #51
Attached patch against Drupal 10.1.x
Rerolled patch against Drupal 10.1.x
Attached patch
Fixed failed commands on #28
Attached patch against Drupal 10.1.x
Fixed failed commands on #61
Attached patch against Drupal 10.1.x
Attached interdiff
Attached patch against Drupal 10.1.x
Attached reroll patch
Attached interdiff #23 and #27
Fixed failed commands on #23
Fixed failed commands on #25
Attached patch against Drupal 10.1.x
Addressed the comment on #28
Attached patch against Drupal 10.1.x
Fixed failed commands on #83
Attached patch against Drupal 10.1.x
Fixed failed commands on #18
Attached patch against Drupal 10.1.x
Attached interdiff
Fixed failed commands on #17
Attached patch against Drupal 10.1.x
Attached interdiff
Addressed the comment on #17
Attached patch against Drupal 9.5.x
Addressed the Comment #102
Attached patch against Drupal 10.1.x
Attached reroll patch
Fixed failed commands on #162
Addressed the comment on #164
Attached patch against Drupal 10.1.x
Fixed failed commands on #11
Attached patch against Drupal 10.1.x
Fixed failed commands on #16
Attached patch against Drupal 10.1.x
Fixed failed commands on #2
Attached patch against Drupal 10.0.x
Fixed failed commands on #86
Attached patch against Drupal 10.1.x
Fixed failed commands on #51
Attached patch against Drupal 10.1.x
Fixed failed commands on #24
Attached patch against Drupal 10.1.x
Addressed the comment on #346
Attached patch against Drupal 10.1.x
Fixed failed commands on #87
Attached patch against Drupal 10.1.x
Fixed failed commands on #64
Attached patch against Drupal 10.1.x
Addressed the comment on #344
Attached patch against Drupal 10.1.x
Fixed failed commands on #6
Attached patch against Drupal 10.1.x
Fixed failed commands on #58
Attached patch against Drupal 10.1.x
Fixed failed commands on #29
Attached patch against Drupal 10.1.x
Attached interdiff
Fixed failed commands on #22
Attached patch against Drupal 10.1.x
Attached interdiff
Fixed failed commands on #21
Attached patch against Drupal 10.1.x