The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Hiding patch #99 as it's incomplete. You omitted the /core/modules/book/src/Access/BookNodeOutlineAccessCheck.php class
@Deshna Chauhan Please stop uploading incomplete and broken re-roll patches without an interdiff.
- 🇮🇳India Nitin shrivastava
@BramDriesen Try to addressed your point add all file in reroll for d10.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
@Nitin shrivastava Thanks, but your patch is still missing the /core/modules/book/src/Access/BookNodeOutlineAccessCheck.php class. And from a quick glance you're also missing a newline in the first code block.
I suggest to ignore what was done in #99 and start fresh from the patch in #90.
Hiding your patch and interdiff as well for that reason.
For the next person coming in. Start from #90 and provide a patch+interdiff based of that patch.
- 🇳🇿New Zealand quietone
@Deshna Chauhan and @Nitin shrivastava I am removing credit for the unhelpful patches per How is credit granted for Drupal core issues → .
- 🇮🇳India pooja saraah Chennai
Addressed the Comment #102
Attached patch against Drupal 10.1.x
Attached reroll patch - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
@pooja saraah That looks a lot better! Thanks :)
Needs work still justified for #94
- 🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
Re-Roll The Patch #104 Due To Custom CMD Failed.
- Status changed to Needs review
about 2 years ago 9:07am 8 February 2023 - Status changed to Needs work
about 2 years ago 4:37pm 20 February 2023 - Status changed to Postponed
over 1 year ago 4:54am 23 July 2023 - 🇳🇿New Zealand quietone
This extension is being deprecated, see 🌱 [Meta] Tasks to deprecate Book module Active . It will be removed from core and moved to a contrib project, 📌 [11.x] [Meta] Tasks to remove Book Active .
This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project → and the Extensions approved for removal → policies.
This issue may be re-opened if it can be considered critical → , If unsure, re-open the issue and ask in a comment.
- Status changed to Needs work
10 months ago 10:26pm 1 May 2024 - Merge request !25Issue #502430 by chris burge, oriol_e9g, girishmuraly, mindbet, dagomar,... → (Merged) created by smustgrave
-
smustgrave →
committed 2ee6574f on 2.0.x
Issue #502430 by chris burge, oriol_e9g, girishmuraly, mindbet, dagomar...
-
smustgrave →
committed 2ee6574f on 2.0.x
Automatically closed - issue fixed for 2 weeks with no activity.