The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 5:55pm 31 January 2023 - 🇺🇸United States kerasai
Updated patch for 9.5.x, we'll see if the test bot can apply it to 10.x.
- Status changed to Needs work
almost 2 years ago 9:15am 1 February 2023 - 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
This change looks great, we need to update phpstan base level though.
- 🇮🇳India pooja saraah Chennai
Fixed failed commands on #58
Attached patch against Drupal 10.1.x - Status changed to Needs review
almost 2 years ago 4:43pm 1 February 2023 - Status changed to Needs work
almost 2 years ago 5:13pm 1 February 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Patch does not apply. Needs a rebase I think.
- Status changed to Needs review
almost 2 years ago 7:01am 2 February 2023 - Status changed to Needs work
almost 2 years ago 2:56pm 2 February 2023 - 🇺🇸United States kerasai
Noting that the functional changes from the patches in this issue have been incorporated into what looks like all supported versions of core via 📌 Replace REQUEST_TIME in rest of OO code (except for tests) Fixed and #3112283: Replace REQUEST_TIME in non-OO and non-module code → . The remainder of the changes are pertinent only to running core's tests, otherwise patching likely is not necessary.
