Replace REQUEST_TIME in rest of OO code (except for tests)

This needs a reroll for 10.1.x, patch no longer applies.

Ran the test fails on the latest 10.1.x with this patch with --repeat=20. SaveActionTest passed, but EntityValidationTest is now flaky. It fails about 30% of the time

#43 patch not applied for me also, Please try this new patch.
Thanks

The last submitted patch, 45: 3112295-45.patch, failed testing. View results →

Moving back to an MR workflow, rebased #45 on to a new branch off 11.x in a new MR

acbramley → changed the visibility of the branch 3112295-replace-requesttime-in to hidden.

acbramley → changed the visibility of the branch 11.x to hidden.

The MR is green but we did have another failure earlier which I couldn't reproduce locally https://git.drupalcode.org/issue/drupal-3112295/-/pipelines/85141/test_r...

Drupal\KernelTests\Core\Action\SaveActionTest::testSaveAction
Failed asserting that 1706669556 is not identical to 1706669556.

I'm not too sure how this could happen when we're sleeping

Another similar random failure this time in testEntityChangedConstraintOnConcurrentMultilingualEditing

Was looking at this a bit, and I'm not quite sure some of the examples actually do not have access to the container

Baseline needs clean-up

  Line   core/lib/Drupal/Core/KeyValueStore/DatabaseStorageExpirable.php                               
 ------ ---------------------------------------------------------------------------------------------- 
         Ignored error pattern #^Call to deprecated constant REQUEST_TIME\:                            
         Deprecated in drupal\:8\.3\.0 and is removed from drupal\:11\.0\.0\.                          
         Use \\Drupal\:\:time\(\)\->getRequestTime\(\); $# in path                                     
         /builds/issue/drupal-3112295/core/lib/Drupal/Core/KeyValueStore/DatabaseStorageExpirable.php  
         was not matched in reported errors.  

Should be good to go now

Found one instance that can use DI

@acbramley, something like this ?

Looks perfect! Nice one.

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

It was the last in list, so META can be closed as well!

PS: please close MR

catch → closed merge request !6399

Automatically closed - issue fixed for 2 weeks with no activity.