- Status changed to Needs review
almost 2 years ago 4:04am 16 February 2023 - 🇮🇳India Yogesh Sahu
Adding the patch for drupal 10.1.x.
no interdiff because #10 patch fail to apply. - Status changed to Needs work
almost 2 years ago 10:22am 16 February 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India pooja saraah Chennai
Fixed failed commands on #28
Attached patch against Drupal 10.1.x - Status changed to Needs review
almost 2 years ago 7:48pm 16 February 2023 - 🇺🇸United States xjm
Tried to clarify in the IS why Kernel tests for config entities don't need to install entity tables.
- 🇺🇸United States smustgrave
Thanks @xjm
Removing credit from myself because all I did was rebase to see if we can get the build to work.
- Status changed to RTBC
almost 2 years ago 12:13am 18 February 2023 - 🇺🇸United States smustgrave
All green and changes seem like a good cleanup/update.
- 🇺🇸United States tim.plunkett Philadelphia
Is it worth adding a deprecation/assertion within
installEntitySchema
to further discourage this? - 🇳🇿New Zealand quietone
catch suggested that the idea in #35 be moved to a followup. Adding tag for that.
I was thinking that we should get an up to date list of tests with this problem because the last time this was run was on Drupal 8.8. More tests have been added since then. However, there will be a followup that will pick up any added since this started. So, I think it is fine to get this incremental improvement in.
I'll wait a day for other committers to comment.
- 🇺🇸United States smustgrave
Opened 📌 Add deprecation to installEntitySchema Active
-
quietone →
committed b91529c9 on 10.1.x
Issue #3052430 by tedbow, rpayanm, xjm, jasonawant, smustgrave, tim....
-
quietone →
committed b91529c9 on 10.1.x
- Status changed to Fixed
almost 2 years ago 2:11am 22 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.