FileUploadHelp preprocessor was broken by Core's change to constraint plugins

The image resolution constraint description should be broken too, but I don't have the ability to test that in my current environment.

Setting to NW based on comment #3.

It's still NW due to #3, but I tested the MR on a 10.2.0 site and a 10.1.x site. The constraint text appeared correctly on both sites. So the BC code works and you shouldn't have to release a new major version.

I added the image size keys. Unless I'm mistaken, this should take care of all the issues.

pooja saraah → made their first commit to this issue’s fork.

@pooja-saraah can you explain why you made these changes? This was a simple big fix. But it looks like you've introduced a bunch of code formatting changes just because. Now the MR is more difficult to review and less likely to be applied. The Drupal community has a long-standing practice of keeping unrelated changes out of patches. Unrelated changes are confusing and make it more likely to cause merge conflicts for other pending patches. Unless you were fixing an additional problem with the code, then please do not go around editing existing MRs. Open follow-up issues to make your edits. And if you were fixing something, then please explain what that problem was.

The changes introduced by @pooja-saraah resulted in a WSoD with the following error:

The website encountered an unexpected error. Try again later.

Error: Call to undefined method Drupal\bootstrap\Plugin\Preprocess\FileUploadHelp::getRenderer() in Drupal\bootstrap\Plugin\Preprocess\FileUploadHelp->preprocessVariables() (line 133 of themes/contrib/bootstrap/src/Plugin/Preprocess/FileUploadHelp.php).

@pooja-saraah never responded with an explanation of why their changes were made. So I reverted their changes as being both unnecessary and harmful. As a module maintainer myself, I would remove their credit on this issue for those reasons.

Thanks.

Automatically closed - issue fixed for 2 weeks with no activity.