Account created on 14 August 2013, over 11 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States shelane

It didn't kill my site, so I'm not sure that was the cause for you. However, it does need to be removed since we are no longer supporting Drupal 8.

🇺🇸United States shelane

Thank you for your interest in contributing to the CKEditor Bootstrap Table module. I appreciate your enthusiasm and offers to help.

Typically, I don't grant commit access to individuals who haven't actively participated in the project's issue queue with patches and merge requests (or at least by conducting reviews). After a quick review, I didn't notice any such participation from you regarding the CKEditor Bootstrap Table module.

Additionally, this isn't solely "my project." I became a co-maintainer primarily to facilitate the D10 port.

I plan to dedicate some time to work on D11 releases in the coming weeks. Your assistance with thorough reviews and marking issues as RTBC (Reviewed and Tested by the Community) where appropriate would be greatly appreciated. This would not only expedite the D11 compatible releases but also help me feel more confident in adding new committers.

Thank you once again!

Best regards.

🇺🇸United States shelane

This cannot be fixed by the maintainers of this theme as none of us own the site.

🇺🇸United States shelane

If we do this, it will only be for the current Drupal versions.

🇺🇸United States shelane

Wait, what? ... Who decided this on such a large project without a readable user discussion?

The original creator and maintainer of the Bootstrap theme stopped doing Drupal several years ago. There is no one who was part of the original decision making of the architecture of this theme around to make decisions going forward. For those of us who picked up the mantel on it, it was to help keeping it working for those that relied on it and needed it to be updated for the major versions of Drupal.

There was no plan to make this theme compatible with Bootstrap 5 and the effort would have been significant. Anyone at any time could have offered to come in and help upgrade it. No one came to make this theme upgraded to Bootstrap 5 with the same architecture that it had. Also, Drupal now has SDC, which didn't exist at the time these theme was created or when the original maintainer was around.

So, those of us who have been maintaining this theme were approached by the maintainer of Bootstrap Barrio. Since it was the other Bootstrap theme with the most number of users. He suggested combined forces to offer this theme with a Bootstrap 5 version from Bootstrap Barrio. We agreed. No user discussion is necessary because the users cannot make the decisions for the maintainers on how to move forward when it wasn't going to move forward at all.

🇺🇸United States shelane

It may be a little while (a couple of weeks or so) until I do a release as I'm trying to address more issues as time permits.

🇺🇸United States shelane

Without more information, I cannot reproduce the issue. Reopen if you want to post this information.

🇺🇸United States shelane

There is one issue with the UI that the other modules fix that until this point I have not figured out. However, now looking at their examples, I should be able to update this module to do the same. And that is #3124896: Allow weights for social media items .

🇺🇸United States shelane

It seems that this request should be for overriding on a per-node basis. Is that correct? Or are you looking to override all shared links to a single URL? That seems a little contrary to the point of the sharing module.

I have recently merged a submitted MR for making a sub-module that allows overrides for sharing on a per-node basis. I can see having an override URL option as part of that.

🇺🇸United States shelane

Also, what theme are you using? What version of Bootstrap are you using?

🇺🇸United States shelane

I checked in the 5.5.0-rc3 release and the dev release (only one additional commit).

The stack trace doesn't say anything about the views bootstrap module. It looks like it has something to do with the Views Reference Field module.

🇺🇸United States shelane

I am able to see the settings form both when editing an existing view and creating a new view.

🇺🇸United States shelane

Please submit an MR so it can be compared and tested.

🇺🇸United States shelane

shelane made their first commit to this issue’s fork.

🇺🇸United States shelane

shelane made their first commit to this issue’s fork.

🇺🇸United States shelane

It's clear by the commit logs that Better Social Share is the newest. The philosophy behind Better Social Sharing Buttons and AddToAny are very different. Better Social Sharing Buttons makes use of direct calls to the social media's own sharing URLs and does not collect or send any of the users data to any other service.

🇺🇸United States shelane

My apologies. This has been addressed in dev. It would be great if a release was put out that includes this.

🇺🇸United States shelane

shelane made their first commit to this issue’s fork.

🇺🇸United States shelane

Which Bootstrap theme are you using? Is there a setting in the theme for making the images responsive?

🇺🇸United States shelane

The Social Media Links Block and Field module is different functionality from this module because it is for placing links to your (the web site's) social networks.

The purpose of this module is to allow content (e.g., a node) to be shared on a visitor's own social media sites. However, the the web site owner can still choice which social media networks to provide the functionality for.

I'm not sure why the maintainer of "Better Social Sharing" felt the need to create a brand new module instead of reaching out to perhaps collaborate with this module. I was not aware of its existence until you posted this.

The AddtoAny, ShareThis, etc type modules allow those companies to collect data on your users. Well, that opens up a can of worms to for GDPR compliance or new laws for privacy in some US states, such as California.

🇺🇸United States shelane

This module assumes that you are already using a Bootstrap theme and would already have the Bootstrap library. I'm not sure why you would want to use the Bootstrap styles for a view without a Bootstrap theme.

The module will not provide a mechanism to attach the Bootstrap library files. However, if you really want to, you can copy the templates to your theme, create a Bootstrap library and attach them through the templates. These does leave the possibility that you will not get any template updates if the module is updated. And I would not recommend doing that.

🇺🇸United States shelane

The grid was working as it was. It correctly had col-val for the class. The carousel breakpoint class was incorrectly putting the xs. I updated the code with the forms, preprocess functions, schema, template, etc.

Thanks.

🇺🇸United States shelane

I was just looking at that. There are two functions in the ViewsBootstrap utility class that are not used anywhere. There is getColSize, which was used (or is used) in the 8.x-3.x branch. Then there is getColumnPrefix.

  public static function getColumnPrefix($breakpoint) {
    return 'col' . ($breakpoint != 'xs' ? '-' . $breakpoint : '');
  }

It seems even when it was added, it wasn't actually called anywhere. However, this may be useful in this situation.

🇺🇸United States shelane

I just had to remove the latest patch from my site because it caused a previously working view to return no results.

🇺🇸United States shelane

shelane made their first commit to this issue’s fork.

🇺🇸United States shelane

Looks like there is a bit more wrong with the use of columns. It's intended that if you have 2 columns, the content should appear side by side in a single carousel. I'm not seeing that either before or after this MR.

🇺🇸United States shelane

shelane made their first commit to this issue’s fork.

🇺🇸United States shelane

shelane made their first commit to this issue’s fork.

🇺🇸United States shelane

Thanks for that check. I believe I addressed all of this issues in the new MR.

I can confirm here that the custom row wrapper class is set and remembered.

🇺🇸United States shelane

I have updated the documentation, which also includes pointing to the Bootstrap documentation on additional classes that can be added. Of course, you're not limited to Bootstrap classes. Add your own theme classes as needed to the various class field options.

🇺🇸United States shelane

I have made the code changes that I had in this MR in the related issue. There is now a new release. As I said, since I can't recreate the error described, I'm not sure if this fixed it or not. Let me know. If it does not, the more information you can provide me on how to recreate it, the better.

🇺🇸United States shelane

Added additional screenshots and notes on optional classes.

🇺🇸United States shelane

I wish that I could readily recreate this issue. I made some minor changes but since I can't recreate the problem, I can't confirm this fixes anything.

🇺🇸United States shelane

This was a bigger can of worms than I expected. It turns out that though it was applying the "card-group" class, the added row and col divs caused it not behave as a card group. I have now added the option to have card groups or not have card groups. When not using card groups, the row and col divs can now have custom classes added.

🇺🇸United States shelane

shelane made their first commit to this issue’s fork.

🇺🇸United States shelane

It will be part of an upcoming release. I have a few other tasks to finish before I make that release. You can use the dev version that includes the updates if you'd like.

composer require 'drupal/views_bootstrap:5.5.x-dev@dev'

🇺🇸United States shelane

shelane made their first commit to this issue’s fork.

🇺🇸United States shelane

Use the patch if you would like, but for the same reason I posted previously, it’s not something I’m going to add.

🇺🇸United States shelane

@tylertech-lee-hazlett, there is also the Block Tabs module that will allow you create tabs with different defined content inside the tab content.

🇺🇸United States shelane

I installed the Bootstrap5 theme (previously used Barrio for testing) and it worked fine with a similar setup. I don't use Layout Builder, so I'm not sure how I would set that up to test to see if that's associated.

Do you see this happening on any type other than grid?

Out of curiosity, have you tried default responsive grid option? I think it works great and even with Bootstrap, it's my preferred grid.

🇺🇸United States shelane

Can you post a screenshot of your views settings for me?

🇺🇸United States shelane

That is well beyond the scope of what I want to do. That is mixing styles. I'm not even sure that's possible. That's where you'd have to use a module like Views Field View where you're building the views with the styles that you will include as content in the "outer" view.

🇺🇸United States shelane

In a perfect world, that would be possible. However, there are many differences between the versions that make mapping difficult. Thumbnails to cards is not a 1:1. In fact, there are a lot of options not available. I'm trying to make it as smooth as possible, but there will be differences that I cannot account for. This is a major version difference both with Bootstrap and with this module. Some non-backwards compatible breaks are expected.

There is also the issue of some people who will be jumping from 3.x to 5.x and some from 4.x to 5.x.

I've done the mapping between versions and highlighted where there missing options between versions:

https://docs.google.com/spreadsheets/d/1iddlJ6_ebwnUmoFYvCNjm1xJExiq9FoW...

🇺🇸United States shelane

I removed that section as it was duplicating information already on the project page. Each Bootstrap version is listed with what project version should be used.

Bootstrap 3

Use 8.x-3.x/5.3.x

Bootstrap 4

Use 8.x-4.x/5.4.x

Bootstrap 5

Use 5.5.x

🇺🇸United States shelane

If you are able to edit the view and save new options, you shouldn’t see that message the next time you load the view edit screen. If you do, be sure to clear the cache.

I’m not sure what would need to be changed exactly in an update hook. The update hooks from this fix include what I found to map over. If you think there are more that need to be mapped for an update hook let me know. At least this gets you to a state where you can edit and make the changes that work for your requirements.

Production build 0.71.5 2024