Account created on 14 August 2013, almost 11 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States shelane

shelane made their first commit to this issue’s fork.

🇺🇸United States shelane

Full release coming soon. I'm checking other issues to see if there is anything else that should go in the release.

🇺🇸United States shelane

shelane made their first commit to this issue’s fork.

🇺🇸United States shelane

shelane made their first commit to this issue’s fork.

🇺🇸United States shelane

Hi, as we continue to move forward with this project and an upcoming full release of a version supporting Bootstrap 5, I would just like to be sure I have the ability when needed to update the default branch in GitLab as needed. D.o has been working to get more actions in GitLab as well. I am fully committed to this project and supporting it.

🇺🇸United States shelane

The link I provided when I contacted the maintainers was to the project itself, not to this issue.

🇺🇸United States shelane

Returning to project ownership as it has been two weeks now.

🇺🇸United States shelane

shelane made their first commit to this issue’s fork.

🇺🇸United States shelane

I'm not at all sure how this MR shows that it's mergeable because these changes were made in 📌 Attempt to fix lint issues Fixed .

🇺🇸United States shelane

This needs a reroll due to changes for linting style requirements that we’re made in dev.

🇺🇸United States shelane

The patch does not apply against 3.2.2 (Could not apply patch! Skipping. The error was: Cannot apply patch ./patches/group.patch) and I'm unable to update to the dev of 3.3.x because of this:

Your requirements could not be resolved to an installable set of packages.

Problem 1
- drupal/group dev-3.3.x requires drupal/core ^10.3 -> found drupal/core[10.3.0-beta1, 10.3.x-dev, 10.4.x-dev] but these were not loaded, likely because it conflicts with another require.

🇺🇸United States shelane

I saw that the first time that I switched the formatter. I was still able to save it with either option. When I clicked on the field setting again, it was no longer set in red and showed the correct separator.

What version of Drupal are you on?

🇺🇸United States shelane

shelane made their first commit to this issue’s fork.

🇺🇸United States shelane

I have not been able to reproduce this. See the attached screen capture movie.

I'm on Drupal 10.2.6 with the latest 2.0.0 version.

🇺🇸United States shelane

I would love to test this, but I want to make sure I'm doing to right path for testing. Let me know if I'm on track here.

  1. Update my local dev environment for a site using Group 2.2.2 with the latest dev version of 3.3.x.
  2. Download plain diff to apply patch with composer
  3. Run drush updb
  4. Test various users and group content actions
🇺🇸United States shelane

shelane made their first commit to this issue’s fork.

🇺🇸United States shelane

shelane created an issue.

🇺🇸United States shelane

shelane made their first commit to this issue’s fork.

🇺🇸United States shelane

This is not the same implementation that exists for the Bootstrap 5 version. I really don't want to add a third custom class option. The change made for this version is the parent of the row. For the Bootstrap 5 version, the custom class is applied directly to the row class. There are many means of achieving this goal. So, as far as this request is concerned, it is done as requested. The Bootstrap 5 version, you will have to use other means of applying to a parent row.

🇺🇸United States shelane

shelane changed the visibility of the branch 3024039-carousel-item-wrapper to hidden.

🇺🇸United States shelane

Thanks everyone. Though I only currently have a beta out there, I'm feeling pretty good about the recent updates. I'm going to let it sit in beta for a while to see if any other issues pop up, but I will close this issue out.

🇺🇸United States shelane

If you update to the latest version of 5.5.0, you will find options for adding custom classes. You can add Bootstrap classes or your own. There is also help text with a link to more documentation in each settings panel.

🇺🇸United States shelane

The beta4 is working correctly according to labels of the fields. Please check your settings.

🇺🇸United States shelane

You shouldn't have to add a space to it. But by saving it, it should be saved as an empty string rather than a NULL value (not yet existing in the config).

🇺🇸United States shelane

Once an empty string is set (rather than NULL) in the view options, these errors will not occur. This is going to be handled through an update hook in the next release. You can manually edit your view and save the settings to fix this as well.

🇺🇸United States shelane

Never mind. These options are provided by the inherited core table. Geez, I need some caffeine today.

🇺🇸United States shelane

shelane made their first commit to this issue’s fork.

🇺🇸United States shelane

If you are seeing this error after update to 5.5.0-beta, see related issue 🐛 5.5.0-beta1 DivisionByZeroError: Modulo by zero Closed: works as designed and comments.

🇺🇸United States shelane

The 5.4 branch and 5.5 branch are separate branches supporting different versions of Bootstrap. Even if this is fixed for 5.5 doesn't mean it's fixed for 5.4. @aburrows has been supporting the 5.4 branch, but if he's not available, I can take a look in a couple of weeks.

🇺🇸United States shelane

This is the documentation for the Bootstrap grid. I don’t see that option. But, you can use the core responsive grid style regardless of what theme you’re using.

🇺🇸United States shelane

It was the preprocessing that was wrong.

🇺🇸United States shelane

You're right. Looks like the changes I made to the template were incorrect. Fix coming shortly...

🇺🇸United States shelane

Is it still an issue in the 5.4 branch though? That is for users of Bootstrap 4 and is still an active version.

🇺🇸United States shelane

The list group issue was taken care of in another issue.

🇺🇸United States shelane

Are you using list group or are you getting errors stating list group for views using cards?

🇺🇸United States shelane

After upgrading, did you edit the view style settings and save it first, or did you go to the page the view is on first? If you did not edit and save, try that. If you still get the error, let me know.

🇺🇸United States shelane

A new beta version and all new documentation have been released for Bootstrap 5. Please read release notes for updating.

🇺🇸United States shelane

Page status change after review.

🇺🇸United States shelane

Adds final two options.

🇺🇸United States shelane

I missed some schema pieces and a few clean up items.

🇺🇸United States shelane

shelane changed the visibility of the branch 3324207-grid-row-class to active.

🇺🇸United States shelane

shelane changed the visibility of the branch 3324207-grid-row-class to hidden.

🇺🇸United States shelane

This is close, but not quite the implementation that I do for other items. I will finish this up and get it merged. Thanks for your contribution.

🇺🇸United States shelane

I see. Currently the code is using the base style where "row" actually means each "record" that is returned. I'll update to not use the base class but define a custom class.

🇺🇸United States shelane

Can you please explain further how you are setting this? I took a look at the code and it is using the default views implementation for the row class. There is no code for that provided in this module.

🇺🇸United States shelane

This will be fixed in the next version for Bootstrap 5. See related issue.

🇺🇸United States shelane

FYI, I am currently doing a deeper dive on tabs and this particular implementation will not be the final.

🇺🇸United States shelane

I updated a branch with code that contains the options that were in the 3 branch plus the new ones. I have yet to test it with content yet. I'll do that next week.

Production build 0.69.0 2024