🇺🇸United States @shelane

Also, what theme are you using? What version of Bootstrap are you using?

I checked in the 5.5.0-rc3 release and the dev release (only one additional commit).

The stack trace doesn't say anything about the views bootstrap module. It looks like it has something to do with the Views Reference Field module.

I am able to see the settings form both when editing an existing view and creating a new view.

Please submit an MR so it can be compared and tested.

shelane → made their first commit to this issue’s fork.

Thanks.

Thank you.

shelane → made their first commit to this issue’s fork.

shelane → made their first commit to this issue’s fork.

smustgrave → credited shelane → .

I have no objection.

Thanks.

shelane → created an issue.

It's clear by the commit logs that Better Social Share is the newest. The philosophy behind Better Social Sharing Buttons and AddToAny are very different. Better Social Sharing Buttons makes use of direct calls to the social media's own sharing URLs and does not collect or send any of the users data to any other service.

I agree. Can someone create an MR for this?

My apologies. This has been addressed in dev. It would be great if a release was put out that includes this.

shelane → created an issue.

Thanks.

shelane → made their first commit to this issue’s fork.

Which Bootstrap theme are you using? Is there a setting in the theme for making the images responsive?

The Social Media Links Block and Field module is different functionality from this module because it is for placing links to your (the web site's) social networks.

The purpose of this module is to allow content (e.g., a node) to be shared on a visitor's own social media sites. However, the the web site owner can still choice which social media networks to provide the functionality for.

I'm not sure why the maintainer of "Better Social Sharing" felt the need to create a brand new module instead of reaching out to perhaps collaborate with this module. I was not aware of its existence until you posted this.

The AddtoAny, ShareThis, etc type modules allow those companies to collect data on your users. Well, that opens up a can of worms to for GDPR compliance or new laws for privacy in some US states, such as California.

Does this mean that I can mark this as fixed?

This module assumes that you are already using a Bootstrap theme and would already have the Bootstrap library. I'm not sure why you would want to use the Bootstrap styles for a view without a Bootstrap theme.

The module will not provide a mechanism to attach the Bootstrap library files. However, if you really want to, you can copy the templates to your theme, create a Bootstrap library and attach them through the templates. These does leave the possibility that you will not get any template updates if the module is updated. And I would not recommend doing that.

The grid was working as it was. It correctly had col-val for the class. The carousel breakpoint class was incorrectly putting the xs. I updated the code with the forms, preprocess functions, schema, template, etc.

Thanks.

I was just looking at that. There are two functions in the ViewsBootstrap utility class that are not used anywhere. There is getColSize, which was used (or is used) in the 8.x-3.x branch. Then there is getColumnPrefix.

  public static function getColumnPrefix($breakpoint) {
    return 'col' . ($breakpoint != 'xs' ? '-' . $breakpoint : '');
  }

It seems even when it was added, it wasn't actually called anywhere. However, this may be useful in this situation.

shelane → created an issue.

Thanks

I just had to remove the latest patch from my site because it caused a previously working view to return no results.

Thanks.

shelane → made their first commit to this issue’s fork.

Looks like there is a bit more wrong with the use of columns. It's intended that if you have 2 columns, the content should appear side by side in a single carousel. I'm not seeing that either before or after this MR.

shelane → made their first commit to this issue’s fork.

Thanks.

shelane → made their first commit to this issue’s fork.

Thanks for that check. I believe I addressed all of this issues in the new MR.

I can confirm here that the custom row wrapper class is set and remembered.

I have updated the documentation, which also includes pointing to the Bootstrap documentation on additional classes that can be added. Of course, you're not limited to Bootstrap classes. Add your own theme classes as needed to the various class field options.

I have made the code changes that I had in this MR in the related issue. There is now a new release. As I said, since I can't recreate the error described, I'm not sure if this fixed it or not. Let me know. If it does not, the more information you can provide me on how to recreate it, the better.

Added additional screenshots and notes on optional classes.

shelane → created an issue.

I wish that I could readily recreate this issue. I made some minor changes but since I can't recreate the problem, I can't confirm this fixes anything.

This was a bigger can of worms than I expected. It turns out that though it was applying the "card-group" class, the added row and col divs caused it not behave as a card group. I have now added the option to have card groups or not have card groups. When not using card groups, the row and col divs can now have custom classes added.

shelane → made their first commit to this issue’s fork.

It will be part of an upcoming release. I have a few other tasks to finish before I make that release. You can use the dev version that includes the updates if you'd like.

composer require 'drupal/views_bootstrap:5.5.x-dev@dev'

shelane → made their first commit to this issue’s fork.

shelane → created an issue.

shelane → created an issue.

tonypaulbarker → credited shelane → .

Use the patch if you would like, but for the same reason I posted previously, it’s not something I’m going to add.

@tylertech-lee-hazlett, there is also the Block Tabs → module that will allow you create tabs with different defined content inside the tab content.

I installed the Bootstrap5 theme (previously used Barrio for testing) and it worked fine with a similar setup. I don't use Layout Builder, so I'm not sure how I would set that up to test to see if that's associated.

Do you see this happening on any type other than grid?

Out of curiosity, have you tried default responsive grid option? I think it works great and even with Bootstrap, it's my preferred grid.

Can you post a screenshot of your views settings for me?

That is well beyond the scope of what I want to do. That is mixing styles. I'm not even sure that's possible. That's where you'd have to use a module like Views Field View → where you're building the views with the styles that you will include as content in the "outer" view.

In a perfect world, that would be possible. However, there are many differences between the versions that make mapping difficult. Thumbnails to cards is not a 1:1. In fact, there are a lot of options not available. I'm trying to make it as smooth as possible, but there will be differences that I cannot account for. This is a major version difference both with Bootstrap and with this module. Some non-backwards compatible breaks are expected.

There is also the issue of some people who will be jumping from 3.x to 5.x and some from 4.x to 5.x.

I've done the mapping between versions and highlighted where there missing options between versions:

https://docs.google.com/spreadsheets/d/1iddlJ6_ebwnUmoFYvCNjm1xJExiq9FoW...

I removed that section as it was duplicating information already on the project page. Each Bootstrap version is listed with what project version should be used.

Bootstrap 3

Use 8.x-3.x/5.3.x

Bootstrap 4

Use 8.x-4.x/5.4.x

Bootstrap 5

Use 5.5.x

If you are able to edit the view and save new options, you shouldn’t see that message the next time you load the view edit screen. If you do, be sure to clear the cache.

I’m not sure what would need to be changed exactly in an update hook. The update hooks from this fix include what I found to map over. If you think there are more that need to be mapped for an update hook let me know. At least this gets you to a state where you can edit and make the changes that work for your requirements.

shelane → created an issue.

The bug is actually in core and not in the theme.

https://drupal.stackexchange.com/questions/278774/theme-css-libraries-al...

This where I got my solution from.

shelane → created an issue.

shelane → made their first commit to this issue’s fork.

Interesting. I still haven't been able to recreate the issue. Looking right at the Drupal core views module and their views.theme.inc file uses the new Attribute method. For instance:

  foreach ($variables['rows'] as $num => $row) {
    $variables['rows'][$num]['attributes'] = [];
    if ($row_class = $handler->getRowClass($num)) {
      $variables['rows'][$num]['attributes']['class'][] = $row_class;
    }
    $variables['rows'][$num]['attributes'] = new Attribute($variables['rows'][$num]['attributes']);
  }

  if (empty($variables['rows']) && !empty($options['empty_table'])) {
    $build = $view->display_handler->renderArea('empty');
    $variables['rows'][0]['columns'][0]['content'][0]['field_output'] = $build;
    $variables['rows'][0]['attributes'] = new Attribute(['class' => ['odd']]);
    // Calculate the amounts of rows with output.
    $variables['rows'][0]['columns'][0]['attributes'] = new Attribute([
      'colspan' => count($variables['header']),
      'class' => ['views-empty'],
    ]);
  }

I also see it in the 9.5.x branch code base.

In order to move my css to a different weight, I used hook_css_alter. In my case, I needed my custom modules to be able to override previous css.

/**
 * Implements hook_css_alter().
 *
 * @inheritdoc
 */
function sienna_css_alter(array &$css) {
  $base = [
    'themes/custom/sienna/css/3.4.1/bootstrap.css',
    'themes/custom/sienna/css/all.min.css',
    'themes/custom/sienna/css/style.css',
    'themes/custom/sienna/css/paragraphs.css',
    'themes/custom/sienna/css/hero_banner.css',
    'themes/custom/sienna/css/news_article.css',
    'themes/custom/sienna/css/ckeditor.css',
  ];

  foreach ($base as $lib_css) {
    if (isset($css[$lib_css])) {
      $css[$lib_css]['group'] = CSS_COMPONENT;
      $css[$lib_css]['weight'] = -5;
    }
  }
}

The 5.3.x, 5.4.x, and 5.5.x branches support different versions of Bootstrap. This issue was rightly assigned to the 5.4.x branch because there is no content option in that version. The changes proposed may be valid for 5.5.x and additionally 5.4.x, but a separate issue should be made for it so that work for the 5.4.x branch can continue to be tracked.

shelane → created an issue.

Can you give me more info on steps to reproduce this issue? What style did you have it set to? What are the options? What is the data type in the view?

shelane → made their first commit to this issue’s fork.

I reverted the code due to concerns raised about the changes to the ConfigFormBase construct for Drupal 11. Implementing these changes would necessitate setting the minimum version to 10.2 to ensure compatibility with Drupal 11. To address this, I created a 2.x branch and updated the code to support both Drupal 10.2 and 11 in a 2.0.0 release.

By reverting the changes in the 1.x branch, we can maintain support for Drupal 9 and 10, allowing for future updates without compromising compatibility.

Bootstrap 4 dropped thumbnails and it was replaced by cards. This was a design change by Bootstrap. The wrapping code is very similar, but cards are more flexible and responsive. We do not plan on adding thumbnails to the 4.x or 5.5 version.

Actually, the project page has stated for a while which version should be used for which version of Bootstrap. Understandable that you prefer a stable version. That will be coming soon.