🇺🇸United States @shelane

I understand your point, but they don't all have the same pattern. The structure of email and print, for instance, is different. Also, some attach libraries in the template.

greggles → credited shelane → .

@thomas.frobieter: thanks

@delphine947: that is an entirely different issue. Please open a new issue and include screenshots of your configuration and the output.

shelane → made their first commit to this issue’s fork.

shelane → made their first commit to this issue’s fork.

I believe this was fixed in 🐛 Null title when indexing rendered content Fixed .

I have fixed this issue for adding weights so that users will be able to set the order of the social services buttons. This will be coming in a 5.0 release soon.

That is interesting as I don't see any attempt from this module to preload the svg.

The default colors for the social networks come from the companies directly, so I don't want to change the default.

I was trying to find an example module where there is configuration for a fill. SVG is not something I have a lot of experience with, so I would need something to base it on.

Per @mandclu's suggestion, the variables now contain a prefix of "bss-" so you have var(--bss-color1) through var(-bss-color14). With this change, you can add the colors you would like in your css file:
:root {
--bss-color1: #2b6a94;
--bss-color2: #fff;
--bss-color3: #cddc39;
--bss-color4: #f60;
--bss-color5: #489951;
--bss-color6: #3a559f;
--bss-color7: #0076b2;
--bss-color8: #0084ff;
--bss-color9: #bd081c;
--bss-color10: #157efb;
--bss-color11: #ff4500;
--bss-color13: #3b445c;
--bss-color14: #000;
--bss-color15: #25d366;
}

I've added this to the README file that will be released with version 5.0.

The work that I needed to do on the other issues is now complete in the new 5.x branch. I did make changes to the config form and the block form, which will affect this MR.

I have a refactoring of the templates, but it's not by what you suggest. I'm not sure what you are calling for exactly. So, if there is something you would like to see, please submit an MR.

shelane → made their first commit to this issue’s fork.

Wouldn't that be true for most things on a site if CSS is turned off?

I'm concerned with the defined max-widths and some people may be able to go beyond that given their design. I would think we should be able to do it in a way where the module doesn't define the max width but that it should properly wrap within its container instead of extending beyond that.

I'm open to adding it if someone wants to provide the MR with the needed changes. I will not be able to test.

Two issues to address with this MR:

1. There have been other changes to the templates since this was proposed, so it needs to be re-rolled
2. The diff shows everything has changed, so it's extremely hard to evaluate the differences

Not all of them do have padding. I did add a bit, but the reedit example is appears pretty extreme in comparison because that is the design of their logo.

Thanks.

Thanks.

shelane → made their first commit to this issue’s fork.

It looks like you have custom templating. The class name was changed to meet coding standards. You need to change btnCopy to btn-copy in your template.

This must come from a rule other than AP style. In fact, using an ndash is not even part of the AP style standard, but I believe that it was included at user request as an option. Can you provide any sources on why spaces should not be included?

shelane → made their first commit to this issue’s fork.

Thanks.

Thanks.

shelane → made their first commit to this issue’s fork.

I see this sometimes in version 4.1.0 and it only happens with some emails. When I view the newsletter on the website, the URL to the image is correct. When it appears to be missing in the email, it is because the image has an extra . after the image name like:
Scripps..jpeg?itok=sO8bNiHV

I don't know why this happens for some images and not all images if this is a programmatic problem.

The before and after listed above are not equivalent. The actual file_validate function processes the errors from the service and returns an array. So, if that's the data you were expecting, you will now get errors related to the returned data. So the after really needs to look like this to be equivalent:

$validators = ['FileNameLength' => []];
/** @var \Drupal\file\Validation\FileValidatorInterface $file_validator */
$file_validator = \Drupal::service('file.validator');
/** @var \Symfony\Component\Validator\ConstraintViolationListInterface $violations */
$violations = $file_validator->validate($file, $validators);

$errors = [];
foreach ($violations as $violation) {
  $errors[] = $violation->getMessage();
}

Thanks

This module is specifically for a Bootstrap theme and is not intended for non-Bootstrap themes. I do not have any suggestions as I do not know what modules may be available for a tabs views style.

I have not been able to repeat this as of late. Thank you for your time.

In light of the other script and changes I made to it to remove jQuery, try this using the dev branch:

(function () {

  'use strict';

  /**
   * Attaches the behavior to the user's custom carousel functionality.
   */
  Drupal.behaviors.bsCarousel = {
    attach: function (context, settings) {
      // Select the specific carousel element
      const carousel = document.querySelector('#views-bootstrap-home-slider-block-1');

      if (carousel) {
        // Ensure the carousel has more than one slide
        const slides = carousel.querySelectorAll('.carousel-inner > div');
        if (slides.length > 1) {
          // Attach the event listener for the 'slid.bs.carousel' event
          carousel.addEventListener('slid.bs.carousel', function () {
            console.log('CAROUSEL HAS SLID');
          });
        } else {
          console.log('Carousel has only one slide, event listener not attached.');
        }
      }
    }
  };

}());

shelane → created an issue.

I just saw that there is some javascript in the module related to the carousels. I'm going to update it to remove its dependence on jQuery and see what else it may be doing to interfere.

kwiseman: this may be related and I would appreciate an MR for the fix you found.

The problem is that allowing all of the tags from xss::getAdminTagList() in accordion and tags would break the required structure for these Bootstrap components. The list is limited for the accordion collapse element, but not the accordion body and for the tab, but not the tab-pane area.

It was indeed the case that the "responsive" variable is not getting read. It is likely due to a conflict with the views table processor. However, the proposed solution put the hard-coded style unnecessarily. With the variable changed in the preprocessor and the template, the class is added, and that class has that style setting. I appreciate the efforts though.

shelane → created an issue.

Thank you.

shelane → made their first commit to this issue’s fork.

That is interesting. I'll see what I will need to do for that workflow. In the meantime, leave it at "Unformatted List" on that screen and then set up the format and settings on the next page.

I'm hoping to get to this at DrupalCon.

You only have to click on the star to follow to get notifications of changes.

Can you try:

Drupal.behaviors.bsCarousel = {
  attach: function (context, settings) {
    $(once('bs-carousel', '#views-bootstrap-home-slider-block-1', context)).each(function () {
      // Ensure the carousel element exists
      $(this).on('slid.bs.carousel', function () {
        console.log('CAROUSEL HAS SLID'); // This should now work
      });
    });
  }
};

This module only provides the style processing for view data. All of the JavaScript for Bootstrap carousel behavior should be provided by the theme.

Interesting question. I don't know. If you know of a views style module that does this, let me know and I'll see what they're doing for that.

Since I have merged two other issues, there is now a conflict on this branch.

shelane → made their first commit to this issue’s fork.

I have some work to do on
✨ Allow weights for social media items Active
✨ Refactor the share buttons template Active

That may impact this request and I'd like to get those done first.

With testing I found that that the visual display no longer works with the proposed changes. See attached screen captures.

shelane → made their first commit to this issue’s fork.

Sorry, I have been out sick. At this time I do not want to add additional maintainers. I will continue to respond to feature and merge requests and if there is a feature that you would like to see in this module, please make an issue. I credit all who contribute ideas and code to the module.

I see that you have interacted with Joseph in the Bootstrap theme issues. Considering that this module is not providing any of the javascript, I was going to recommend checking there.

He created the jQuery Downgrade module → and also noted the release notes → .

It didn't kill my site, so I'm not sure that was the cause for you. However, it does need to be removed since we are no longer supporting Drupal 8.

shelane → made their first commit to this issue’s fork.

Thank you for your interest in contributing to the CKEditor Bootstrap Table module. I appreciate your enthusiasm and offers to help.

Typically, I don't grant commit access to individuals who haven't actively participated in the project's issue queue with patches and merge requests (or at least by conducting reviews). After a quick review, I didn't notice any such participation from you regarding the CKEditor Bootstrap Table module.

Additionally, this isn't solely "my project." I became a co-maintainer primarily to facilitate the D10 port.

I plan to dedicate some time to work on D11 releases in the coming weeks. Your assistance with thorough reviews and marking issues as RTBC (Reviewed and Tested by the Community) where appropriate would be greatly appreciated. This would not only expedite the D11 compatible releases but also help me feel more confident in adding new committers.

Thank you once again!

Best regards.

shelane → made their first commit to this issue’s fork.

This cannot be fixed by the maintainers of this theme as none of us own the site.

If we do this, it will only be for the current Drupal versions.

Wait, what? ... Who decided this on such a large project without a readable user discussion?

The original creator and maintainer of the Bootstrap theme stopped doing Drupal several years ago. There is no one who was part of the original decision making of the architecture of this theme around to make decisions going forward. For those of us who picked up the mantel on it, it was to help keeping it working for those that relied on it and needed it to be updated for the major versions of Drupal.

There was no plan to make this theme compatible with Bootstrap 5 and the effort would have been significant. Anyone at any time could have offered to come in and help upgrade it. No one came to make this theme upgraded to Bootstrap 5 with the same architecture that it had. Also, Drupal now has SDC, which didn't exist at the time these theme was created or when the original maintainer was around.

So, those of us who have been maintaining this theme were approached by the maintainer of Bootstrap Barrio. Since it was the other Bootstrap theme with the most number of users. He suggested combined forces to offer this theme with a Bootstrap 5 version from Bootstrap Barrio. We agreed. No user discussion is necessary because the users cannot make the decisions for the maintainers on how to move forward when it wasn't going to move forward at all.

It may be a little while (a couple of weeks or so) until I do a release as I'm trying to address more issues as time permits.

Without more information, I cannot reproduce the issue. Reopen if you want to post this information.

There is one issue with the UI that the other modules fix that until this point I have not figured out. However, now looking at their examples, I should be able to update this module to do the same. And that is ✨ Allow weights for social media items Active .

It seems that this request should be for overriding on a per-node basis. Is that correct? Or are you looking to override all shared links to a single URL? That seems a little contrary to the point of the sharing module.

I have recently merged a submitted MR for making a sub-module that allows overrides for sharing on a per-node basis. I can see having an override URL option as part of that.

shelane → made their first commit to this issue’s fork.

Also, what theme are you using? What version of Bootstrap are you using?

I checked in the 5.5.0-rc3 release and the dev release (only one additional commit).

The stack trace doesn't say anything about the views bootstrap module. It looks like it has something to do with the Views Reference Field module.

I am able to see the settings form both when editing an existing view and creating a new view.

Please submit an MR so it can be compared and tested.

shelane → made their first commit to this issue’s fork.

Thanks.

Thank you.

shelane → made their first commit to this issue’s fork.