Change the misleading and unclear wording in Pager -> Link display

Slightly reviewing very old tickets as part of needs-review-queue-initiative

This still appears to be the case and agree "Link display" is slightly off.

Probably a good task for new users.

Completed the text change as suggested. Please review the PR https://git.drupalcode.org/project/drupal/-/merge_requests/6282.

Hi @Drupaler_Kushal, I've Tested the shared MR- MR !6282 mergeable on the Drupal- 11.0-dev version, The Patch was applied successfully and looks good to me.

Testing Steps:

• Install Drupal- 11.0.
• Go to> admin/structure/view-
• Create/edit view- Scroll down the Pager section to view the label, Attached before results
• Download the shared patch & apply.
• Create/edit view- Scroll down the Pager section to re-verify this.

Testing Results:
After applying the patch, the text label is changed now. RTBC++

Attaching Test results here

Was tagged for issue summary and tests.

Issue Summary:
Problem/Motivation:
The current option summary for 'Link display' in the DisplayPluginBase class is unclear and can lead to confusion. This issue aims to improve clarity by updating the option summary text to 'Destination.'
Steps to Reproduce:
* Navigate to a Views configuration page.
* Observe the 'Link display' option in the pager category.
Proposed Solution:
Update the title of the 'link_display' option from:
'title' => $this->t('Link display'),
to:
'title' => $this->t('Destination'),
This change provides a more descriptive and understandable label for the option.

Test Plan:
* Before applying the patch:
* Verify that the option summary for 'Link display' is present on a Views configuration page.
* Confirm that the text is currently set to 'Link display.'
* Apply the Patch:
* Apply the provided patch to update the 'Link display' text to 'Destination.'
* Confirm that the patch applies cleanly without conflicts.
* After applying the patch:
* Navigate to a Views configuration page.
* Verify that the 'Link display' text in the option summary is now replaced with 'Destination.'

Issue summaries shouldn’t go in a comment. And full template should be used.

Test could be as simple as an assertion somewhere

Please read the comments and tags. This was tagged for a simple test which isn’t done.

What is pending now in this?

I've added a simple functional test to validate the changes made to the label.

Please search the Views and Views UI modules (and maybe others?) for 'Link display' and update all occurrences everywhere. Please make sure the changed sentences still make sense, not sure a find/replace is going to work everywhere

Did anybody ever look into moving this out of the pager section? I agree with @dawehner in #1 that this feel like a weird place for this.

Do we need to think about updating the machine name of the setting too? We now have a big difference between the name of the field in code and the name in the UI which can lead to more confusion but now from a DX perspective

Do we need to run the new label past some UI experts and make sure we all agree this is the best we can come up with, 'Destination' feels a bit vague to me.

ITMT, on D11.1, I cannot find the 'Link display' option in the pager setting, or anywhere on the view settings page, whereas #19 states it is still there on D11.0.
(EDIT: That is on a Page display - when checking a Block display, I can see the option. --> Updating summary with test

As suggested in #30, indeed, the term 'Link display' is still used elsewhere, amongst other in the 'more' link setting. These still must be addressed.

As dawehner suggests in #1 "Could we not just add a new group, as the link display really simply not belongs to the pager", the setting may move to a better location (affecting only the UI, not the saved configuration setting itself)
Now is the time!