Content moderations shows the state label instead of transition label on the default ModerationStateWidget

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

added patch against #43 in 10.1 version

@Akhil Yadav,
One test case and attached file is missing from the re-roll.
The patch in #43 has additional test cases and database zip file.

Can you please re-roll again.

Fixed failed commands on #51
Attached patch against Drupal 10.1.x

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Fix custom command failures.

Hiding patches #51 and #54 since they are omitting important changes.

Adding it to the list... #3339883: Employees of Dotsquares are posting mass re-roll patches which are invalid and/or incomplete →

- Doing full re-roll from my patch in #43
- Re-roll diff doesn't contain significant difference due to change in database zip file for testing update.
I had to update the database zip files because there are changes related to theme and bartik theme is removed from core in D10.
- commit-code-check is passing on local.
- Both the test cases are passing on local.
- Hiding few more patches are they are causing noise.

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

git apply failed with whitespace issues but patch -p1 worked just an FYI.

Tried testing patch #59 wasn't super clear that I need to go to my content type to change this setting. So definitely will need a change record.

Selecting transition labels did not update the labels. Cleared cache multiple times.

The patch only supports using the transitions label on the Edit page. This does not work on the Layout form. The Layout builder change is set in content_moderation_entity_form_display_alter() hook but that knows nothing about the setting. The patch will need to be updated to handle the form alter. The following changes the transition but that needs to be pulled from the moderation_labels need to be pulled from the form settings.

  if ($context['form_mode'] === 'layout_builder') {
    $form_display->setComponent('moderation_state', [
      'type' => 'moderation_state_default',
      'weight' => -900,
      'settings' => [
        'moderation_labels' => 'transition', // Get the field setting from form display?  
      ],
    ]);
  }

Alternatively, this could be a setting on each workflow instead of a settings on the field Widget.

Since we are here adding options on the Manage display tab, I would also add the option to only show the moderation state.

This can be useful to remind the author that he might want/need to edit the content, without showing a (imho confusing & bad looking) form on a page display! This should even bring performance improvements, allowing to cache the View page for more users, right?

@kopeboy We try to keep issues as small and self-contained as possible. I suggest creating a new issue.

I've updated the ticket description with what I think are the remaining tasks. Including a new one: Rewrite the tests to not use an .sql.gz file and remove it from the patch.

@dalin #64: Fair. I've put it as a related issue: ✨ Add a moderation state pseudo field on the view mode Active