🇯🇴Jordan @Anas_maw

This will work also

This patch solves the issue

anas_maw → created an issue.

Reroll the patch to the latest dev version

Thanks for the patch, working as expted.

This patch will add the support, you need to add create hook_mail_alter and add $message['sendgrid']['template_id'] and $message['sendgrid']['substitutions']

much easier than extending the whole class

Done

@jannakha, my comment is on this MR https://git.drupalcode.org/issue/commerce_add_to_cart_link-3298965/-/mer...

Thanks, I will review, and waiting for the feedback from community

I agree, here is an updated patch.

This patch will add a new hook_swiper_formatter_settings_alter

anas_maw → created an issue.

We have to find a way to support slidesPerView: auto, as per the documentation https://swiperjs.com/swiper-api#param-slidesPerView

@luksak please check my comment on your MR, it's changing both add to cart link and wishlist link
here is a patch for your MR, as I can't push the fix to your MR

@luksak Thanks, I'm using 2 patches together and they are working nicely together

Can we show the status message printed by commerce or wishlist modules?
When you add a product to the wishlist, there is a default message shown, I think we should just refresh the messages block.

Here is a patch with the fix until you add it to the MR, many thanks

Thanks for this great feature, I was just looking for it, one issue only, cache should be prevented in this case 'max-age' => 0

Committed, thanks

Seems like the config is not setted correctly on install

anas_maw → created an issue.

Please ignore the latest patch, here is the write one

This patch will add the support

anas_maw → created an issue.

This patch should solves the issue

anas_maw → created an issue.

The property is showing as auto-complete, but when filtering it's not giving the right results

@catch I applied the MR #9226, and it's worked fine for fields, but not for entity properties.

Can you add the support for the entity none fields (properties)? like entity owner

Yes, it's related to 4.x, we are on 4.0.3 and we are facing the same issue

Having the same issue

Revamp patch in #33 to work on latest version

@jacksick, thanks merging the patch, could you please give us the fix credit :)

Anas_maw → created an issue.

Thanks for the patches, seems like the patch is no applied via composer because it's a one line, I will commit the change

Anas_maw → created an issue.

Leaving this as opened to receive future patches

Yasser Samman → credited Anas_maw → .

Anas_maw → created an issue.

In 2.0.x branch there is src/PluginForm/HyperPayCopyAndPayForm.php

I am not sure if PayTabs allows payments without collecting the billing info, I will close this issue for now, please reopen in case it's still needed.

Anas_maw → created an issue.

The latest patch added it to src/PluginForm/HyperPayCopyAndPayForm.php and the previous one added it to src/PluginForm/HyperpayForm.php

I think we will need a single patch to add them both, right?

Hello hamzadwaya,
I think your patch still missing the same change to src/PluginForm/HyperPayCopyAndPayForm.php

Also, my concern about this is that for orders with a total amount of 4.123 for example, if you pass 4.12 to Hayperpay, then the order status will not be paid because of 0.003 left, anyway, I think we should commit this, please make sure to fix your patch ASAP.

Thanks

Could you please list the ckeditor_templates_ui module on the module page?

Thanks for moving the issue to ckeditor_module, I'm really sad to see that the owners of ckeditor_module decided to take the features that I did on this module and include them in the ckeditor_module without any notice

@hamzadwaya, all of your changes are committed, except

// HyperPay requires the amount to be formatted with two digits after the decimal point.
'amount' => number_format((float) $payment_amount->getNumber(), 2, '.', ''),

I wrote a comment on the MR, please check it, also let's open a separate ticket for this issue as it's not related to Drupal 10 compatibility

The owners of the ckeditor_templates → module decided to include the features provided by this module in their module, so this module will not be needed when they fixed the mentioned issue.
At the same time, there is a new module ckeditor5_template → which provides the CKEditor 5 feature, we integrated ckeditor_templates_ui module with ckeditor5_template in a separate branch, and this is mentioned on the module page.

Good catch

Anas_maw → created an issue.

Great, Thanks

Great, Thanks

I will close this, feel free to reopen if you can provide us with a patch or MR

Sure, Thanks

This module now support Ckeditor 5 in the 2.x version, it's now depend on CKEditor 5 Template →

Duplicate 🐛 Use of "static" in callables is deprecated Fixed

Works for me too, thanks

CKEditor Templates UI saves the templates in database :)

@dbielke1986, sorry for my late response, we can make enhancements to my module to support all the mentioned above, appreciate it if you could list my module in your project, so people can install it and help me in adding these features, until now 92 sites are using my module with yours without listing it in your project and this number is very good in this stage, which means that people finds it useful, please add it to your project so I can get some help from the community.

Here is an updated patch to work on the latest 2.2

Currently, the UI module disables the path input, adding a link to the configuration is a good idea.
Importing already existing templates can be done, but I'm not sure if it's the correct way, as this may confuse the users, if you list the UI module in your module page, people will install both modules together and they will not need to do the path configuration part from the first.

@dbielke19886 regarding point number 2, our module creates a configuration entity for templates and overrides the path file method, that's why the existing templates will not appear, what do you think?

@Nelo_drup could you please confirm if the 2.x branch is working as expected or not?

@dbielke19886 can you please list what is the problem, I tried it and it's working as expected.

Anas_maw → created an issue.

Good news, I found some time today and implemented the integration with https://www.drupal.org/project/ckeditor5_template → module
Please check the 2.x release

Yes, we can support this new module in a separate branch, appreciate your help in this, as I'm really busy in these days.

#7 solved the issue for me

Anas_maw → created an issue.

Anas_maw → created an issue.

Related issue 📌 Support ckeditor 5? Postponed