🇯🇴Jordan @Anas_maw

Anas_maw → created an issue.

In 2.0.x branch there is src/PluginForm/HyperPayCopyAndPayForm.php

I am not sure if PayTabs allows payments without collecting the billing info, I will close this issue for now, please reopen in case it's still needed.

Anas_maw → created an issue.

The latest patch added it to src/PluginForm/HyperPayCopyAndPayForm.php and the previous one added it to src/PluginForm/HyperpayForm.php

I think we will need a single patch to add them both, right?

Hello hamzadwaya,
I think your patch still missing the same change to src/PluginForm/HyperPayCopyAndPayForm.php

Also, my concern about this is that for orders with a total amount of 4.123 for example, if you pass 4.12 to Hayperpay, then the order status will not be paid because of 0.003 left, anyway, I think we should commit this, please make sure to fix your patch ASAP.

Thanks

Could you please list the ckeditor_templates_ui module on the module page?

Thanks for moving the issue to ckeditor_module, I'm really sad to see that the owners of ckeditor_module decided to take the features that I did on this module and include them in the ckeditor_module without any notice

@hamzadwaya, all of your changes are committed, except

// HyperPay requires the amount to be formatted with two digits after the decimal point.
'amount' => number_format((float) $payment_amount->getNumber(), 2, '.', ''),

I wrote a comment on the MR, please check it, also let's open a separate ticket for this issue as it's not related to Drupal 10 compatibility

The owners of the ckeditor_templates → module decided to include the features provided by this module in their module, so this module will not be needed when they fixed the mentioned issue.
At the same time, there is a new module ckeditor5_template → which provides the CKEditor 5 feature, we integrated ckeditor_templates_ui module with ckeditor5_template in a separate branch, and this is mentioned on the module page.

Good catch

Anas_maw → created an issue.

Great, Thanks

Great, Thanks

I will close this, feel free to reopen if you can provide us with a patch or MR

Sure, Thanks

This module now support Ckeditor 5 in the 2.x version, it's now depend on CKEditor 5 Template →

Duplicate 🐛 Use of "static" in callables is deprecated Fixed

Works for me too, thanks

CKEditor Templates UI saves the templates in database :)

@dbielke1986, sorry for my late response, we can make enhancements to my module to support all the mentioned above, appreciate it if you could list my module in your project, so people can install it and help me in adding these features, until now 92 sites are using my module with yours without listing it in your project and this number is very good in this stage, which means that people finds it useful, please add it to your project so I can get some help from the community.

Here is an updated patch to work on the latest 2.2

Currently, the UI module disables the path input, adding a link to the configuration is a good idea.
Importing already existing templates can be done, but I'm not sure if it's the correct way, as this may confuse the users, if you list the UI module in your module page, people will install both modules together and they will not need to do the path configuration part from the first.

@dbielke19886 regarding point number 2, our module creates a configuration entity for templates and overrides the path file method, that's why the existing templates will not appear, what do you think?

@Nelo_drup could you please confirm if the 2.x branch is working as expected or not?

@dbielke19886 can you please list what is the problem, I tried it and it's working as expected.

Anas_maw → created an issue.

Good news, I found some time today and implemented the integration with https://www.drupal.org/project/ckeditor5_template → module
Please check the 2.x release

Yes, we can support this new module in a separate branch, appreciate your help in this, as I'm really busy in these days.

#7 solved the issue for me

Anas_maw → created an issue.

Anas_maw → created an issue.

Related issue 📌 Support ckeditor 5? Postponed

You are talking about a patch wich is not committed yet, postponed until ✨ CKEditor 5 support for Content Templates Needs review

Hello everyone, I'm the maintainer of ckeditor_templates_ui → module, I'm just waiting for this issue to be fixed to complete the Ckeditor 5 integration with my module, no need to add this feature to this module.

Seems like you didn't understand the point, Gin theme overrides the main core/drupal.dialog.off_canvas library, this will affect all themes, either if it's the default theme or the admin theme.
So if I'm using gin as admin and bootstrap as default theme, the dialog will be styled as gin theme in the default theme

Anas_maw → created an issue.

Done as requested

Please review my PR

Anas_maw → made their first commit to this issue’s fork.

Anas_maw → made their first commit to this issue’s fork.

Updating the patch to use the injected moduleHandler and using the alter method instead + changing the hook name to not get interrupted with hook_simplesamlphp_auth_user_attributes

This is a very important issue, especially for high-traffic websites.

Having the same issue #3 is working for me

Reroll patch in #3 to work on the latest dev version for temporary solution

Anas_maw → created an issue.

+1 for RTBC

I'm facing the problem on Drupal 9

Anas_maw → created an issue. See original summary → .

Anas_maw → created an issue.

Thanks everyone

Committed thanks

Thanks, @heshamkh, but I change in InotifyNotificationListBuilder.php may cause an issue, as the email field in the user entity is not required

will be committed

Big changes

Committed with minor changes, thanks

Thanks, @Vinodhini.E but the module support 8.8 and above

I have been using the patch on a live website form more than 4 months without any issues, so I will mark it as RTBC

I have been using the patch on a live website form more than 4 months without any issues, so I will mark it as RTBC

Sure there will be, but this is postponed until ✨ CKEditor 5 support for Content Templates Needs review

Please find attached screeshot

jQuery not missing.

I'm getting the same issue here

Patch in 11 worked for me but it's missing the use statement, here is a new patch, I will update the MR also

This is a patch for the only missing thing.

I can see - drupal:ckeditor5_dev in requirements in modules/video_embed_wysiwyg/video_embed_wysiwyg.info.yml

I think it should be - drupal:ckeditor5

Fixed

Anas_maw → created an issue.

Anas_maw → created an issue.