- First commit to issue fork.
- Merge request !304Issue #3080552 by zaporylie, anas_maw: Don't show expired payment method as an option in checkout → (Merged) created by Unnamed author
- Status changed to RTBC
4 months ago 12:36pm 14 August 2024 - 🇳🇴Norway zaporylie
It makes sense to me so moving to RTBC. Added test assert to cover this bug.
-
jsacksick →
committed aa542a63 on 8.x-2.x authored by
zaporylie →
Issue #3080552 by zaporylie, anas_maw: Don't show expired payment method...
-
jsacksick →
committed aa542a63 on 8.x-2.x authored by
zaporylie →
- Status changed to Fixed
4 months ago 12:42pm 14 August 2024 -
jsacksick →
committed a6bf3a02 on 3.0.x authored by
zaporylie →
Issue #3080552 by zaporylie, anas_maw: Don't show expired payment method...
-
jsacksick →
committed a6bf3a02 on 3.0.x authored by
zaporylie →
- 🇮🇱Israel jsacksick
Maybe we should add this check for non reusable payment methods only?
So:
if ((!$order_payment_method->isReusable() && $order_payment_method->isExpired())?
To address the nonce usecase (i.e. short lived payment methods?)
- 🇯🇴Jordan Anas_maw
@jacksick, thanks merging the patch, could you please give us the fix credit :)
- 🇮🇱Israel jsacksick
Your username was specified in the commit message, not really sure why that doesn't give you credit...
- 🇳🇴Norway zaporylie
I see I didn't get one either even though I made sure both our nicknames are included in the MR title/commit. Seems like this works differently nowadays than what I am used to.
Automatically closed - issue fixed for 2 weeks with no activity.